Add region support for europe-west2 and asia-east2 #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @bkendall for readability. Thanks Bryan! |
kevinajian
reviewed
May 8, 2019
mbleigh
approved these changes
May 8, 2019
joehan
reviewed
May 8, 2019
joehan
reviewed
May 8, 2019
joehan
approved these changes
May 8, 2019
kevinajian
approved these changes
May 8, 2019
bkendall
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for new regions
europe-west2andasia-east2to be consistent with Google Cloud Functions. The full list of regions supported:This PR also fixes a bug I discovered while refactoring where if a user initialized a function with runtimeOptions first, and then set the region, region validation would not happen. It also contains some other refactors mainly removing duplicate code in
functions-builder.ts.Testing
function-builder.spec.ts./integration_tests/run_tests.sh chenky-test-3