Skip to content

Add region support for europe-west2 and asia-east2 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2019
Merged

Add region support for europe-west2 and asia-east2 #435

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5cb164
Add new regions, fix bugs, refactor
thechenky May 8, 2019
14c54ef
change from ...region to region array
thechenky May 8, 2019
24f7c9c
add test for specifying all regions, add memory type to catch compilc…
thechenky May 8, 2019
b0ac7c3
capitalize memory type
thechenky May 8, 2019
71b326b
better check of error being thrown
thechenky May 9, 2019
cf1b7c0
add changelog
thechenky May 9, 2019
780a0f3
lower case feature in changelog
thechenky May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change from ...region to region array
  • Loading branch information
@thechenky
thechenky committed May 8, 2019
commit 14c54ef85288205a6ceece7b18d790cf270a1a74
12 changes: 6 additions & 6 deletions src/function-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function assertRuntimeOptionsValid(runtimeOptions: RuntimeOptions): boolean {
* @param regions list of regions.
* @throws { Error } Regions must be in list of supported regions.
*/
function assertRegionsAreValid(...regions: string[]): boolean {
function assertRegionsAreValid(regions: string[]): boolean {
if (!regions.length) {
throw new Error('You must specify at least one region');
}
Expand All @@ -104,7 +104,7 @@ function assertRegionsAreValid(...regions: string[]): boolean {
* For example: `functions.region('us-east1')` or `functions.region('us-east1', 'us-central1')`
*/
export function region(...regions: string[]): FunctionBuilder {
if (assertRegionsAreValid(...regions)) {
if (assertRegionsAreValid(regions)) {
return new FunctionBuilder({ regions });
}
}
Expand All @@ -116,7 +116,7 @@ export function region(...regions: string[]): FunctionBuilder {
* 2. `memory`: amount of memory to allocate to the function,
* possible values are: '128MB', '256MB', '512MB', '1GB', and '2GB'.
*/
export function runWith(runtimeOptions: RuntimeOptions) {
export function runWith(runtimeOptions: RuntimeOptions): FunctionBuilder {
if (assertRuntimeOptionsValid(runtimeOptions)) {
return new FunctionBuilder(runtimeOptions);
}
Expand All @@ -142,8 +142,8 @@ export class FunctionBuilder {
* @param regions One or more region strings.
* For example: `functions.region('us-east1')` or `functions.region('us-east1', 'us-central1')`
*/
region(...regions: string[]) {
if (assertRegionsAreValid(...regions)) {
region(...regions: string[]): FunctionBuilder {
if (assertRegionsAreValid(regions)) {
this.options.regions = regions;
return this;
}
Expand All @@ -156,7 +156,7 @@ export class FunctionBuilder {
* 2. memory: amount of memory to allocate to the function, possible values are:
* '128MB', '256MB', '512MB', '1GB', and '2GB'.
*/
runWith(runtimeOptions: RuntimeOptions) {
runWith(runtimeOptions: RuntimeOptions): FunctionBuilder {
if (assertRuntimeOptionsValid(runtimeOptions)) {
this.options = _.assign(this.options, runtimeOptions);
return this;
Expand Down