Skip to content

[firebase_dynamic_links] support v2 embedding #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bparrishMines merged 13 commits into from
Nov 21, 2019
Merged

[firebase_dynamic_links] support v2 embedding #1372

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0fde000
Implement FlutterPlugin and ActivityAware
bparrishMines Oct 23, 2019
804dd03
Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…
bparrishMines Nov 5, 2019
2407dc9
Setup tests
bparrishMines Nov 5, 2019
8f46c64
Add e2e tests to MainActivity
bparrishMines Nov 5, 2019
2d28e84
Formatting
bparrishMines Nov 5, 2019
21afcbe
version bump
bparrishMines Nov 5, 2019
4cb1fa9
Update dynamic links version
bparrishMines Nov 5, 2019
6925021
Remove splashscreen from MainActivity
bparrishMines Nov 11, 2019
48452fe
Add an actual test
bparrishMines Nov 12, 2019
0cf3010
Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…
bparrishMines Nov 12, 2019
526b88b
Documentation
bparrishMines Nov 13, 2019
8a0f6d5
Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…
bparrishMines Nov 20, 2019
5e6e755
Use activity paramter
bparrishMines Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Documentation
  • Loading branch information
@bparrishMines
bparrishMines committed Nov 13, 2019
commit 526b88bccd1c5a777083aaff8c244115c5c0e982
21 changes: 20 additions & 1 deletion ...oid/src/main/java/io/flutter/plugins/firebasedynamiclinks/FirebaseDynamicLinksPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@
import java.util.List;
import java.util.Map;

/** FirebaseDynamicLinksPlugin */
/**
* Flutter plugin accessing for Firebase Dynamic Links API.
*
* <p>Instantiate this in an add to app scenario to gracefully handle activity and context changes.
*/
public class FirebaseDynamicLinksPlugin
implements FlutterPlugin, ActivityAware, MethodCallHandler, NewIntentListener {
private Registrar registrar;
Expand All @@ -42,8 +46,23 @@ private FirebaseDynamicLinksPlugin(Registrar registrar, MethodChannel channel) {
this.channel = channel;
Copy link
Contributor

@xster xster Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to pass this in right? The less potentially dangling nulls there are (depending on the path you take), the less likely there will be accidental null pointer exceptions

Copy link
Contributor Author

@bparrishMines bparrishMines Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should need it. The FirebaseDynamicLinks plugins makes callbacks to dart: https://github.com/FirebaseExtended/flutterfire/pull/1372/files#diff-3f6c424218a2662c8ddc4b322f30bf66R81.

I could hold on to a BinaryMessenger and instantiate a MethodChannel every time we want to call invokeMethod, but I think this looks cleaner.

}

/**
* Default Constructor.
*
* <p>Use this when adding the plugin to your FlutterEngine</p>
*/
public FirebaseDynamicLinksPlugin() {}

/**
* Registers a plugin with the v1 embedding api {@code io.flutter.plugin.common}.
*
* <p>Calling this will register the plugin with the passed registrar. However, plugins
* initialized this way won't react to changes in activity or context.
*
* @param registrar attaches this plugin's {@link
* io.flutter.plugin.common.MethodChannel.MethodCallHandler} to the registrar's {@link
* io.flutter.plugin.common.BinaryMessenger}.
*/
public static void registerWith(Registrar registrar) {
final MethodChannel channel = createChannel(registrar.messenger());
final FirebaseDynamicLinksPlugin plugin = new FirebaseDynamicLinksPlugin(registrar, channel);
Expand Down