Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…
… dynamic_embedding
  • Loading branch information
bparrishMines committed Nov 20, 2019
commit 8a0f6d545bcdab0bf5980c4b2da20433c31de007
6 changes: 5 additions & 1 deletion packages/firebase_dynamic_links/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## 0.5.0+7
## 0.5.0+8

* Support v2 embedding. This will remain compatible with the original embedding and won't require app migration.

## 0.5.0+7

* Add `getDynamicLink` to support expanding from short links.

## 0.5.0+6

* Updated README instructions for contributing for consistency with other Flutterfire plugins.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,8 @@ private Map<String, Object> getMapFromPendingDynamicLinkData(
return dynamicLink;
}

private void handleGetInitialDynamicLink(final Result result) {
// If there's no activity, then there's no initial dynamic link.
if ((registrar != null && registrar.activity() == null) && activityBinding == null) {
result.success(null);
return;
}

FirebaseDynamicLinks.getInstance()
.getDynamicLink(getActivity().getIntent())
.addOnSuccessListener(
private void addDynamicLinkListener(Task<PendingDynamicLinkData> task, final Result result) {
task.addOnSuccessListener(
new OnSuccessListener<PendingDynamicLinkData>() {
@Override
public void onSuccess(PendingDynamicLinkData pendingDynamicLinkData) {
Expand All @@ -214,7 +206,23 @@ public void onFailure(Exception e) {
}

private Activity getActivity() {
return registrar != null ? registrar.activity() : activityBinding.getActivity();
return registrar != null ? registrar.activity() : activityBinding.getActivity();
}

private void handleGetDynamicLink(final Result result, Uri uri) {
addDynamicLinkListener(FirebaseDynamicLinks.getInstance().getDynamicLink(uri), result);
}

private void handleGetInitialDynamicLink(final Result result) {
// If there's no activity, then there's no initial dynamic link.
if (registrar.activity() == null) {
result.success(null);
return;
}

addDynamicLinkListener(
FirebaseDynamicLinks.getInstance().getDynamicLink(registrar.activity().getIntent()),
result);
}

private OnCompleteListener<ShortDynamicLink> createShortLinkListener(final Result result) {
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_dynamic_links/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: firebase_dynamic_links
description: Flutter plugin for Google Dynamic Links for Firebase, an app solution for creating
and handling links across multiple platforms.
version: 0.5.0+7
version: 0.5.0+8

author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_dynamic_links
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.