Add Travis CI for linting #197
Conversation
|
@AbeHaskins PTAL. I think I got all the |
| for (let r = 0; r < 5*Math.random(); r++) { | ||
| const rating = this.data.ratings[ | ||
| var ratingPromises = []; | ||
| for (var r = 0; r < 5*Math.random(); r++) { |
There was a problem hiding this comment.
I just noticed how amazing this is. The r < 5 * Math.random() part will execute on each loop so it's super, duper random.
There was a problem hiding this comment.
That's pretty funny. I wonder what the distribution of actual r's is lol.
| for (let r = 0; r < 5*Math.random(); r++) { | ||
| const rating = this.data.ratings[ | ||
| var ratingPromises = []; | ||
| for (var r = 0; r < 5*Math.random(); r++) { |
There was a problem hiding this comment.
That's pretty funny. I wonder what the distribution of actual r's is lol.
| importScripts('/__/firebase/4.8.1/firebase-messaging.js'); | ||
| importScripts('/__/firebase/init.js'); | ||
|
|
||
| const messaging = firebase.messaging(); |
There was a problem hiding this comment.
The switch here is debatable because FWIW any browser that supports service workers are also gonna support es6 syntax, but I guess it's fine for consistency.
There was a problem hiding this comment.
Good point. Maybe we revisit the ES6 decision but as it stands it's easier to just be consistent.
|
Ya'll got another PR brewing for friendlyeats-web so they stay consistent? |
|
@AbeHaskins I'll get that friendlyeats PR going now, good call. |
nicolasgarnier
left a comment
nicolasgarnier
left a comment
There was a problem hiding this comment.
Small nits, otherwise LGTM :)
firestore/.eslintrc.json
Outdated
| "importScripts": true, | ||
| "FriendlyEats": true | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Add missing End of file line break :)
messaging/.eslintrc.json
Outdated
| "globals": { | ||
| "importScripts": true | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Add end of file Line break :)
scripts/test.sh
Outdated
| set -e | ||
| # Run linter | ||
| find . -type f -name "*.js" -not -path "*node_modules*" \ | ||
| | xargs eslint No newline at end of file |
There was a problem hiding this comment.
Add end of file line break
.travis.yml
Outdated
| - npm install -g eslint | ||
| - lerna bootstrap | ||
| script: | ||
| - ./scripts/test.sh No newline at end of file |
There was a problem hiding this comment.
Add end of file line break
database/scripts/main.js
Outdated
| */ | ||
| 'use strict'; | ||
|
|
||
| var componentHandler = componentHandler || undefined; |
There was a problem hiding this comment.
Maybe add componentHandler to the globals instead ?
|
LGTM! Thanks for doing this @samtstern ! |
3 participants
No description provided.