Address review feedback

firebase · nicolasgarnier · Mar 2, 2018 · Feb 13, 2018 · Feb 13, 2018 · Mar 2, 2018
commit e13049f12d811518e31ca60c1ae3fa8b30fc24c3
diff --git a/.travis.yml b/.travis.yml
@@ -6,4 +6,4 @@ install:
   - npm install -g eslint
   - lerna bootstrap
 script:
-  - ./scripts/test.sh
+  - ./scripts/test.sh
diff --git a/database/.eslintrc.json b/database/.eslintrc.json
@@ -0,0 +1,5 @@
+{
+    "globals": {
+        "componentHandler": true
+    }
+}
diff --git a/database/scripts/main.js b/database/scripts/main.js
@@ -15,7 +15,6 @@
  */
 'use strict';
 
-var componentHandler = componentHandler || undefined;
 
 // Shortcuts to DOM Elements.
 var messageForm = document.getElementById('message-form');

diff --git a/firestore/.eslintrc.json b/firestore/.eslintrc.json
@@ -5,4 +5,4 @@
         "importScripts": true,
         "FriendlyEats": true
     }
-}
+}
diff --git a/messaging/.eslintrc.json b/messaging/.eslintrc.json
@@ -2,4 +2,4 @@
     "globals": {
         "importScripts": true
     }
-}
+}
diff --git a/scripts/test.sh b/scripts/test.sh
@@ -1,4 +1,4 @@
 set -e
 # Run linter
 find . -type f -name "*.js" -not -path "*node_modules*" \
-  | xargs eslint
+  | xargs eslint
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,4 +5,4 @@ @@
             "importScripts": true,
             "FriendlyEats": true
         }
-    }
+    }