Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX-1421: detect declared-but-unsupported workforce-tree entries #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
FIX-1421: detect declared-but-unsupported workforce-tree entries #1885
Changes from 1 commit
6db52f3310c3dde06a33a574d026d043f57717f965d148ff9c527fdaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Greptile: the P1 was only half fixed, and the half left behind was the worse half. Reproduced exactly as reported — one line appended to overview.md ("A tool lives at `org/tools/scanner.md` and is read at boot") and the suite stayed green on 4 passed. **This is the sharpest instance this epic has produced, and it is mine.** The previous commit anticipated this exact critique, argued structural normalization avoided it, and named `org/tools/…` as the proof. The normalization is structural and that part was true. The FILTER IN FRONT OF IT was not: `toShape` required a segment drawn from a vocabulary of slots already known, so the one case the completeness check exists for — a slot nobody has written down yet — was discarded before normalization could see it. A self-confirming scan sitting inside the fix for the self-confirming scan, defended in a PR body by the example that disproves it. The filter's job was rejecting refs and folder mentions, and it did that by asking "is this built from parts we already recognize?" — the wrong question. The leaf test above it already answers the right one: a shape ends in a file, a ref and a folder mention do not. Measured rather than argued: over the whole published surface, removing the slot check changes the extracted set by ZERO shapes. It was rejecting nothing and hiding the only thing that mattered. An unrecognized segment now stays literal and fails by name. **`PUBLISHED_FILES` was hand-maintained while calling itself the published surface** — the same defect one level up, so it is derived now. Every `.md` under the workforce and skills doc trees is read, so a page added to either is scanned the moment it lands. What stays manual is which directories, which is a much smaller claim, and the residual scope is stated rather than implied: a page published elsewhere is not scanned and this suite will not say so. Regression added, synthetic because the slot must not exist: an unrecognized slot must come out of the extraction spelled as itself, and a ref and a folder mention must still not. Proved red by restoring the old filter (`expected [] to deeply equal [ 'org/tools/scanner.md' ]`), and proved end to end by re-running the reported reproduction, which now fails naming the path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ULydJv3JEeMUgeZbSvm4RtUh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.