Repository navigation
FIX-1421: detect declared-but-unsupported workforce-tree entries #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6db52f3
fix(workforce): classify `controlTools` for per-seat preset selection
claude 310c3dd
docs(workforce): correct the module header my own change made stale
claude e06a33a
test(workforce): pin the control-through-the-fence behaviour
claude 574d026
FIX-1421: detect declared-but-unsupported workforce-tree entries
claude d043f57
FIX-1421: cite the real promise, and stop a prefix standing in for a …
claude 717f965
FIX-1421: guard the derivation in both directions, and parse codegen …
claude d148ff9
FIX-1421: shrink the loader-door note to the rule and a pointer
claude c527fda
FIX-1421: stop the extraction discarding slots it has never seen
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking behaviour to exact
it("…")strings in this file will rot when someone renames tests. The fence vs control distinction is worth documenting; I'd describe the invariant in prose and point atseat-capabilities.test.tswithout quoting titles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not mine to act on — flagging rather than silently ignoring.
seat-capabilities.tscame from #1880 (fix/classify-control-tools-seat-selection), which I merged into this branch only becausemainwas red on itsTS2344and this branch wouldn't typecheck without it. #1880 has since merged tomain, so that file is no longer in this PR's diff — which is now 2 files,loader/index.tsand the test.The point itself looks sound (quoting
it("…")titles rots on rename; describe the invariant and point at the file). It just belongs to whoever owns that code, not to a defect-class detector — editing it here would put an unrelated change back into a diff that just shrank to the thing under review.Generated by Claude Code