Skip to content

Publish Shift Manager as @flow-state-dev/shift-manager with a shift-manager command and --dev (FIX-1770 PR-C) - #2759

Merged
jhoffner merged 5 commits into
mainfrom
claude/fix-1770-publish-shift-manager-gqxure
Oct 6, 2026
Merged

jhoffner merged 5 commits into
mainfrom
claude/fix-1770-publish-shift-manager-gqxure

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Jake · project thread

Today, Shift Manager runs only from a checkout of this repository. You build the pages, then start labs/shift-manager/bin/start.mts. Someone with their own Lab has no way to run it.

What this does

Shift Manager is published as @flow-state-dev/shift-manager. You install it in the project that holds your Lab and run npx shift-manager --config ./fsdev.config.mts. The pages ship built, so nothing compiles. --dev restarts the Lab when you save one of its files, and the open page reloads. The command is a thin wrapper over fsdev dev --app, so the Lab's API, the pages and the DevTool are served the way fsdev dev serves them.

Before: two terminals and a lab script, checkout only. After: one installed command over fsdev's app hook and node's serve()

This PR adds the Shift Manager half of the picture.

What's asked of you

The decisions follow the approved spec. As D2 says, --team, --devtool and --devtool-assets are removed. The devteam profile stays in the repository, where pnpm --filter @flow-state-dev/shift-manager dev runs it.

Parts worth reviewing closely

  1. packages/shift-manager/cli/bin.ts. This is the whole command. It finds the config, then calls executeDevCommand with --app set to its own module file. Check that --dev passes through only as --watch, and that a non-loopback --host is refused under --dev.
  2. The watch-child shutdown ceiling in packages/cli/src/commands/dev.ts. The goal check found this. When runs are still going, dispose() waits up to 30 s for them. That held every --dev restart for that long. A watch child now exits after at most 3 s. Is cutting off a run that is still going acceptable for a dev restart? (It is a new process either way.)

Part of FIX-1770, PR 3 of 3 (the order is in D3) · spec: specs/issues/FIX-1770/ on main, reviewed in #2734 · PR-B: #2740 (merged) · PR-A: #2735 (merged).

How to review this: altitude, what's in scope, what's deliberately unsettled

How to review this. This implements an approved spec — the approach and the numbered
decisions in its DECISIONS.md are already signed off by a human, so please review the
code against that direction, not the direction itself. The canonical set is retained
at specs/issues/<ISSUE-ID>/ on main; Linear links to it and the original merged spec
PR, which keeps review history. Follow-up amendment PRs explain later direction changes.
Current architecture docs remain the authority for shipped behavior (BP-037).

Most valuable here: correctness on the second path (the legacy shape, the null
boundary, the concurrent case, the cancel path), anything deriving an auth or routing
decision from caller-controllable input, and a behaviour the tests assert around
rather than on.

Already settled upstream: the approach and every decision in the spec's DECISIONS.md
(human-approved — if one is wrong, say so as a spec finding and it gets folded back; don't
re-argue it inline), and the conventions in docs/contributing/best-practices.md.

Engineering calls: decided along the way, no product sign-off needed
  • fsdev dev --app also takes a package's module-file path. Shift Manager names itself by its own file, so the command works from any directory, even one where the package isn't resolvable. If this is wrong, the command only works where @flow-state-dev/shift-manager resolves from the current directory.
  • A --watch child exits after at most 3 s on a restart (WATCH_SHUTDOWN_CEILING_MS). The goal check showed a held run delaying a restart past 20 s. Without --watch, shutdown is unchanged. If this is wrong, a long run held over a restart is cut off, which is what killing the process would do anyway.
  • locateConfig is exported from @flow-state-dev/fsdev, so the command finds a config the same way fsdev dev does.
  • The package moves from labs/shift-manager to packages/shift-manager. It is published, and the packed-install check packs every package under packages/. teams/, test/ and src/ stay out of the tarball.
  • start and dev in the repository go through scripts/checkout.mts. start builds the pages first when they're older than their source. dev runs --dev, and from a checkout it serves the pages from source through Vite.
Everything else: verification with red states, docs, files

Checks. Typecheck passes for @flow-state-dev/fsdev and @flow-state-dev/shift-manager. validate-package-boundaries passes. The fsdev suite passes (27 files, 344 tests), with dev-watch.test.ts also run under a 4-core CPU load. The shift-manager suite passes (29 files, 345 tests, 1 skipped).

Check Green Red state
VG: goals/shift-manager/it-runs-from-an-install, plain PASS — 28 tarballs npm-installed into an empty project; … TEAMS draws the tree's 4 workers …; Open trace … opened the DevTool on the run's session …; saving …/auditor/WORKER.md … showed on the open Roster after 4.8 s, no reload by the check
VG, GOAL_CONTROL=no-page-config FAIL — a:Open trace opens the Lab's session: the inspector's trace link is absent …; b:the change shows: 20 s after saving …WORKER.md …, the Roster still draws lab.auditor on audit
VG, GOAL_CONTROL=no-watch FAIL — b:the change shows: 20 s after saving …WORKER.md …, the Roster still draws lab.auditor on audit
V7: the tarball holds dist/bin.js, dist-client/index.html and profiles/, and no src/, teams/ or test/ pnpm pack: 0 files under src/, teams/ or test/ prepublishOnly with dist-client/ moved away exits 1: refusing to publish without its build. missing: dist-client/index.html
V8: no bin/start.mts and no shift-manager-devtool meta command.test.ts the same test scans every shipped and tested file
V10: packed install the new shift-manager.mjs fixture runs in CI's Packed release installs and imports
A --watch restart while a run holds shutdown dev-watch.test.ts: restarts within seconds before the ceiling: no restart within 15000ms
--app <module file> from a directory where the package doesn't resolve dev-app.test.ts

V9: every other goals/shift-manager/ goal on this commit. Seven passed on the first run. Three failed in their build step with Could not resolve "../../scripts/build-inputs.mjs": it-draws-v2s-look, it-takes-its-look-from-the-design-system and a-lab-is-worked-through-one-skinned-shell. That failure is on main too. FIX-1760 added the import, and these goals build a copy of the package outside the workspace. it-draws-v2s-look fails the same way on PR-B's head, which is main plus fsdev. goals/lib/shift-manager.mts now points the copy's Vite config at the workspace's script, the same way it already points its tsconfig. After that, both look goals PASS. The closure goal (a-lab-is-worked-through-one-skinned-shell) re-ran its whole sweep: legs a–d, J3 and J4 PASS, and every goal and control it re-runs under P3.2 and P3.3 gives its expected verdict. Three of its own leg controls (optimistic-post, worker-session, no-org) first came back WRONG, failing at setup with esbuild's The service is no longer running, an infrastructure failure during a run of over an hour. Re-run on their own, all three FAIL as expected (optimistic-post at a4 and b:post, worker-session at a2, no-org at b:org); the output is in a comment on this PR.

The control's named assertion was corrected. no-page-config was written to fail TEAMS. It fails Open trace and the change shows instead, because the page's reads work without the config. goal.md and the run's header now name what it fails, and a separate spec amendment PR corrects the same line in the spec.

Docs. apps/docs/docs/shift-manager/overview.md now covers installing and running, --dev, and working on Shift Manager itself. packages/shift-manager/README.md, apps/docs/docs/api/cli.md (the --app module-file note) and the glossary are updated. Changesets: patch for @flow-state-dev/shift-manager (first publish) and @flow-state-dev/fsdev.

🤖 Generated with Claude Code

https://claude.ai/code/session_018KBgKPRLfqjmV2LS88Eg9S


Generated by Claude Code

@jhoffner jhoffner self-assigned this Oct 5, 2026
@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 6, 2026 1:20am UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 6, 2026 1:20am UTC
flow-state-dev-ui Ignored Ignored Preview Oct 6, 2026 1:20am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T01:14:43.074799Z 347de9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@linear-code

linear-code Bot commented Oct 5, 2026

Copy link
Copy Markdown

FIX-1770

@cursor

cursor Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 395873c1-a3a0-4bd2-be75-b53d5ab90e1f)

@jhoffner jhoffner left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second-look + architecture pass on #2759. I read cli/bin.ts, scripts/checkout.mts, the dev.ts diff and package.json. I did not re-run the goals, and the 199-file move is mostly renames, so I did not review it line by line. Findings are in order of weight. The spec's decisions are not re-argued.

1. The 3 s shutdown ceiling is a hard process.exit, and the engine already has a drain budget for this (packages/cli/src/commands/dev.ts, withSignals).

  • createFlowState takes dispatchDrainTimeoutMs, a true ceiling on the drain, with a 30 s default (packages/engine/src/flowstate/types.ts:207, createFlowState.ts:120). The 30 s the PR body complains about is that default.
  • A watch child could pass a small value, around 2 s, when it builds its runtime. dispose() would then stop waiting on its own, and the normal teardown would still run: closeStores, the Vite and DevTool closes, and handle.close().
  • The timer race skips all of that. At 3 s, process.exit leaves the SQLite store un-closed, so WAL checkpointing is skipped. Any in-flight runs are left in whatever state a kill leaves them in.
  • The PR's answer to "is cutting off a run acceptable" is "yes, a kill does the same". The drain budget cuts off the same runs, but the stores are closed cleanly.
  • Please check whether resolveDevRuntime can pass dispatchDrainTimeoutMs (only when reload !== undefined). If so, drop WATCH_SHUTDOWN_CEILING_MS and the ceilingMs parameter on withSignals. That puts the change in one place, the runtime's drain option, rather than a second shutdown path.
  • If it can't be passed for some reason, keep the ceiling, but run closeStores before it fires or say why the skipped close is safe. The PR body does not say which of these cases applies.
  • A restart that cuts off a run also needs a test of what state that run reads as in the store after the restart. dev-watch.test.ts proves the restart is fast. It does not prove the cut-off run is recoverable. Per BP-035, that is the cancel path.

2. The --dev non-loopback refusal is not in bin.ts, and the PR body asks reviewers to check it there.

  • The refusal lives in executeDevCommand (dev.ts:178), which is the right place. bin.ts only passes watch: values.dev === true, so that part of the checklist is fine.
  • For the non-loopback case, nothing in command.test.ts is named as covering the shift-manager --dev --host 0.0.0.0 path. Does a shift-manager test assert it? A test inside fsdev proves the guard exists. It does not prove this command can't route around it, for example through --assets or pageMeta. A one-line test would settle it.

3. package.json keeps main and exports pointing at ./cli/index.ts, and relies on publishConfig to override them.

  • This works with pnpm and npm publish. A plain npm pack and some other tools ignore publishConfig.exports.
  • The PR already guards the build with prepublishOnly and has the packed-install fixture. Does the packed-install fixture assert the packed package.json has exports.default === ./dist/index.js? If not, add that one assertion. It is the main place a published package breaks without a failing check.

4. --assets <dir> is a flag the spec's D2 removal list doesn't mention, and it duplicates fsdev's --app <dir>.

  • The wrapper resolves it against invokedFrom and passes it as app. That is a second spelling of an fsdev flag, and it lives on a command described as a thin wrapper.
  • It is probably needed for working on the pages. If so, say that in the bin.ts header. The header only lists the flag. If nothing needs it beyond checkout.mts, drop it.

5. Two duplicated or undeclared things in bin.ts.

  • The default port 4300 is a literal in parseArgs. Is it also written in the docs or in checkout.mts? If the number appears in more than one place, name it once.
  • shiftScheme re-reads and re-parses profiles/*.json on each call. That is fine as it stands, since it runs once. This is an observation, not a request.

6. The restructure is the right call, and the two-path split is worth keeping.

  • A package for the published command with scripts/checkout.mts as the repo-only wrapper keeps build-inputs and the stale-build check out of the tarball. That is a clean seam.
  • The cost is that --dev re-runs checkout.mts with pinned arguments, which means two argument parsers (checkout.mts's has() and bin.ts's parseArgs) both read the same flags. Parsing --dev=... or --assets differently in the two will drift silently. checkout.mts only needs three booleans, so this is cheap to leave alone. Add a comment in bin.ts that checkout.mts also reads --dev, --assets and --config, so the next flag added to one is added to the other.

Verification claims I could not check from here.

  • V9: the three goals that failed on main too, and the fix to goals/lib/shift-manager.mts. That is a separate fix that rides in this PR. If a separate PR for it is cheap, a failure on main is easier to read when it is not bundled with a 199-file move.
  • The three leg controls (optimistic-post, worker-session, no-org) that returned WRONG from an esbuild crash were not re-run. The PR is honest about it. They should be re-run on this head before merge, since a control that never ran cannot show the check can fail.

Nothing here blocks the direction. Item 1 is the one worth changing before merge.


Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

The core approach is the right simplification. Deleting labs/shift-manager/bin/start.mts (~350 lines of bespoke serve(), scratch copies, and parallel DevTool wiring) and replacing it with a thin shift-manager bin on executeDevCommand + the fsdev --app hook is aligned with how DevTool already ships. I would not revert toward a second server stack in the app package.

What this PR adds beyond that win is mostly verification surface (install goal, packed-install fixture, publish guards, CLI module-file --app, watch shutdown ceiling). That is proportionate to “publish + prove tarball install,” though a few pieces duplicate logic that already exists elsewhere and will drift unless shared.


What went well (simplify lens)

  • Single hosting path: cli/bin.ts delegates serving, bind guards, DevTool sidecar, and --dev restarts to fsdev — the complexity belongs in the platform, not Shift Manager.
  • Artifact split is clear: dist-client/ (pages) vs dist/ (CLI) + prepublishOnly / check-pages.mjs mirrors devtool’s release discipline without re-implementing hosting.
  • Meta contract aligned: connection.ts reads fsdev-devtool-url (same as fsdev’s pageMeta), which removes the old shift-manager-devtool one-off.
  • Net line count: large delete of start.mts and its tests; new code is mostly tests/goals/docs.

Where complexity crept in (optional follow-ups, not blockers)

Area Concern Simpler direction
Install goal it-runs-from-an-install/run.mts inlines release:build + per-package pnpm pack + npm install. scripts/packed-install/run.mjs already encodes publishable filtering (publishableDists) and the same loop. Reuse shared pack/install helpers; keep only anti-game + Playwright legs in the goal. Reduces drift vs CI packed-install.
Banner parsing Regex on stderr (App: / Data: / DevTool:) appears in goals/lib/shift-manager.mts, test/command.test.ts, and scripts/packed-install/fixtures/shift-manager.mjs. Export a small parser from @flow-state-dev/fsdev next to the banner writer, or standardize on HTTP readiness when the port is known (the install goal already does this — good).
CLI errors Local Refusal + duck-typed exitCode in bin.ts parallels fsdev’s internal CliError, which is not exported. If we expect more --app wrapper CLIs, exporting CliError (or a narrow config error) from fsdev is cleaner than N copies of Refusal.
Meta constant DEVTOOL_META = "fsdev-devtool-url" in app code while fsdev exports DEVTOOL_URL_META. Import the exported constant in the SPA if the bundle graph allows it — avoids silent drift.
Checkout script checkout.mts mutates process.argv then dynamic-imports bin.ts. Works, but exporting runShiftManager(argv) or spawning the bin explicitly would be easier to follow. Low priority; repo-only.
Docs labs/README.md still lists labs/shift-manager and --team devteam; package lives under packages/shift-manager with --config / shift-manager CLI per user docs. One table-row update (in this PR or immediately after) so lab index matches reality.

Uncertain (worth a quick check, not a merge gate): whether @flow-state-dev/devtool must stay a runtime dependency for published tarballs or can move to devDependencies once only the Vite bundle touches it — packed-install is the right place to validate.


Performance

No CLI hot-path regressions spotted. Removing per-start full dist tree copy is a real win. Remaining cost is in goals/CI (sequential pack, poll loops) — acceptable for those contexts.


Alternative approaches considered

  • “Just document fsdev dev --app @flow-state-dev/shift-manager” — viable for power users; the published shift-manager bin still earns its keep (default port, shift meta, INIT_CWD/chdir, checkout start/dev scripts).
  • Keep custom start.mts — would reintroduce the largest complexity; I’d reject that direction.
  • Third-party CLI framework — unnecessary; Node parseArgs + fsdev delegation is already minimal.

Approval: Direction is sound; merge-worthy with the follow-ups above as hygiene rather than architectural rework.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Comment thread packages/shift-manager/cli/bin.ts Resolved

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Snob — already tight on 347de9a1c. No POC.

I read packages/shift-manager/cli/bin.ts, cli/index.ts, scripts/checkout.mts, scripts/check-pages.mjs, packages/cli/src/dev-app.ts, the withSignals change in packages/cli/src/commands/dev.ts, test/command.test.ts, goals/lib/shift-manager.mts (servedAddresses), and goals/shift-manager/it-runs-from-an-install/run.mts.

bin.ts is what is left of the 349-line start script: the default port, the shift profile, and the missing-config message. The rest is executeDevCommand. Refusal is how one catch prints both that message and fsdev's CliError (CliError is not exported). fail() plus a second catch is longer.

checkout.mts is the repo-only stale-build check and the devteam pin. Folding its three-flag has() into bin.ts puts repository paths in the published command.

moduleFile is the file-versus-directory split so --app can be a module path from any directory. Inlining it repeats the stat. A classifier is the same length.

The 3s watch ceiling is one timer on the child. withSignals(supervisor) stays without it. Moving the timer into close() still needs the signal path. The drain-budget alternative changes how a restart shuts down; leaving that alone.

shift-manager-color-scheme is written in bin.ts and read in src/lib/color-scheme.ts. The page must not import the CLI. The App: / Data: banner parse sits in servedAddresses, command.test.ts, and the packed-install fixture. The fixture cannot import goals/, and exporting a parser from the package grows the surface. Each copy is a few lines.

check-pages.mjs and getAssetPath() check different moments. The install goal's pack loop is not packAll (that one also reads each tarball's manifest). The goal file header matches the other goal runs.

A rewrite does not shrink this contract.

Open in Web View Automation 

Sent by Cursor Automation: Code Snob

jhoffner pushed a commit that referenced this pull request Oct 5, 2026
…tch ceiling is an exit (FIX-1770 PR-C)

Review on #2759:
- command.test.ts: shift-manager --dev --host 0.0.0.0 refuses before it
  listens, with the package's pages and with --assets.
- bin.ts header: what --assets is, and that checkout.mts reads --dev,
  --assets and --config from the same arguments.
- dev.ts: why the --watch shutdown ceiling exits instead of shrinking the
  drain budget, and why the skipped store close is safe.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AYpa2x1a2xPUDxGueDEZP

jhoffner commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Answers to the second-look review, in its numbering. Changes are in d6b6203. The commit before it, 0d6625a, regenerated pnpm-lock.yaml. The patch's lockfile still listed shift-manager's dependencies the old way, and every CI job failed at pnpm install --frozen-lockfile.

  1. Watch ceiling. I kept it. dispatchDrainTimeoutMs is set when the user's config calls createFlowState, and dispose() takes no options, so resolveDevRuntime has no way to set a smaller drain on that FlowState. Adding a way would change the engine's API, which goes beyond this PR. Skipping the close is the same as a kill. A committed SQLite write survives an unclosed connection. A run left in_progress is marked interrupted by the recovery sweep (detectInterruptedRequests, at the restarted child's startup and from the router's stale-request sweeper) once its heartbeat goes stale. The engine already covers that path for a process that dies. The WATCH_SHUTDOWN_CEILING_MS comment now says this. I didn't add a cut-off-run test to dev-watch.test.ts. Its Lab uses in-memory stores, and what it would prove is the existing recovery sweep, not anything this PR adds.
  2. --dev on a network host. Added a test in command.test.ts: shift-manager --dev --host 0.0.0.0 exits 3 with Refusing --watch on 0.0.0.0 before it listens, both with the package's pages and with --assets.
  3. publishConfig.exports. The fixture already fails on this. It imports getAssetPath from @flow-state-dev/shift-manager at load time and checks that cli/ is absent from the install. So if exports pointed at ./cli/index.ts, the fixture would fail on the import. No change.
  4. --assets. Kept. It is a documented flag (README and shift-manager/overview.md), and the tests serve their stand-in build through it. The bin.ts header now says it is fsdev's --app <dir> under this command's name.
  5. Port 4300. It appears in code once, in parseArgs. The README and docs mention it as the default, which is documentation, not a second constant. No change.
  6. Two parsers. The bin.ts header now says that checkout.mts reads --dev, --assets and --config from the same arguments.

The three esbuild-crashed leg controls are a goal run of over an hour that CI doesn't run. Whoever runs the closure goal before merge should re-run them on this head.


Generated by Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 347de9a1c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .changeset/shift-manager-published.md Resolved
Comment thread .changeset/fsdev-dev-app-module-file.md Resolved
Comment thread apps/docs/docs/glossary.md Resolved
Comment thread packages/shift-manager/package.json Resolved

jhoffner commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

I re-ran the closure goal's three leg controls that crashed in esbuild, on this head (78b8e27). The command was GOAL_PART=controls GOAL_CONTROLS=optimistic-post,worker-session,no-org, run against a real model and Claude Code harness. All three gave their expected verdicts:

VERDICT control optimistic-post @ 78b8e2709: FAIL (expected) at a4 + b:post only
VERDICT control worker-session @ 78b8e2709: FAIL (expected) at a2 only
VERDICT control no-org @ 78b8e2709: FAIL (expected) at b:org only
PASS — 3 verdicts on 78b8e2709, all as expected

Each failure comes from the control's own change, not from setup. Examples: the stream drew the post while the mailbox's stored transcript held 0 copies of it, the Session draws nothing while the run session … holds 17 items, and the org switcher names "", the store's org is org_pentest_lab. That closes the PR body's open item.


Generated by Claude Code

@jhoffner
jhoffner added this pull request to stack #2779 October 5, 2026 23:40
Base automatically changed from claude/project-thread-ibr67c to main October 6, 2026 01:19
claude added 5 commits October 5, 2026 21:19
…manager CLI and --dev (FIX-1770 PR-C)

- packages/shift-manager is published as @flow-state-dev/shift-manager. It
  ships its built pages and a shift-manager command built on
  `fsdev dev --app`. `--dev` restarts the Lab on a save and reloads the page.
  The command replaces labs/shift-manager's start.mts.
- fsdev: `--app` also takes a package's module-file path, `locateConfig` is
  exported, and a --watch restart no longer waits on runs that are still
  going (it exits after at most 3 s).
- The packed-install check covers the new package. The goal
  goals/shift-manager/it-runs-from-an-install proves it from an npm install,
  with the controls no-page-config and no-watch.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018KBgKPRLfqjmV2LS88Eg9S
…cy split (FIX-1770 PR-C)

CI's frozen install refused the lockfile: it still listed every
shift-manager dependency under dependencies, while package.json keeps
only devtool and fsdev there and moves the rest to devDependencies.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AYpa2x1a2xPUDxGueDEZP
…tch ceiling is an exit (FIX-1770 PR-C)

Review on #2759:
- command.test.ts: shift-manager --dev --host 0.0.0.0 refuses before it
  listens, with the package's pages and with --assets.
- bin.ts header: what --assets is, and that checkout.mts reads --dev,
  --assets and --config from the same arguments.
- dev.ts: why the --watch shutdown ceiling exits instead of shrinking the
  drain budget, and why the skipped store close is safe.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AYpa2x1a2xPUDxGueDEZP
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AYpa2x1a2xPUDxGueDEZP
…p name the published package (FIX-1770 PR-C)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AYpa2x1a2xPUDxGueDEZP
@jhoffner
jhoffner force-pushed the claude/fix-1770-publish-shift-manager-gqxure branch from 78b8e27 to 3c60fa6 Compare October 6, 2026 01:19
@cursor

cursor Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 7e4543fb-0f9f-446f-831b-925d40c1774d)

@jhoffner
jhoffner merged commit 1c6355d into main Oct 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants