Skip to content

spec(FIX-1770): name the assertions no-page-config actually fails - #2774

Merged
jhoffner merged 1 commit into
mainfrom
spec/fix-1770-amend-3k6kx2
Oct 5, 2026
Merged

jhoffner merged 1 commit into
mainfrom
spec/fix-1770-amend-3k6kx2

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Requested by Jake · project thread

Before: FIX-1770's spec says the install check's no-page-config control must fail the sidebar's TEAMS list. It can't. TEAMS comes from the Lab's API, which still answers when the page config is gone.

After: the spec names the assertions the control actually fails: Open trace opens the Lab's session (signal a) and the change shows (signal b). This is what goals/shift-manager/it-runs-from-an-install/goal.md already says on #2759.

How: one line in specs/issues/FIX-1770/SPEC.md. Jake chose this over adding a TEAMS control, on the decision card in the FIX-1770 PR-C thread. Codex flagged the mismatch on #2759.

No changeset needed: spec only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01E4JkbyjudUYb1VEvw5wphU


Generated by Claude Code

The control removes only the page config. TEAMS comes from the page's
API reads, so it still draws; the control fails signal a at Open trace,
and signal b. Jake chose to amend the spec over adding a TEAMS control
(decision on #2759).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AYpa2x1a2xPUDxGueDEZP
@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 5, 2026 12:33pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 5, 2026 12:33pm UTC
flow-state-dev-ui Ignored Ignored Oct 5, 2026 12:33pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 5, 2026

Copy link
Copy Markdown

FIX-1770

@jhoffner jhoffner self-assigned this Oct 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T12:40:56.356263Z 6639a40 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jhoffner commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Second look / architecture pass: approve the approach, one optional nit.

Approach. Correcting the spec to name the assertions the control actually fails is the leanest fix. Adding a TEAMS-specific control would test the page config twice, so I agree with the decision recorded in the PR body. No refactor opportunity here: it is a one-line spec change, with no code to consolidate.

Nit (optional, take it only if you touch the file again). The new text names the assertion a:Open trace opens the Lab's session. The Signal row in specs/issues/FIX-1770/SPEC.md:44 describes the same check as "Open trace loads the DevTool on a session of that Lab". If the goal's run.mts uses one string, the spec should use the same string, because the control is matched by assertion name (see the must: regex pattern in goals/shift-manager/a-lab-is-worked-through-one-skinned-shell/run.mts:402). I can't confirm the string here, because it-runs-from-an-install lives on #2759, not on this branch. Check it when #2759 lands.

Also worth a glance. The mermaid at SPEC.md:33 still labels the PASS-a edge "TEAMS equals the Lab's workers · trace opens the DevTool". That stays accurate for the happy path. The spec now says TEAMS isn't what discriminates the control, so no change is needed.


Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem this fixes

The verify table said GOAL_CONTROL=no-page-config must fail TEAMS, but TEAMS is driven by API reads on the page, not by injected page meta. That made the control easy to mis-implement and to “game” when S13 lands.

Verdict

Approve. This is the right-sized fix: one line, no new machinery, and it matches how controls are documented elsewhere (name the assertions that go red; partial leg-a failure is normal).

The amendment is slightly broader than a pure rename (it also names b under no-page-config, not only Open trace). That is coherent with PLAN S5’s boot-id-in-meta reload path for goal check b — without page meta, watch can still restart the Lab while the browser assertion for “the change shows” should fail. Worth one explicit tie to S5/BR-16 in follow-up prose so implementers do not treat b as no-watch-only.

/simplify — what I would not do

  • Split verification into sub-legs a1/a2 in this PR — correct idea for readability, but scope creep for an amend.
  • Add goal scaffolding here — S13 owns goal.md / run.mts; SPEC should stay the short table.

Optional polish (non-blocking)

See inline. None change the direction.

Parallel review notes

  • Code quality: no runtime code; table cell is dense but acceptable for a spec amend.
  • Performance: n/a.
  • Reuse: mirror the TEAMS-stays-green + assertion naming detail in goals/shift-manager/it-runs-from-an-install/goal.md when S13 ships (same pattern as it-opens-a-lab, kitchen-sink-talk controls).
Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Comment thread specs/issues/FIX-1770/SPEC.md Resolved
Comment thread specs/issues/FIX-1770/SPEC.md Resolved
Comment thread specs/issues/FIX-1770/SPEC.md Resolved
Comment thread specs/issues/FIX-1770/SPEC.md Resolved
@jhoffner
jhoffner merged commit 7d25fab into main Oct 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants