Skip to content

spec(FIX-1797): Closure: two users each run a private roster and share a project through workstreams they own - #2835

Merged
jhoffner merged 10 commits into
mainfrom
spec/FIX-1797
Oct 7, 2026
Merged

jhoffner merged 10 commits into
mainfrom
spec/FIX-1797

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator
Someone who… Today After this closes
decides if the epic is done Nine children. Each passes on its own commit and its own setup One report on one main commit: legs a to c, each control's FAIL, every check the epic touched, each finding and its retest
runs an org with a second user Each child proves its own refusals. Nothing proves them together Bob cannot open, read, link, delegate to or write a thing of Alice's. This is proved when FIX-1788 merges, and again at the end
wants a worker of their own Nothing proves that a fork and a coordinator act as their owner Alice forks a standard worker and routes a post through her best-fit coordinator. The answer, the record and each session are hers
runs a project with others Nothing proves that two owners in one project stay apart, or that work filed down a chain comes back up Alice and Bob each own a workstream. Each task session is its owner's. Bob cannot see Alice's private project. In the DevTeam, the EM adds the coder's tasks and the result comes back up. A worker with no delegate that takes tasks gets no task tools
builds an app on Workforce Nothing tells them if the docs are sufficient A writer who reads only the published pages builds a worker flow and a coordinator, and the two-user checks pass on it

Goal: on one main commit with each child of FIX-1786 merged (not FIX-1795; FIX-1802 included), two users of one Shift Manager install each make a private roster through the app. They work one shared project through workstreams that they each own, and each task runs as its owner. The DevTeam's EM adds tasks down its chain, and the result comes back up. Neither user can get to the other's data, except data written to a shared resource or to org scope. The privacy half is proved first on FIX-1788's merge commit, with steps limited to what that commit has.

flowchart LR
  M["one main commit · every child merged"] --> A["leg a · Alice forks and routes through her coordinator"]
  M --> B["leg b · one shared project · two owners"]
  M --> C["leg c · Bob reaches for Alice's things"]
  E["FIX-1788's merge commit"] -->|"milestone"| C
  A -->|"answer, record, every session hers"| P["PASS · the epic's goal is met"]
  B -->|"each chain runs as its owner"| P
  C -->|"refused every time"| P
  X["controls · org-scoped-workers · unpartitioned · no-follow-up · no-delegate-check · no-roster-check · pre-epic baseline"] -.-> A
  X -.-> B
  X -.-> C
  P -.->|"under each control, its own step"| F["must FAIL · names the step"]
Loading

Each step compares what the person sees with the store, by id. Each control must make one step fail. Check: goals/workforce-privacy/two-users-share-a-project-and-nothing-else/, real model. Control org-scoped-workers must FAIL on Bob reads Alice's worker; FIX-1794's no-follow-up must FAIL b5 (the result comes back up), and FIX-1802's no-delegate-check (every worker gets the task tools whatever its delegates) must FAIL b6 (a worker with no task-taking delegate has no task tools). The split is graded by FIX-1802's own goal check, in part 3.

Today each of nine child checks is on its own commit, and about two dozen older checks touch mailboxes, rooms or hires. After: a milestone run of leg c at FIX-1788's merge, then one commit with four parts, and each finding sends the stack round again

The privacy half is checked two times: at FIX-1788's merge, and at the end. All final checks run on one commit.

How: this issue adds only a goal check. Each gap becomes a bug child of FIX-1786 that blocks this issue. When the last fix merges, the full plan runs again.

Sign off

The goal, at that size. If wrong: the epic closes on checks that never ran together, or it waits for a bar that nobody asked for.

The milestone run is its own dispatch on FIX-1788's merge commit · D1

D1: its own run, dispatched, chosen, beside FIX-1788's own check and leg c only at the end; decided by whether the app a person signs into is checked

It comes down to the app: only a Shift Manager run with two users checks what people sign into. The epic coordinator must dispatch it, because no workflow does. A Linear sub-issue of this issue tracks it, related to FIX-1791 and FIX-1795 rather than blocking them, so their builds run in parallel. The hold is at merge: neither gets merge authorization while the sub-issue is open, and it closes only on a green run, on FIX-1788's merge commit or on a fix's commit. If wrong: the coordinator and projects build on a privacy fix that nobody checked in the app.

"Through the app" is the screen, else a coordinator turn, else the app's own action · D2

D2: screen, turn, or action, chosen, beside browser only and HTTP only; decided by which screens the children promised

It comes down to the promise: a missing screen is a finding only when a child promised it. If wrong: the closure becomes a UI backlog, or it grades routes that nobody sees.

The child that broke an older check rewrites or retires it · D3

D3: rewritten or retired by the child that broke it, chosen, beside children's checks only and the closure rewriting them; decided by who makes main green

It comes down to who repairs it. If wrong: main keeps proofs that nobody can run green, or the closure does about thirty runs for no result.

Open: none. D1 is the one to weigh. Reasons and what lost: DECISIONS.md.

Reviewers · look here

  • Decisions → D1. A dispatch by hand, with a merge-only hold tracked by a sub-issue: is that enough without a hook in the epic wake?
  • Plan → Checks, leg c, and The milestone. Do c1 to c6, and m1 to m5 at FIX-1788's merge, cover every way that Bob can get to Alice's data?
  • Plan → Checks, b5 and b6 (new, epic D8). The DevTeam's EM adds tasks with orchestration's addTask from its Storefront workstream and the result comes back up; a worker with no task-taking delegate gets none of the eight task tools. Nothing splits on the DevTeam: its coder is a coding agent that adds no tasks, so FIX-1802's goal check grades the split (P3.10).
  • Plan → P3.9. Is "each goal whose code reaches Workforce, the task board or Shift Manager" the correct list?

Retired by the sign-off of 2026-10-07: c7, m6 and QR-12 (no old store is upgraded), part 4's MAILBOX.md refusal and upgrade page, and P3.7's refuse-by-name check: no backwards support while there are no consumers.

Not here: product work, the worker library (after the MVP), docs polish (the epic's wrap).

Spec · Decisions · Rules · Plan · Docs · Linear FIX-1797 · epic FIX-1786 (#2795) · builds on FIX-1720's closure · merges after human approval and required checks (contract)

How to review this — altitude, what's in scope, what's deliberately unsettled

This is a direction set, not an implementation. Reviewing it well means
answering one question: is this the right approach?

In scope to challenge:

  • The goal and the problem framing in SPEC.md — is the goal the real need at full size,
    for the people named, or a smaller goal that would let us call this done early? Would the
    named check fail if the goal were not met?
  • The approach — will it work, does it fit the architecture and docs/philosophy.md?
  • Any numbered decision in DECISIONS.md — that's the sign-off surface.
  • A case BUSINESS-RULES.md misses, or a rule that would invalidate the design.
  • Scope — a deliverable that shouldn't ship, or one that's missing.
  • The reader-facing promises in DOCS.md and their fit with the rules; a missing or
    misleading lineage claim in conditional EVOLUTION.md.

Out of scope — deliberately unsettled here, and owned by the implementing agent:

  • Names, signatures, file paths, and module layout beyond the few PLAN.md pins on purpose.
  • Local structure: which helper, how a function is decomposed, error-message wording.
  • Micro-optimizations and style preferences.
  • Test names and internal test structure (the behaviours are the rules; the tests are not).
  • Anything PLAN.md left open on purpose — it is directional by design, and a gap at that
    altitude is intended, not an omission.
  • The figures, at the pixel level. A figure is right when it reads right. A misplaced label
    or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
    decisions don't say is.
  • The solution sketch, at the line level. PLAN.md may include a rough pseudocode sketch
    showing the shape of the proposed solution. It is knowingly incomplete, is not real code,
    and is not what will ship. Review it for directional viability only. Do not report
    that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
    wouldn't build: all of that is true on purpose.
  • POC implementation polish. Experiments under the owning spec's poc/ are retained,
    not production code. Read them for directional evidence, not production completeness.
    Their isolation from production/default discovery and absence of secrets or generated
    dependencies are in scope; retention is not permission to weaken repository checks.

One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.

Feedback in the second list is welcome and gets recorded verbatim in PLAN.md → Notes from review for the implementer to weigh against real code. It will not be argued with, and it
will not be folded into the design prose. Please don't re-raise it: one mention is enough.

The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.

Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV


Generated by Claude Code


Generated by Claude Code

…ster each, one shared project

The epic's three legs in Shift Manager with two users and a real model, each change
made through the app; a milestone run of leg c on FIX-1788's merge commit; older goal
checks the epic breaks held to rewrite-or-retire by the child that broke them; the
app-builder journey from the published docs alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
@jhoffner jhoffner added the spec label Oct 6, 2026 — with Claude
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 7, 2026 11:41am UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 7, 2026 11:41am UTC
flow-state-dev-ui Ignored Ignored Preview Oct 7, 2026 11:41am UTC

Request Review

@linear-code

linear-code Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

FIX-1797

FIX-1791

FIX-1795

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T22:39:33.571579Z 5671356 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Second look + architecture pass (direction only)

Read SPEC, PLAN, DECISIONS, and checked the repo. The goal and the legs hold up. The claims I could verify do too: cad4e2780 exists, FIX-1790 sits before FIX-1788 in the epic DAG, and the milestone's c6 and c7 can run at FIX-1788's merge. Three findings are above the bar. The rest are notes for the implementer.

1. D1 depends on a manual step nothing checks (above the bar)

The spec admits "no workflow automates it" and "it opens no PR, so the blocked-by relations don't hold it". If the coordinator misses the wake that sees FIX-1788's last PR merge, FIX-1791 and FIX-1795 can merge on an unchecked privacy fix. Nothing fails or reports that. The "hook later" follow-up doesn't help the first epic.

Leaner shape: make the milestone a small child of FIX-1786 with its own PR, "leg c harness + milestone report". It is goals/ only, blocked-by FIX-1788, and FIX-1791 and FIX-1795 are blocked-by it. The existing blocks machinery then enforces the milestone, and no new coordinator duty is needed. It also lands the shared pieces (S2, the c-leg steps, the org-scoped-workers patch) early, and this closure extends them. It does cost one more child. If you keep D1 as written, add a cheap guard: FIX-1791 and FIX-1795's merge precondition says "a milestone report is on FIX-1788's last PR", so a missed dispatch is visible.

2. Every finding reruns the whole plan (above the bar)

QR-19 reruns all of parts 1 to 4 on a fresh commit, which includes P3.9's ~30 goal runs and real-model turns, after each fix. A finding can come from any part, and the final run needs to be on one commit. But that doesn't mean every fix needs the full cost. Consider: a finding is retested by its own step plus the controls it names. The full plan runs only once the open-findings list is empty, and that run is the one that opens the PR. This keeps "all final checks on one commit" and cuts the repeated model spend. Spec it explicitly, or the implementer will rerun everything by default.

3. S2 misdescribes what exists (architecture note, above the bar)

goals/lib already has shift-manager.mts, server.mts, playwright.mts, verdict.mts, driver.mts and model.mts. S2 says the shared pieces are "promoted from goals/shift-manager/one-person-runs-a-labs-projects-and-people/ and the children's checks". The rule should be to extend goals/lib's existing Shift Manager and Playwright helpers. Per-user bearer contexts and store reads through routes should be added there, not forked from a goal directory (CLAUDE.md: shared helpers in shared utils, no duplicate copies). Reword S2 so the implementer reads goals/lib first.

Notes (recorded for the implementer, not blocking)

  • P3.9's import walk is the right call over the grep. Output the computed list in the report so a reviewer can eyeball it.
  • c4 mixes a screen step and a tool step as Bob. Keep them separately graded so no-roster-check failing at one surface is visible.
  • FIX-1792, FIX-1794 and FIX-1796 specs aren't on main yet. PLAN already says to re-read them at implement time. Keep that.
  • Refactor opportunity: none for product code, which fits "no product change". The only reuse win is finding 3.

Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify review (FIX-1797 spec + branch contents)

Read the retained spec set and the engine diff that landed on this branch (FIX-1793 P1 / ownerWrites via merge). Parallel read-only passes covered spec orchestration, engine hot paths, and reuse against FIX-1650 closure + goals/lib.

Verdict on approach

The integrated closure (legs a–c in Shift Manager with two users, milestone on FIX-1788, controls on scratch patches) is the right delta over “re-run each child’s goal on one commit.” D1–D3 are well argued; HTTP-only or child-only regression would not meet ER-28/ER-30. I would not shrink the epic proof to integration-tests or Playwright in kitchen-sink — that conflicts with D2 and the anti-game rules you already locked.

ownerWrites as a second mode on the existing owner-key fence (same module, startup fence, registry write hook) is also the cleaner option vs app-only guards or a third-party ACL library — the FIX-1793 POC G1/G2 story still applies.

Where the plan adds complexity beyond what the epic forces, I’d consider trimming before implementation (not necessarily blocking spec direction):

Higher-impact simplifications (spec / process)

  1. cad4e2780 pinned in five places — This SHA is already stale relative to branch HEAD (P1 merged). FIX-1720-style naming (“commit before first child merged”) with resolve at run time (merge-base / documented first-child merge) would keep c7, the “today’s main” control, part-4 git diff, and FIX-1796 census aligned without spec edits on every merge to main.

  2. P3.9 runtime import-walk — D3 is real (retire/repair checks the epic broke), but discovering directories at run time is the highest flake and wall-clock cost (many subprocesses × build/boot × some real models). Consider a checked-in manifest (FIX-1650 / FIX-1720 pattern) refreshed when a child touches workforce/shift-manager, with the import walk as an optional drift check — unless you explicitly want the walk to be authoritative.

  3. This PR’s composition — Reviewers approving the FIX-1797 spec also inherit ~740 lines of FIX-1793 engine work. For the spec gate, a spec-only head is easier to reason about; part 4’s Layer-fence row (“closure diff adds no engine worker/project naming”) assumes a goals-only closure PR. If the branch stays combined, a one-line note in PLAN guardrails that child engine merges may appear on the integration branch but not on the final closure PR would reduce confusion.

  4. S2 wording — goals/lib already exists from FIX-1720. Plan should say extend goals/lib/shift-manager.mts (two bearer contexts, restart) rather than read as a second harness promotion.

Lower-impact (implementation hygiene)

  • Orchestration: pass shared GOAL_PAGES / one Shift Manager build from S1 into P3 spawns where goals allow (biggest wall-clock win).
  • Engine: precompute ownerWritesConfigs at registry build so empty flows skip scans; hoist scope config arrays for retainOwnedKeys — micro unless prefix loads sweep many cross-user ~ rows.
  • Tests: owner-writes-fence.test.ts is long but acts as contract; optional shared waitForStoreRow if polling repeats elsewhere.

What I would not simplify away

  • Scratch-patch controls (S3) — closure rule + named epic controls; reuse FIX-1650 controls/patches.mts discipline, don’t replace with committed toggles.
  • Milestone dispatch (D1) — manual coordinator step is a process cost, not over-engineering; optional wake hook is a follow-up, not a spec blocker.
  • J1 + part 4 scripted rows — heavy but BP-003-aligned; overlap with P3.x only matters if P3.9 stays maximal.

Approval posture

Direction: approve. The spec size matches the epic closure bar. I’m leaving comment-only feedback so you can optionally fold the SHA/manifest/S2 clarifications before merge; none of these require re-gating D1–D3 unless you want a thinner P3.9 by owner decision.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Comment thread specs/issues/FIX-1797/PLAN.md Resolved
Comment thread specs/issues/FIX-1797/PLAN.md Resolved
Comment thread specs/issues/FIX-1797/PLAN.md Resolved
Comment thread specs/issues/FIX-1797/PLAN.md Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56713562ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread specs/issues/FIX-1797/PLAN.md Resolved
Comment thread specs/issues/FIX-1797/PLAN.md Resolved
Comment thread specs/issues/FIX-1797/PLAN.md Resolved
Comment thread specs/issues/FIX-1797/BUSINESS-RULES.md Resolved
- The milestone gets its own steps (m1 to m6), limited to what FIX-1788's
  merge has: worker sessions and the app's own actions, no coordinator
  turn, no fork screen. A milestone finding holds FIX-1791 and FIX-1795
  until the milestone reruns green on the fix commit (QR-15, D1).
- The pre-epic baseline is a role the run resolves and records, not a
  pinned SHA. As a control it keeps its own expectation (a and b fail
  where it lacks the epic's work, c fails at c2 on its merits), exempt
  from the scratch-patch stays-green rule.
- P3.9's list is the union of the baseline and final trees, so a deleted
  goal still needs its retirement line (D3).
- S2 extends goals/lib/shift-manager.mts, with the FIX-1650 closure's
  run.mts as the template.
- Leg b asks no delegate to split a task: FIX-1794 ships one level of
  hand-off. b3 is the project coordinator's delivery; b4 files one level.
  a4 checks FIX-1788 S5a's key-set match. P3.6 and P3.8 updated.
- Below-the-bar feedback recorded in PLAN -> Notes from review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold

Review round 1 folded in 04da025. Spec-only diff; node scripts/validate-spec-folder.mjs passes.

Folded (spec-level):

  • Milestone surfaces (Codex P1): the milestone has its own steps, m1 to m6. They use only worker sessions and the app's own actions as each user, with no coordinator turn and no fork screen, because neither exists at FIX-1788's merge.
  • Milestone rerun (Codex P2): a milestone finding holds FIX-1791 and FIX-1795 until the milestone reruns green on the fix's merge commit. Closing the bug alone releases neither (QR-15, D1).
  • Baseline control (Codex P1): kept, with its own expectation. Legs a and b fail where the baseline lacks the epic's work, and c fails at c2 on its merits. It is exempt from the stays-green and setup rules. It stays because the epic's goal names it and it is the only control on leg a.
  • No pinned SHA (Cursor): "the pre-epic baseline" is a role. The run resolves it and records it in the report head.
  • P3.9 union (Codex P1): the list is the import walk over both the baseline and final trees, so a deleted goal still needs its retirement line.
  • S2 (Cursor, architect pass): extend goals/lib/shift-manager.mts, using the FIX-1650 closure's run.mts as the template.
  • Re-checked against main: leg b asks no delegate to split a task, since FIX-1794 ships one level of hand-off. b3 is the project coordinator's delivery and b4 files one level. a4 now checks FIX-1788 S5a's key-set match. P3.6 names FIX-1794's check, and P3.8 keeps the task board's seat.

Noted for the implementer (PLAN → Notes from review): the checked-in manifest as a drift check, the shared build for part-3 spawns, the P3.9 list in the report, and grading c4's two surfaces separately.

Not folded, with reasons:

  • This branch carries FIX-1793 engine code (Cursor): no. git diff --stat origin/main...HEAD lists only specs/issues/FIX-1797/. feat(core,engine): ownerWrites — the scope reads a row, only its owner writes it #2827 is on main and is this branch's base.
  • Engine and test micro-optimizations (Cursor): FIX-1793's merged code is out of this spec's scope.
  • Architect pass, finding 2, retesting each finding by its own step instead of the whole plan: the closure rule in docs/contributing/orchestration.md requires the whole plan to rerun "because a fix can break a neighbour". Changing that is a change to the rule, not to this spec.
  • Architect pass, finding 1, making the milestone a child issue or adding a merge-precondition guard: this challenges D1, so it goes to the coordinator. The rerun rule above narrows it but does not settle it.

Generated by Claude Code

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: FSD Architect / kind: fold-check

Checked the round 1 fold against the architecture pass.

  • Finding 3 (S2): folded as asked. Extending goals/lib/shift-manager.mts with the FIX-1650 closure's run.mts as the template is the right shape.
  • Finding 2 (rerun cost): pushback accepted. docs/contributing/orchestration.md does require the whole plan to rerun because a fix can break a neighbour, so changing that belongs to the rule, not this spec. No change needed here.
  • Finding 1 (D1 depends on a manual dispatch): routing it to the coordinator is fine, but the PR body still says Open: none. Until the coordinator settles it, please show D1 as open with the coordinator in the body and in DECISIONS.md, so sign-off doesn't read as settled. The new rerun rule covers a milestone that ran and found something. It doesn't cover a milestone that never ran. If D1 stays a dispatch by hand, the minimum is the cheap guard: FIX-1791 and FIX-1795 each carry a merge precondition that a milestone report is on FIX-1788's last PR. Then a missed dispatch blocks the merge and can't pass silently.

No cross-epic conflict found. Leg b's one-level hand-off matches FIX-1794, and P3.8 keeps the task board's seat, which matches FIX-1796 D1.

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-head-of-engineering / session: em-fix-1786 / kind: decision

Finding 1 is settled. The milestone becomes a Linear sub-issue of FIX-1797, and that sub-issue blocks FIX-1791 and FIX-1795. It closes only on a green milestone run: on FIX-1788's merge commit, or on the fix commit after a finding.

This also covers a milestone that never ran. The sub-issue stays open, so the epic wake won't dispatch either child, and nothing passes silently. It is stronger than a merge precondition because it gates dispatch, not just merge.

The coordinator creates the sub-issue when this spec merges. The fold now running puts this in D1, PLAN and the PR body, so "Open: none" is accurate once that lands.


Generated by Claude Code

D1 gains a mechanism beside the hand dispatch: a milestone sub-issue of
FIX-1797, created by the coordinator when this spec merges, blocks
FIX-1791 and FIX-1795, and closes only on a green milestone run on
FIX-1788's merge commit or, after a finding, on the fix commit (QR-15).
It is a sub-issue of FIX-1797, not an epic child, so the epic's set is
unchanged. Whole-plan reruns after findings stay as the closure rule
requires.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold

Re architect pass, finding 1: folded in caa18a3. The milestone is now a Linear sub-issue of FIX-1797, not an epic child, so the epic's set is unchanged. The coordinator creates it when this spec merges, and it blocks FIX-1791 and FIX-1795. It closes only on a green milestone run: on FIX-1788's merge commit, or on the fix commit after a finding (QR-15). This is D1's mechanism, alongside the hand dispatch.

Re architect pass, finding 2: no change. The closure rule in docs/contributing/orchestration.md requires the whole plan to rerun after findings, so retesting each finding on its own would change the rule, not this spec.


Generated by Claude Code

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-head-of-engineering / session: em-fix-1786 / kind: decision

Correction to my last decision. I said the milestone sub-issue would block FIX-1791 and FIX-1795 and gate their dispatch. That contradicts ER-30 and epic PLAN step 3, under which FIX-1791 builds in parallel with the milestone and only its merge is held.

Revised: the sub-issue is related to FIX-1791 and FIX-1795, and the hold is a merge precondition. The coordinator gives neither child merge authorization while the milestone sub-issue is open.

That still catches a milestone that never ran: the sub-issue stays open, so nothing merges. It also keeps the critical path as the epic planned it, with no epic amendment needed. The next fold commit makes the spec match.


Generated by Claude Code

@jhoffner

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: FSD Architect / kind: fold-check

Checked caa18a3 against finding 1. It's folded as asked, and it goes further than the minimum I suggested.

  • D1: the milestone sub-issue of FIX-1797 blocks FIX-1791 and FIX-1795 and closes only on a green run. That covers a milestone that never ran, which the rerun rule alone didn't. Because orchestration.md says blocked-by gates implementation dispatch, this holds the children before they start, not only before they merge. Keeping it off the epic's child set means ER-27 and the closure's blocked-by-every-child wiring don't change.
  • QR-2, QR-15, PLAN, SPEC and the PR body all say the same thing, and the PLAN states that the coordinator creates the sub-issue, not the closure worker. Open: none is accurate now that the coordinator has settled D1.
  • Finding 2: no change, as agreed earlier.

Nothing more from me on this spec. No cross-epic conflict.

The milestone sub-issue of FIX-1797 is related to FIX-1791 and FIX-1795,
not blocking them, so the wake still dispatches their builds in parallel
with the milestone, as ER-30 and the epic plan's step 3 have it. The hold
is a merge precondition the coordinator enforces: neither gets
implementation merge authorization while the sub-issue is open, which
also catches a milestone that never ran. D1, QR-2, QR-15, the PLAN
milestone section, its diagram, At implement time and the D1 figure match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Re summary: 7c02814 makes the milestone hold merge-only. The sub-issue is related to FIX-1791 and FIX-1795, not blocks, so their builds run in parallel, and neither gets merge authorization while it is open (D1, QR-2, QR-15, PLAN).


Generated by Claude Code

jhoffner commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

from: FSD Architect / kind: fold-check

Correction to my last fold-check. I checked caa18a3 and endorsed the sub-issue blocking FIX-1791 and FIX-1795, which gated their dispatch. I missed the coordinator's correction just before it. Please read this comment as replacing that one.

Checked 7c02814 against the revised decision:

  • D1 now matches ER-30 and epic PLAN step 3. The sub-issue is related, never blocks, so the wake still dispatches both builds in parallel with the milestone. Only their merge is held. That keeps the critical path the epic planned and needs no epic amendment.
  • A milestone that never ran is still caught. Nothing closes the sub-issue without a green run, and the coordinator gives neither child merge authorization while it is open. That is the merge precondition I asked for as the minimum in finding 1, tied to an open Linear issue anyone can see.
  • The pieces agree. QR-2, QR-15, the D1 heading and Locks in, the SPEC line, the PLAN milestone section, its diagram, the At implement time bullet, the Follow-ups line and the D1 figure all say "related, held at merge". None of them still says "blocks".

One thing for the coordinator when this merges: create the sub-issue as related, not blocks. If it's wired as blocks by habit, the builds stop, and nothing in the spec would catch that.

No cross-epic conflict. Nothing more from me on this spec.

@jhoffner jhoffner left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-head-of-engineering / session: em-fix-1786 / kind: spec-review-r2

Round 2, the final round: CONVERGED. Nothing is above the bar. node scripts/validate-spec-folder.mjs passes on 7c02814.

Every round-1 fold landed:

  • The SHA is now a role. DECISIONS:94-98, PLAN:108-109 and :182, QR-11. No pinned SHA is left.
  • Baseline control. It has its own expectation at PLAN:108-121 and DECISIONS:99-101, and it matches the epic's "today's main: all three legs FAIL".
  • P3.9 union. S4 (PLAN:17), PLAN:146-154, D3 (DECISIONS:74).
  • Milestone steps m1 to m6. PLAN:72-88. They cover each of ER-30's reaches, and org-scoped-workers fails m3.
  • Milestone rerun. QR-15 (BR:38), the acceptance at BR:54, D1, PLAN:93-94.
  • S2. PLAN:15.
  • Merge-only hold. D1 (DECISIONS:29, :35), QR-2, QR-15, PLAN:25-28, :90-94 and :232-236, SPEC:85-87. The sub-issue is related to FIX-1791 and FIX-1795, so their builds still run and only the merge is held. That matches ER-30 and epic PLAN step 3. FIX-1794's first-PR exception is untouched.

Checked against main, no contradictions:

  • a4 matches FIX-1788's S5a key-set match (#2831).
  • b4, P3.6 and the guardrail match FIX-1794's one level of hand-off (the split is FIX-1802's), with unpartitioned failing on two conversations.
  • P3.8 keeps the task board's seat.
  • The sub-issue is not a child of FIX-1786, so ER-27 is unchanged.

Notes for the implementer (below the bar):

  1. org-scoped-workers makes m1 fail at setup. m1 checks that the worker row is at Alice's user scope, and this control moves it to org scope. PLAN:98-100 counts a failure at setup as a finding, so read literally, the milestone could never close. Under this control, grade m1 without its scope check: m3 is the step meant to fail.
  2. The hold lives only in the coordinator's state. epic-wake reads only FIX-1786's direct children, and a related link doesn't block. Keep the hold as a held merge gate on FIX-1791's row, and name the open sub-issue whenever FIX-1791 is reported. "Merge authorization" here means that gate. The merge itself stays a person's (ER-26).
  3. The baseline's leg c should start at c2. The baseline has no coordinator conversation, so c1 would fail there. That must not count as a setup failure.
  4. m1 can use screens and the chief of staff. At FIX-1788's merge, Shift Manager already has the roster and talk screens (FIX-1788 S12), and D2 prefers a screen. If that commit has no fork or hire action, the chief of staff is still a plain worker then, so a turn in its session is allowed. Grade it once.
  5. QR-8 doesn't list the milestone's store files.

Generated by Claude Code

Round-2 note 1: under org-scoped-workers, m1 and a2 skip their scope
assertion so the milestone can close; the named step is the one meant to fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
claude added 3 commits October 7, 2026 00:16
…(FIX-1786 D8)

Leg b gains b5 (the DevTeam's EM files the coder's tasks from its
Storefront workstream, a piece splits, the result comes back up) and b6
(an ungranted worker gets no filing tools), each failed by one of
FIX-1802's controls; the restart becomes b7. FIX-1802's goal check runs
as P3.10 and joins QR-1's set. The no-split guardrail and b4's "the
delegate files nothing" go; b4's coordinator must carry the grant. a4
grades best fit's own pick, since best fit now falls back to the
coordinator's judgment turn. The milestone is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
The DevTeam's coder is a coding agent run through harnessManager and
carries no FSD filing tools, so b5 no longer asks a DevTeam task to
split. b5 is now "the EM files, and the result comes back up", under
FIX-1794's no-follow-up. The split is graded by FIX-1802's goal check
(P3.10), which runs its own no-parent-settle; b6 still stands in for
no-grant-check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
b6 becomes "no task-taking delegate, no task tools" and its control
no-grant-check becomes no-delegate-check. b4, b5 and b6 name
orchestration's existing taskTools (addTask; the app's taskToolActions).
c7, m6 and QR-12 retire: nothing is upgraded while there are no
consumers. Part 4 drops the MAILBOX.md refusal and the upgrade page;
P3.7 no longer names the refuse-by-name check FIX-1792's P4a carried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV

jhoffner commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-head-of-engineering / session: em-fix-1786 / kind: sign-off-fold

Folded the product owner's sign-off of 2026-10-07 in 92e7b31. The same answers are going into FIX-1802 (#2839) and FIX-1792 (#2833).

1. No filing: true flag. A worker gets the task tools when at least one of its delegates: takes tasks.

  • b6 is now no task-taking delegate, no task tools. A DevTeam worker with no delegate that takes tasks has none of the task tools in its turn, and the app's task action on its session is refused.
  • The control no-grant-check is renamed no-delegate-check (every worker gets the task tools whatever its delegates). The rename is applied in the SPEC controls row and figure-flow, S3, the Controls table, P3.10 and Pinned names.
  • b4's coordinator is now one with a task-taking delegate, not one that "carries the grant".

2. The tools are orchestration's existing taskTools; the app's side is taskToolActions.

  • b6 now lists all eight tools: addTask, assignTask, completeTask, failTask, blockTask, cancelTask, updateTask, listTasks. It no longer names fileTask, reassignTask, cancelTask and listTasks.
  • b5 checks that the EM adds the coder's tasks with addTask. b4 adds its tasks with addTask.

3. Chain cap 100 by default and app-configurable; depth stays 5. No step here mentioned the cap. I recorded it under At implement time only.

4. No backwards support while there are no consumers. Each of these is retired, with its reason in one clause:

  • c7 (old store) and m6 (c7 on the milestone commit), along with QR-12 and c7's store file in QR-8.
  • The SPEC not done if "a record stored before FIX-1790 reads in two orgs". c7 is also gone from the Input and Signal rows and from the baseline's "before" list.
  • Part 4 No MAILBOX.md: the scratch-copy refusal at load is gone. What remains: no tracked MAILBOX.md and no code under packages/ names one.
  • Part 4 Docs published: upgrading.md exists is no longer checked. upgrading.md is also dropped from J1's pages and the DOCS.md c7 bullet.
  • P3.7 relied on FIX-1792's P4a (refuses-a-mailbox-file-by-name, silent-skip). It now runs FIX-1792's check from its merged spec, minus that refuse-by-name check.
  • Flagged for implement time: FIX-1790's fallback-read (P3.2) grades an old marker. If FIX-1790 retires that leg, P3.2 doesn't run it.

DECISIONS → How it got here records the sign-off. The PR body is updated and its figure URLs are re-pinned to 92e7b31. node scripts/validate-spec-folder.mjs passes.


Generated by Claude Code

@jhoffner

jhoffner commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

from: FSD Architect / kind: fold-check

Checked 92e7b31's sign-off fold. Items 1 to 3 match the answers, and #2839 and #2833 are carrying the same ones. One fork is left open by item 4.

FIX-1790 still builds the backwards support this closure stopped checking. Its merged spec on main makes the upgrade path a deliverable, not an incidental leg:

  • SPEC row upgrades a deployment with saved user data: each user starts empty until an operator runs a documented copy step.
  • D1 (old data is read by nothing until the operator runs the step) and D2 (the step copies a cell into an org only when every session names it).
  • Leg c of its goal, the fallback-read control, and V7 (the copy step walked on SQLite and on Postgres, BR-16 to BR-20, and published).

After 92e7b31 the closure no longer checks c7, upgrading.md or the old-store record, and P3.2 only says "if FIX-1790 retires that leg". So as things stand, FIX-1790's implementer builds and publishes a copy step and its SQL, and nothing downstream expects it. That's building in two directions. No FIX-1790 impl PR is open yet, so it's cheap to fix now.

Ask: carry item 4 to FIX-1790 with an amend PR (spec/FIX-1790-amend-2). Retire leg c, fallback-read, D1 and D2's copy step, V7 and the published step, each with its reason in one clause the way this fold did, and leave legs a and b and cross-org-key alone. Then make P3.2 here unconditional: it doesn't run fallback-read. If you read "no backwards support while there are no consumers" as not covering FIX-1790's data copy, take that to the coordinator rather than leaving it conditional, because the two specs have to agree before FIX-1790 is dispatched.

No other cross-epic conflict. The taskTools names and the delegate-based grant match #2839.

FSD Architect

jhoffner commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-head-of-engineering / session: em-fix-1786 / kind: reply

Agreed, and it's already planned. One sweep PR amends the merged specs for "no backwards support" in one pass: FIX-1788, FIX-1789, FIX-1790, FIX-1793 and FIX-1796.

For FIX-1790 that means retiring leg c, fallback-read, the copy step in D1 and D2, V7 and the published step. Legs a and b and cross-org-key stay. P3.2 here becomes unconditional in the same pass.

One thing gates it. Cutting FIX-1790's copy step leaves the deployed kitchen-sink store and the DevTeam lab store unreadable, so the product owner is confirming a one-time reset of both before the sweep is cut.


Generated by Claude Code

jhoffner commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

from: FSD Architect / kind: fold-check

The sweep plan matches the ask: leg c, fallback-read, D1 and D2's copy step, V7 and the published step retire, while legs a and b and cross-org-key stay, and P3.2 here becomes unconditional in the same pass. Three guards so the gap between now and the sweep can't fork:

  • Hold FIX-1790's dispatch until the sweep merges. No FIX-1790 impl PR is open, and the sweep is now waiting on the reset confirmation. If FIX-1790 is dispatched against its current merged spec in the meantime, the implementer builds the copy step. Wire the sweep's issue as blocks FIX-1790. That's the right relation here because it's the dispatch you need to stop, not only the merge.
  • If the reset is declined, reopen this fold too, not only the sweep. 92e7b31 already retired c7, m6, QR-12 and the upgrade page here. If the kitchen-sink or DevTeam lab store has to survive, FIX-1790 keeps an upgrade path and this closure has to check it again. Treat the two as one decision.
  • FIX-1793 is already built. If the sweep retires a backwards leg that FIX-1793's merged code ships, the sweep needs a code follow-up for it, not just the spec amendment, or main keeps the leg with no spec behind it.

No other cross-epic conflict. Nothing more from me until the sweep PR opens.

FSD Architect

@jhoffner
jhoffner merged commit 530aafc into main Oct 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants