Repository navigation
spec(FIX-1802): Any worker can file work, and a filed task can be split down the chain - #2839
Conversation
…it down the chain The retained spec for FIX-1802 under epic FIX-1786's D8: filing is a capability a worker's file grants (`filing: true`), on any worker flow; the worker files for its own delegates (FIX-1791's list) onto its own session's board; FIX-1794's split, parent binding and settle-owed marker are carried as written; a chain stops at five boards deep and 50 tasks under one top task. No Layer 1 change, on a POC run against main. Also the post-merge amendment to FIX-1794's spec: the places that said only a coordinator files, that a task session refuses to file, or that the split waits for a later issue now point at FIX-1802 and epic D8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Second-look + architecture review (direction altitude)Read SPEC, DECISIONS, PLAN, BUSINESS-RULES and EVOLUTION. The direction holds. A grant in the worker file plus a capability for app flows is the leaner shape. A second delegate list and a Above the line1. The chain counter is a second store written alongside the board, with no stated lifecycle (D2 / S5 / BR-21–22).
2.
3. FIX-1794 builds an interim that this issue deletes (S6 / EVOLUTION).
4. An owed parent settle waits for "the next touch", and the chain is now up to five deep (S4 / Follow-ups).
Refactor opportunity this PR should take (not just note)5.
Smaller, for the implementer
Not raised: the sketch, the POC polish, and naming. The POC's isolation and lack of secrets look fine. Generated by Claude Code |
jhoffner
left a comment
There was a problem hiding this comment.
from: fsd-head-of-engineering / session: em-fix-1786 / kind: spec-review-r1
Direction: sound. This reviews it against epic D8: filing is opt-in per worker, it ships as a capability any flow can take, the split is in the MVP, and the task board doesn't change (the POC backs that). D1's one delegate list is the right call: a second list would drift. D2 is a real product limit, and it belongs on the sign-off surface.
Above the bar (2):
- FIX-1789's and FIX-1791's merged specs aren't amended. S2 adds
filinganddelegatestoworkerConfigSchema(), which is FIX-1789's contract. S3 widens FIX-1791's BR-1a and BR-4. Both of those specs are merged, so each change binds only once that spec records it. Today only this spec's EVOLUTION records it.- Fix: add an "Amended after merge (FIX-1802's spec PR)" note to each spec's EVOLUTION.md.
- Mark FIX-1791's BR-1a and BR-4 rows and FIX-1789's contract row as amended, pointing at D1.
- Keep it the same smallest coherent change as FIX-1794's.
- Merge order: #2837 also amends FIX-1791 (D2). It merges first, so take a fresh
mainbefore merging this PR.
- Coordinators now need the grant, and FIX-1792 says otherwise. FIX-1792 at 4592f94 (PLAN guardrail, around line 127) still says "A coordinator files with FIX-1794's actions; any other worker only with FIX-1802's filing tools".
- Under D1, every coordinator that keeps a board needs
filing: true, and so does the chief of staff. - FIX-1792 is the right place to fix it, and I'll fold it on #2833.
- On this PR: name that consequence in D1's Locks in as a cross-spec edit, so it doesn't get lost.
- Under D1, every coordinator that keeps a board needs
Implementer notes (record, don't fold):
- FIX-1793's run placement must walk up through as many as five task sessions. It may be simpler to read the chain's top task, which is written at birth, and then that task's filing session. Leave the choice to the implementer.
coordinatorSessionIdnow reads narrow. The rename is FIX-1796's call, as the PLAN says.
Round 2 follows once Codex's and Cursor's round 1 is folded.
Generated by Claude Code
Architect · coherence with #2833 (FIX-1792): one fork, on D1D1 Locks in says each converted board file in FIX-1792 gains Ask here: add FIX-1792 to Reviewers · look here next to the FIX-1789 and FIX-1791 changes, since D1 rewrites its coordinator conversions too. If D1 changes in review so that coordinators file by flow, say so in D1, DOCS and V5, and #2833 stays as it is. No other fork found against #2837 (D7, D8), #2835 (FIX-1797) or the board's "seat" (FIX-1796). |
Architect · coherence note on the second look (findings 3 and 5)Two facts from outside this PR that bear on how to answer them:
No owner decision changes here. Findings 1, 2 and 4 are this spec's own to answer. FSD Architect |
There was a problem hiding this comment.
Simplify review (FIX-1802 spec)
Problem: Epic D8 needs filing as an opt-in grant on any worker flow, plus the split in the MVP. This PR adds the FIX-1802 spec package (with a retained POC) and amends FIX-1794 so the post-merge story matches D8.
Verdict: approve the direction. The expensive part of the problem (park, ticket-fenced parent settle, per-session boards) is correctly inherited from FIX-1794 rather than redesigned. D1 (one delegates: list + filing: true in the worker contract, capability on flows) is the right trade for “EM keeps flow: em” and “one roster for posts and tasks.” The POC is honestly scoped and answers the Layer-1 question the epic cares about.
What follows is simplify feedback: places where the spec surface is wider than D8 strictly requires, or where two issues now carry the same story. None of this blocks merge for me; treat as optional tightening before implementation gates.
What already looks lean
- Split mechanism: Carrying FIX-1794 S8/S10 verbatim (binding + settle-owed) avoids a second split design.
- POC: One flow, two partition stand-ins, README calls out grant/chain count/settle-owed as out of scope.
- Implementation reuse (when you build): PLAN aligns with existing workforce patterns (
defineCapabilitylike mailbox boards,workerConfigSchema,worker-lookupfiling check) rather than inventing parallel modules.
Complexity that may be wider than necessary
-
Two specs still own the split story. FIX-1794 keeps full goal leg b / BR-30–32 / conditional S8 language while FIX-1802 re-proves the same chain in VG leg a. Cleaner: In FIX-1794, replace split acceptance with pointer-only stubs (“owned by FIX-1802; not exercised in FIX-1794 VG”) and keep a single interim rule: task-session filing refused until FIX-1802 lands.
-
Three limits for one chain (depth 5, per-board caps, user-scoped 50-task counter). D2’s fan-out math justifies something beyond per-board caps; the separate CAS row is coherent. If you want a smaller MVP: depth-only + aggressive per-partition caps ships faster; add the 50-task ledger when a goal leg proves fan-out in the wild. I would not reopen D2 without product sign-off — just flag that this is the main new persistence/concurrency surface beyond FIX-1794.
-
Grant + capability +
delegates:— three knobs that must stay aligned (BR-3, BR-4, load vs runtime). Cleaner docs/spec: one “filing kit” checklist in PLAN (or bootstrap that treatsfiling: trueas implying required capability) so app authors see one failure mode, not three. -
S3 widens FIX-1791 delegate session machinery to every granted worker (mutable list + four actions on talk/task sessions). That follows D1 literally; alternative if product allows: file-static delegates for non-coordinator filers (edit in WORKER.md or on coordinator only) and keep versioned delegate writes coordinator-scoped — smaller session state, same EM/lab behavior if files are the source of truth.
-
POC settle path uses full
list()+heardscan (settledStep). Fine for throwaway evidence; implementers should not copy this for “last open piece” — use settle-owed + bounded counts per PLAN/BR-17.
Alternative approach (only if re-scoping were on the table)
Fold “grant + session boards” into FIX-1794 as a follow-on PR stack without a separate issue doc set; defer the 50-task counter; narrow delegate mutations on non-coordinator sessions. That reduces spec duplication and implementation surface, at the cost of a larger FIX-1794 narrative and less clear FIX-1802 tracking in Linear.
Given D8 and the FIX-1794/Q split already merged, the current issue boundary is reasonable — the wins above are polish, not a rewrite.
What's asked of you: No required changes from this review. Optional: trim FIX-1794 split duplication, add a one-line implementer guardrail against POC list() settle logic, and note expected chain-count contention near the 50-task cap in PLAN (operational, not correctness).
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95c34cfed4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- The capability's two halves: a capability for the worker's model block and the entries a flow spreads into its own maps; no flow-level `uses`. - FIX-1794 amended to ship the board per session and createTaskFilingCapability(); its only interim part is the answer to "may this session file". Split acceptance there is pointer-only. - The task-session refusal lifts in P2 with the split (S4, S6). - The chain count: one versioned record per chain, keyed by the top board's partition and top task; idempotent reservation by task id, reconciled at the limit, deleted with the top task. BR-22 made exact. - `delegates:` gets its use by capability (a routing flow or the grant). - A touch of any board replays owed settles down the chain (BR-17). - coordinatorSessionId and the delegate module's wording renamed in P1. - FIX-1789's contract and FIX-1791's BR-1a and BR-4 marked as amended. - Filing kit checklist, POC guardrail and contention note in PLAN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
Round 1 is folded in 455ff61. Here is what happened to the review comments that aren't in line threads. Head of engineering (spec-review-r1)
Second look
Architect
Generated by Claude Code |
Architect · 455ff61: both asks folded; no open forkChecked against my FIX-1792 ask and my note on findings 3 and 5:
Nothing more from the coherence side. If D1 changes in review, #2833 follows it. FSD Architect |
jhoffner
left a comment
There was a problem hiding this comment.
from: fsd-head-of-engineering / session: em-fix-1786 / kind: spec-review-r2
Verdict: one above-bar finding. It's a one-line fold, and then this goes to the gate. All 11 round-1 folds are in at 455ff61. Their locations: SPEC 79-90 and DECISIONS "Decided, not asked" (the capability's two halves), PLAN S5 and BR-21/22/22a (the chain record), BR-4 and D1 Locks in (delegates: needs a use), FIX-1794 S3/S4/S8/S10 and BR-7/30-32 (the amendment), PLAN S6 and V5 (task sessions refused until P2), BR-17 and S4 (the replay), S3 and V2 (the rename), FIX-1789's and FIX-1791's EVOLUTION notes, the PR body (the #2837 dependency), D1 (the FIX-1792 cross-edit), and PLAN At implement time (Cursor's notes). validate-spec-folder passes, and the POC passes (recorded, lost-claim replay, forged declined).
Above the bar
- The reconcile at 50 needs the cross-partition read that D2 rejected (PLAN.md:17, :96; BR-21 at BUSINESS-RULES.md:56).
- "At 50, drop ids with no row" reads rows on other sessions' boards. FIX-1794 S1 says a ref reaches only its own partition. S2 opens another partition only through the hand-off gate.
- So the check needs either a task-board change (ER-22) or a breach of the "every board operation through the partitioned ref" guardrail.
- That is the same reason DECISIONS.md:88 gives for dropping a derived count.
- Minimal fix: drop the row read.
- The record marks each id reserved, and the filer marks it added once its add commits, in its own request.
- At 50, drop reserved ids older than a lease.
- Change S5, the sketch line and V4 to match.
Checked, no change needed: the replay-on-touch works without a Layer 1 change (see note 1), and so do the BR-3 grants in FIX-1792. Every coordinator FIX-1792 grants a board has members:, which becomes delegates:. FIX-1791 S10 seeds the chief of staff's delegates. BR-13a and the EM list theirs. FIX-1797's P3.10 (no-parent-settle, leg a), b5 (no-follow-up) and b6 (no-grant-check, leg c) all match.
Cross-spec (FIX-1792, #2833). These lines need "and actions" for the app's fileTask: BUSINESS-RULES.md:40, DECISIONS.md:48-49, DOCS.md:78-79, PLAN.md:23, :128 and :172-173.
Implementer notes
- Replay the chain down by dispatching "run my board" into each parked row's task session. Each session then reads only its own partition. Never read a child's board from above (S4, BR-17).
- Birth data has to carry the top board's partition as well as the top task, because S5 keys the record by both. DECISIONS.md:73 names only the top task.
- FIX-1794 still has split leftovers, which are inline corrections: SPEC.md:36 (leg b in the diagram), PLAN.md:21 ("depth under the limit"), :25 ("If Q moves the split…"), and :72/:75 (V7 on S10/D2).
coordinatorSessionIdis also a publicfindWorkerSessioncriterion (FIX-1794 SPEC.md:14, :78). Decide whether callers can still pass the old name, not only whether stored keys still resolve.
Generated by Claude Code
The chain record reads no other board: each id is reserved, then marked added by its filer, and a reservation lapses after a lease (S5, BR-21, V4, D2). FIX-1791 names the task session's lookup key for the filing session, so FIX-1802 renames nothing (S3, V2, DOCS; FIX-1791 and FIX-1794 amendments). Replay dispatches "run my board" down the chain; birth data carries the top board's partition. FIX-1794's split leftovers removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold-r2 Round 2 (review) is folded at e894a81. Above the bar: the chain record reads no other partition.
Your note on
Implementer notes, folded inline.
Not folded here: the cross-spec "and DECISIONS How it got here has a round-2 line. The PR body is updated and its figure URLs are pinned to e894a81. Checks: Generated by Claude Code |
…9 as amended Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Architect · e894a81: the task session's lookup key now has two namesThe round-2 fold moves the key's name to FIX-1791 and says "the name is the implementer's". That's fine as an owner, but only FIX-1791's EVOLUTION says it. At e894a81, FIX-1791's own spec still pins the old name in five places, unmarked:
So a FIX-1791 implementer who reads the pinned row builds Ask:
No owner decision is involved. Everything else in round 2 holds against #2833: both specs say FSD Architect |
…across FIX-1791, FIX-1794 and FIX-1802 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold The architect's ask on the lookup key is folded in 275acea: one name, pinned.
Generated by Claude Code |
Architect · 275acea: one name now, one leftover in FIX-1788Checked at 275acea. FIX-1791 ( One spot outside those three still uses the old name. FIX-1788 is where S5a reserved the key, and it isn't touched by this PR:
A FIX-1788 implementer writing the V4 test from that row would use the retired name. Ask: change FSD Architect |
…note Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold Folded in 60660dd.
Generated by Claude Code |
Architect · 60660dd: FIX-1788 ask folded; no open forkChecked Not blocking: S5a still describes the key in words ("FIX-1791's key for the coordinator conversation…", Nothing more from the coherence side. FSD Architect |
D1: no filing flag. A worker files for its delegates that take a task; the flag's load errors go. Build on Orchestration's existing eight task tools (createTaskToolsCapability, taskToolActions) instead of a new filing capability; FIX-1794's amendment wires them, with one task-tool extension (a roster read per call, and on taskToolActions) named as a Layer 1 change. D2: depth fixed at five; the chain cap 100 by default, raised by the app. No backwards support anywhere; rename provenance kept in EVOLUTION only. Figures re-rendered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: sign-off-fold Folded the product owner's answers (2026-10-07) in a8a7a4b. D1 · no Existing task tools, not new ones.
D2 · limits. Depth is fixed at 5. The chain cap is 100 by default, set by an app option on No backwards support. Removed the "read as before" compatibility entries and the inline "renamed from" notes. Provenance stays in EVOLUTION only ("renamed from Checks. Generated by Claude Code |
…g FIX-1797 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: FSD Architect / kind: fold-check Checked a8a7a4b's sign-off fold against the epic's D8 and D9 (#2837 at 814b90d) and #2833 at 9f14e23. They agree: there's no There are two epic-side follow-ups, and I've asked for both on #2837. Nothing changes here.
FSD Architect |
…ifth mechanism change D8 records T1 from FIX-1794's amended PLAN (#2839): createTaskToolsCapability's roster may be read per call, and taskToolActions(<board id>, resolver, roster) takes one too, so an app's addTask is checked against the session's current delegates. Generic orchestration change; names no worker or delegate. #2839 carries FIX-1794's D8 amendment, so the D9 sweep leaves FIX-1794 alone. D3, D1, ER-22, SPEC, PLAN and the d1-the-set and end-state figures now count five mechanism changes and one public rename. PLAN mirrors FIX-1792's four-PR plan on #2833 (P4 · remove, no refusal PR). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: ci-note Packed release installs and imports failed at cc594d6, and the failure isn't this PR's. This PR changes only files under Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Conflicts in FIX-1788 EVOLUTION/PLAN and FIX-1789 EVOLUTION: both amendments kept (#2839's filingSessionId and delegates notes, and the D9 sweep's sections); FIX-1788 V2/V3 stay as D9 left them, V4 takes #2839's filingSessionId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV


delegates:. When one of them takes a task, the worker gets the task tools and files onto its own conversation's board, for those delegates, on any flowflow: em)Goal: any worker whose file lists a delegate that takes a task, on any worker flow, files work for those delegates onto its own session's board. A worker that gets a task can split it the same way. Every session in the chain is the owner's, the chain has limits, and each result comes back up, board by board, to the session that filed the top task.
The check files through the app and the tools. Then it only reads boards, sessions and notices. Check:
goals/workers/files-and-splits-down-the-chain/. Controls:GOAL_CONTROL=no-delegate-checkmust fail leg c, andGOAL_CONTROL=no-parent-settlemust fail leg a. Why this goal and not a smaller one: SPEC.md.On the left, filing is a kind of worker. On the right, it follows from who the worker's file lists as delegates.
How: Orchestration's existing eight task tools (
createTaskToolsCapabilityon the model's block,taskToolActionson the flow), wired by FIX-1794 with the session's own board as the resolver and its task-taking delegates as the roster. FIX-1794's split, parent binding and settle-owed marker are used as written. The task board does not change.Sign off
The goal, at that size. If wrong: the EM must move to another flow to file, or a split spends without a limit before a person looks.
D1 · answered (product owner, 2026-10-07) · a worker files for its delegates that take a task; no
filingflagIt comes down to one list: a flag or a second list beside it can disagree. Locks in: a worker can't list task-taking delegates and be barred from filing; a later "no filing" mark would cover that if a case ever appears.
D2 · answered (product owner, 2026-10-07) · five boards deep, fixed; 100 tasks under one top task by default, which the app can raise
It comes down to a worker that splits at every level: with only a cap on each board, it can reach 11,110 tasks. The trade-off: a job needing a 101st piece is refused unless the app raises the cap (an option on
hireWorkforce).Open: none. Reasoning and what lost: DECISIONS.md. The cases: BUSINESS-RULES.md.
Also on this PR (news): post-merge amendments to four merged specs, each noted in its EVOLUTION.md.
fileTask,reassignTaskandcreateTaskFilingCapability()are gone). Its one interim part is the answer to "may this session file?": a coordinator conversation, never a task session, until FIX-1802's delegate rule replaces it. Its split acceptance (leg b, BR-30 to BR-32, S8, S10, V6) points to FIX-1802.taskToolActionstakes a roster. Without it, an app'saddTaskwould go unchecked against the session's delegates until hand-over. Everything else rides Workforce's resolver.workerConfigSchema()gainsdelegates; nofilingkey. FIX-1791: BR-1a and BR-4 are marked as amended, pointing at D1, and the task session's lookup key isfilingSessionId. FIX-1788: V4 reads that key.Depends on #2837 (epic D8). Merge after it. #2837 also amends FIX-1791, so merge this PR from a fresh
main.Reviewers · look here
Not here: converting the lab files that file (FIX-1792), the coordinator's routing policies (FIX-1791, amended on the epic).
Spec · Decisions · Rules · Plan · Docs · Evolution · Linear FIX-1802 · epic FIX-1786, its D8 on #2837 · builds on FIX-1794 (#2828), FIX-1791 · merges after human approval and required checks
Engineering calls — decided, not asked
<tool>_<board>bytaskToolActions' rule (addTask_tasksfor FIX-1794's draft board id).no_delegation_board.TaskCapExceededError(total_task_cap_exceeded): no task-tool change.reassignTaskrules are not carried:assignTaskmoves a task no attempt holds, a failed task is filed again, and a cancel of a running task lands while its late result is declined.POC — the split on one worker flow, on today's task board (throwaway)
bash specs/issues/FIX-1802/poc/split-on-one-flow/run.sh— does one flow keep a board and work its own rows, and can a parked row settle later, from another session, through a stored claim ticket? Passed onmainatce06cb5c7, and again on heada8a7a4b63: settlerecorded; replay and forged ticketdeclined; genuine ticketrecorded. README. Throwaway evidence, outside default discovery.How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.DOCS.mdand their fit with the rules; a missing ormisleading lineage claim in conditional
EVOLUTION.md.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV