Skip to content

fix(shift-manager): remove On Call from the default config and the UI (FIX-1964) - #3291

Merged
jhoffner merged 5 commits into
mainfrom
claude/project-thread-bwvknu
Oct 14, 2026
Merged

jhoffner merged 5 commits into
mainfrom
claude/project-thread-bwvknu

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Jake · project thread

The problem

Shift Manager talks about On Call everywhere: an ops.oncall worker in DevTeam, an "on call" worker status in Roster, the sidebar, the footer and the team strip, an ON CALL list in the Shift Coordinator's right panel, a "Who's on call?" suggestion, and on-call counts in Tasks and the empty Inbox. On Call isn't a real feature yet. Today "on call" only means "waiting on you", so the word promises something (webhooks, standing watches) the product doesn't do.

What this does

Removes On Call. Nothing is stubbed for its return.

  • DevTeam's ops/oncall worker is deleted. The ops team held only that worker, so DevTeam no longer has an ops team.
  • A worker is on shift or off shift. A worker waiting on you, on a parked task or an ask, now reads on shift. The "N waiting on you" count and the WAITING tags still show what waits on you.
  • Roster: no ON CALL group, no standing-watches gap line. The last column is renamed WAITING ON YOU.
  • Sidebar Roster count, footer, project team strip, Tasks summary and empty Inbox: on-call counts removed.
  • Shift Coordinator: the right panel's ON CALL list and the "Who's on call?" suggestion are removed. The panel shows DELEGATES and TASKS, and the collapsed strip is labelled DELEGATES. The composer no longer takes suggestions at all, since that was the only one.
  • The published docs (Shift Manager overview, glossary and its diagram) describe the two groups.

What's asked of you

Nothing here is yours to decide. One call is worth a glance: a worker waiting on you reads on shift, not off shift. It's mid-task and holds a slot, and Roster already shows its slots in use. Calling it off shift would contradict that. If you'd rather it read off shift, the change is one line in workerStates.

Parts worth reviewing closely

  • src/lib/derive.ts → workerStates: the status rule.
  • src/surfaces/ChiefOfStaff.tsx → ChiefOfStaffPanel: with no chief of staff on the coordinator flow, the panel used to show only ON CALL. It now says "No delegates or tasks yet."
  • README.md → "Shift Coordinator": the suggestions paragraph is gone. It also named a What's blocking #<workstream>? suggestion that the code never drew.

Links

Linear FIX-1964 · epic FIX-1958 (Shift Manager release candidate). Merges when approved. #3283 (FIX-1962) touches ChiefOfStaff.tsx near the panel, and the FIX-1961 sidebar work touches Sidebar.tsx, so expect a small rebase on whichever lands second.

Everything else

Verification. pnpm --filter @flow-state-dev/shift-manager typecheck is clean. Goal checks it-shows-who-is-on-shift, it-opens-a-lab and it-draws-v2s-look were updated to the two statuses and PASS; it-shows-who-is-on-shift's ignore-asks control still FAILs as required. Verdict rows are in each goal.md. vitest run in packages/shift-manager gives 452 passed, 5 failed. The 5 failures are in checkout.test.ts (4) and command.test.ts (1), and the same 5 fail on unchanged main in this container: they need built pages and a credential-free environment. Two TEAMS-count assertions failed against the new rule before I updated them, so the tests do reach the changed code.

Left alone on purpose. Workforce fixtures and docs that use "on-call" as example content (page-oncall, handbooks) aren't the app's config. Historical goal verdict rows that name ops.oncall are records.

Changeset. .changeset/shift-manager-no-on-call.md (patch). The two pending Shift Manager fragments that mentioned on-call counts now say on shift.

DevForce goal. it-wakes-the-seat-a-file-declared no longer lists ops.oncall. That goal already fails on main for reasons unrelated to this PR (its fixture omits general-lead and researcher, and eng.em declares onDelegatedPost), and it fails the same way with this change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV


Note

Medium Risk
Broad UX and counting changes across Roster, sidebar, and Shift Coordinator, driven by a single status rule in derive.ts; behavior is well covered by updated tests and goals but affects how every worker’s shift state is displayed.

Overview
Shift Manager drops the On Call concept (FIX-1964). Workers are only on shift or off shift; anyone running a task or waiting on you (parked task or pending ask) counts as on shift. Roster loses the middle group, renames the last column to WAITING ON YOU, and strips on-call counts from the sidebar, footer, project team strip, Tasks summary, and empty Inbox copy.

Shift Coordinator no longer shows an ON CALL rail list or composer suggestions (including “Who’s on call?”); the right panel is DELEGATES / TASKS only, and suggestion chips are removed from TurnComposer / Conversation. DevTeam deletes the ops.oncall worker and related tests/fixtures.

Core logic lives in workerStates in derive.ts; docs, changesets, and goal checks are aligned with the two-status model.

Reviewed by Cursor Bugbot for commit 8746ac8. Configure here.

… (FIX-1964)

On Call isn't established yet; it comes back later as reacting to webhooks
and system events. Until then:

- DevTeam's ops/oncall worker is gone (the ops team held only it).
- A worker's status is on shift or off shift. A worker waiting on you,
  on a parked task or an ask, reads on shift: it is mid-task. The waiting
  count and WAITING tags still say what waits on you.
- Roster drops the ON CALL group and the standing-watches gap; its last
  column is WAITING ON YOU. The sidebar, footer, team strip, Tasks summary
  and empty Inbox drop their on-call counts.
- The Shift Coordinator rail drops its ON CALL list and the "Who's on
  call?" suggestion.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
@jhoffner jhoffner self-assigned this Oct 13, 2026
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

FIX-1964

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 14, 2026 12:37am UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 14, 2026 12:37am UTC
flow-state-dev-ui Ignored Ignored Preview Oct 14, 2026 12:37am UTC

Request Review

@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: d03c80af-dc1d-445e-9987-14c30777197e)

@jhoffner jhoffner left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second-look and architecture pass. The approach is right: delete the concept outright and collapse the status union to two values. I found no better shape. The workerStates simplification is correct. Held rows are already only running or waiting-on-you rows, so held.length > 0 || asks.length > 0 matches the new rule. I grepped for leftover "on call" in packages/shift-manager. The remaining hits are SessionCall, call() and similar, not the feature.

1. Orphaned suggestions plumbing (worth doing in this PR).
This PR removes the only caller, chiefOfStaffSuggestions(). suggestions is still threaded through Conversation.tsx (props, line 143) and TurnComposer.tsx (props, and the render block near line 329 with its ${testId}-suggestions test id). That is dead code created by this change. The PR description says it was left on purpose, but CLAUDE.md §3 says to remove orphans your own change creates. Deleting the prop and the render branch is about 20 lines and removes a code path nothing can exercise. Check first that autoSend/lead don't depend on the suggestions layout.

2. The collapsed strip name doesn't match the PR description.
The description says the strip is now "DELEGATES and TASKS". PANEL_NAMES in App.tsx:181 says only "DELEGATES". Either change the code to "DELEGATES · TASKS" (or "TASKS") or fix the description. Separately, the strip is static while the panel body is conditional. With no coordinator-flow chief of staff, the strip still reads DELEGATES and the panel says "No delegates or tasks yet." That is acceptable, but be aware that it means the panel is now a dead rail for any Lab without a coordinator-flow chief of staff.

3. Doc comment line-wrap.
In Roster.tsx, the header comment's first line is now a single over-long line ("Roster: every worker the user has, grouped on shift and off shift, for all teams or one ...") followed by the old-width lines. Rewrap it like the rest of the block.

4. GROUP_SUB wording.
"off shift: nothing assigned" drops "nothing subscribed", which is correct now. Check that no test or README text still quotes the old strings. I saw none.

5. Tests.
The PR notes that two TEAMS-count assertions failed against the new rule before they were updated, which shows the tests reach the changed code. One gap: nothing asserts the one deliberate product call, that a worker with only a pending ask (no held row) reads on shift. If a roster.test.ts case already covers it, fine. If not, add one. This is the rule the description asks the owner to glance at, so it should be pinned.

Not an issue / leave alone:

  • Deleting ops/oncall and the ops team. I found no remaining references to ops.oncall outside historical records.
  • Leaving the Workforce fixtures that use "on-call" as example content. Those are not app config.

Architecture note (no action):
ShiftStatus is now a two-value union that is effectively held || asks. If a third status never returns, SHIFT_STATUSES/GROUP_SUB/ShiftMark could eventually become a boolean, but that is not worth doing here. The repo shouldn't stub for On Call's return, and the union costs nothing.

Rebase heads-up with #3283 and the FIX-1961 sidebar work is already noted in the description.


Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify / review (FIX-1964)

Problem this PR names: On Call is not a real product concept yet (standing watches are FIX-1675), so the Lab should not show on-call chrome or ship a placeholder ops.oncall worker.

What landed in the top commit (321a97b08): A coherent, deletion-heavy pass — collapse ShiftStatus to two values, fold “waiting on you” into on shift, drop counts/rail/group UI, remove DevTeam ops/oncall, update package README and vitest. That is the right direction for simplicity: fewer states, less misleading copy, and a cleaner re-entry path when FIX-1675 defines on-call as subscriptions rather than inbox waits.

Where the approach may have gone further than necessary

Choice Trade-off Lighter alternative (if you want less churn)
Delete "on call" from ShiftStatus and merge derive rules Touches types, marks, tests, goals, docs, and future FIX-1675 reintro UI-only: keep three derive buckets (or keep the type but only show two Roster groups) until standing watches exist; drop sidebar/footer/COS on-call counts only
Remove gaps.roster.watches Loses in-app pointer to FIX-1675 Keep a one-line Roster footnote (no third group)
Remove chiefOfStaffSuggestions() entirely Also removes the only shipped suggestion chip (Who's on call?); README had a second line (What's blocking #…) that was never in code Delete only the on-call string; leave the suggestions hook for a future workstream chip
cos-panel-empty when COS is not coordinator-flow New copy can read like “nothing happening” while the center conversation is active Omit rail content (pre-change) unless COORDINATOR_FLOW COS

I would not block on picking UI-only vs model collapse — both are defensible. I would block merge on scope and doc/goal alignment below.


Major: PR scope vs title

Against main, this branch is ~90 files / 13 commits, including FIX-1955 (secret fields), FIX-1905 (project MCP + Settings), claude-code MCP tools, workforce project-mcp-tools, new goals, etc. The title describes only FIX-1964.

Cleaner approach: Rebase or retarget so this PR is only the shift-manager on-call removal (or split: MCP stack first, then FIX-1964 on updated main). Reviewers and release notes cannot treat this as a small shift-manager fix.

Major: published docs still describe three roster groups

packages/shift-manager/README.md is updated, but apps/docs/docs/shift-manager/overview.md (Roster row + “Not there yet”) and apps/docs/docs/glossary.md still say on call = waiting on you. This PR even adds Settings copy to overview.md without updating those lines — users will see two different stories.

Major (if CI runs goals): goal oracles unchanged

goals/shift-manager/it-shows-who-is-on-shift, it-opens-a-lab, and it-draws-v2s-look still assert three statuses, footer footer-on-call, COS suggestions, and on-call empty-Inbox copy. Package tests were updated; goals were not. Confirm pipeline scope; if goals run, extend this change set or file follow-up before merge.


Nits / optional

  • Semantics: “On shift” now includes parked tasks and asks, not only running work. waiting in roster summary still disambiguates; sidebar/TEAMS only show on-shift count — consider surfacing waiting in the shell later (no third status required).
  • Comments: shell.test.tsx still mentions “nobody is on call” above an assertion that no longer mentions on call.
  • Perf: No concerns; fewer panel work per render.

Verification note

Targeted vitest for roster/shell/inbox derive tests pass on this branch. Full pnpm test in shift-manager failed in this environment on unrelated imports (@flow-state-dev/tools/mcp / lab boot), likely from the stacked MCP work without a full monorepo build — worth confirming CI on the retargeted PR.

Recommendation: Retarget or split the PR, align apps/docs (and glossary) with two-status roster, update goals if they run in CI, then merge. The FIX-1964 implementation itself is lean; the main simplify win is not shipping it inside a multi-feature branch.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Comment thread packages/shift-manager/src/gaps.ts Resolved

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Snob

A smaller shape exists. #3291 already deleted chiefOfStaffSuggestions() and the only caller. Conversation and TurnComposer still take suggestions, and ComposerShell still has an above slot whose only job was those chips. Nothing passes either, so the chips never render. autoSend and lead do not sit in that slot.

Two leftovers of the same edit: the Roster count is a template around one number, and shell.test.tsx still comments that the empty Inbox mentions on call.

Left alone: the two-status union. A boolean would be a different contract, and the PR already said that is not worth doing.

POC, do not merge: #3295

Fold that subtraction into this PR, then close the POC unmerged after this lands.

Open in Web View Automation 

Sent by Cursor Automation: Code Snob

…ollow On Call's removal (FIX-1964)

- Conversation and TurnComposer no longer take `suggestions`; the
  composer's `above` slot existed only for them.
- Roster's header comment rewrapped.
- it-shows-who-is-on-shift, it-opens-a-lab and it-draws-v2s-look grade
  two statuses, no on-call counts, the WAITING ON YOU column and no
  suggestion row. All three PASS; ignore-asks still fails as required.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 04da33a2-530f-45a7-8a0f-247635462d3f)

Copy link
Copy Markdown
Collaborator Author

Answering the second-look review, all in a362425:

  1. Orphaned suggestions: removed from Conversation and TurnComposer, together with the composer's above slot, which existed only to hold them. autoSend and lead don't depend on that layout.
  2. Strip name: the code keeps DELEGATES, and the description now says that.
  3. Roster header comment: rewrapped.
  4. GROUP_SUB: confirmed. The only other place that quoted the old strings was the it-draws-v2s-look goal check, and it now carries the new ones.
  5. Ask-only reads on shift: this is already pinned. In roster.test.ts, the BR-2 case gives eng.reviewer a pending ask with no held row and asserts on shift with held: [].

Your grep found something more: three Shift Manager goal checks still graded on call. it-shows-who-is-on-shift, it-opens-a-lab and it-draws-v2s-look now grade the two statuses, and the suggestion row is retired. All three PASS, and the ignore-asks control still FAILs on the ask-only worker.


Generated by Claude Code

… the number (FIX-1964)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: efceba74-378f-4f3f-a068-6fa443b493b3)

Copy link
Copy Markdown
Collaborator Author

On the Cursor reviews:

  • Scope. The "~90 files / 13 commits" figure doesn't match this branch. Against current main, the branch is 3 commits and 32 files, all of it FIX-1964.
  • Published docs. That was a real miss, and 9e538fc fixes it. apps/docs shift-manager/overview.md, glossary.md and the glossary's shift-manager.svg now describe two groups, and the "on call means waiting on you" line is gone.
  • Goal oracles. These were already updated in a362425. All three PASS, and the ignore-asks control still fails as required.
  • Code Snob. The suggestions/above subtraction was already in a362425, and the Roster count and the shell.test.tsx comment are fixed in 9e538fc. That covers everything POC POC: drop the dead composer suggestions slot #3295 holds, so POC: drop the dead composer suggestions slot #3295 can close unmerged.

Generated by Claude Code

@jhoffner

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T23:55:32.427255Z 9e538fc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e538fc7c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… drops ops.oncall (FIX-1964)

Shift Manager publishes, so FIX-1964 gets a patch fragment, and the two
pending fragments that promised on-call counts now say on shift.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: cecc75ce-7e20-4ac5-b29d-5c41cf61fe95)

@jhoffner

Copy link
Copy Markdown
Collaborator Author

Architect: not approving yet. cursor[bot] still has a live CHANGES_REQUESTED on this PR (the scope / published-docs / goal-oracle majors). Those look addressed in a362425 and 9e538fc and the review threads are resolved; dismiss that review or get a fresh pass so the request state clears. CI on f146db22 is also still running.

Copy link
Copy Markdown
Collaborator Author

Status of cursor[bot]'s CHANGES_REQUESTED review (on 321a97b). Each of its three majors is addressed on the current head:

  • Scope. This branch is 4 commits and 40 files against main, all FIX-1964. The MCP/secret-field commits it counted had already merged to main, so the count was against a stale base.
  • Published docs. apps/docs/docs/shift-manager/overview.md, glossary.md and glossary/shift-manager.svg describe the two groups (a362425).
  • Goal oracles. it-shows-who-is-on-shift, it-opens-a-lab and it-draws-v2s-look are updated and PASS locally. The ignore-asks control FAILs as required (9e538fc).

That Cursor automation hasn't re-reviewed later commits, and I can't dismiss a review from this session. Someone with write access needs to dismiss it in the GitHub UI so the request state clears. CI on f146db2 is still running, and I'll fix anything that turns red.


Generated by Claude Code

@jhoffner
jhoffner merged commit 64b0223 into main Oct 14, 2026
16 of 17 checks passed
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 3d722189-c3c3-4e42-b544-cdf7f81c99ce)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants