Repository navigation
fix(shift-manager): remove On Call from the default config and the UI (FIX-1964) - #3291
Conversation
… (FIX-1964) On Call isn't established yet; it comes back later as reacting to webhooks and system events. Until then: - DevTeam's ops/oncall worker is gone (the ops team held only it). - A worker's status is on shift or off shift. A worker waiting on you, on a parked task or an ask, reads on shift: it is mid-task. The waiting count and WAITING tags still say what waits on you. - Roster drops the ON CALL group and the standing-watches gap; its last column is WAITING ON YOU. The sidebar, footer, team strip, Tasks summary and empty Inbox drop their on-call counts. - The Shift Coordinator rail drops its ON CALL list and the "Who's on call?" suggestion. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d03c80af-dc1d-445e-9987-14c30777197e) |
jhoffner
left a comment
There was a problem hiding this comment.
Second-look and architecture pass. The approach is right: delete the concept outright and collapse the status union to two values. I found no better shape. The workerStates simplification is correct. Held rows are already only running or waiting-on-you rows, so held.length > 0 || asks.length > 0 matches the new rule. I grepped for leftover "on call" in packages/shift-manager. The remaining hits are SessionCall, call() and similar, not the feature.
1. Orphaned suggestions plumbing (worth doing in this PR).
This PR removes the only caller, chiefOfStaffSuggestions(). suggestions is still threaded through Conversation.tsx (props, line 143) and TurnComposer.tsx (props, and the render block near line 329 with its ${testId}-suggestions test id). That is dead code created by this change. The PR description says it was left on purpose, but CLAUDE.md §3 says to remove orphans your own change creates. Deleting the prop and the render branch is about 20 lines and removes a code path nothing can exercise. Check first that autoSend/lead don't depend on the suggestions layout.
2. The collapsed strip name doesn't match the PR description.
The description says the strip is now "DELEGATES and TASKS". PANEL_NAMES in App.tsx:181 says only "DELEGATES". Either change the code to "DELEGATES · TASKS" (or "TASKS") or fix the description. Separately, the strip is static while the panel body is conditional. With no coordinator-flow chief of staff, the strip still reads DELEGATES and the panel says "No delegates or tasks yet." That is acceptable, but be aware that it means the panel is now a dead rail for any Lab without a coordinator-flow chief of staff.
3. Doc comment line-wrap.
In Roster.tsx, the header comment's first line is now a single over-long line ("Roster: every worker the user has, grouped on shift and off shift, for all teams or one ...") followed by the old-width lines. Rewrap it like the rest of the block.
4. GROUP_SUB wording.
"off shift: nothing assigned" drops "nothing subscribed", which is correct now. Check that no test or README text still quotes the old strings. I saw none.
5. Tests.
The PR notes that two TEAMS-count assertions failed against the new rule before they were updated, which shows the tests reach the changed code. One gap: nothing asserts the one deliberate product call, that a worker with only a pending ask (no held row) reads on shift. If a roster.test.ts case already covers it, fine. If not, add one. This is the rule the description asks the owner to glance at, so it should be pinned.
Not an issue / leave alone:
- Deleting
ops/oncalland theopsteam. I found no remaining references toops.oncalloutside historical records. - Leaving the Workforce fixtures that use "on-call" as example content. Those are not app config.
Architecture note (no action):
ShiftStatus is now a two-value union that is effectively held || asks. If a third status never returns, SHIFT_STATUSES/GROUP_SUB/ShiftMark could eventually become a boolean, but that is not worth doing here. The repo shouldn't stub for On Call's return, and the union costs nothing.
Rebase heads-up with #3283 and the FIX-1961 sidebar work is already noted in the description.
Generated by Claude Code
There was a problem hiding this comment.
Simplify / review (FIX-1964)
Problem this PR names: On Call is not a real product concept yet (standing watches are FIX-1675), so the Lab should not show on-call chrome or ship a placeholder ops.oncall worker.
What landed in the top commit (321a97b08): A coherent, deletion-heavy pass — collapse ShiftStatus to two values, fold “waiting on you” into on shift, drop counts/rail/group UI, remove DevTeam ops/oncall, update package README and vitest. That is the right direction for simplicity: fewer states, less misleading copy, and a cleaner re-entry path when FIX-1675 defines on-call as subscriptions rather than inbox waits.
Where the approach may have gone further than necessary
| Choice | Trade-off | Lighter alternative (if you want less churn) |
|---|---|---|
Delete "on call" from ShiftStatus and merge derive rules |
Touches types, marks, tests, goals, docs, and future FIX-1675 reintro | UI-only: keep three derive buckets (or keep the type but only show two Roster groups) until standing watches exist; drop sidebar/footer/COS on-call counts only |
Remove gaps.roster.watches |
Loses in-app pointer to FIX-1675 | Keep a one-line Roster footnote (no third group) |
Remove chiefOfStaffSuggestions() entirely |
Also removes the only shipped suggestion chip (Who's on call?); README had a second line (What's blocking #…) that was never in code |
Delete only the on-call string; leave the suggestions hook for a future workstream chip |
cos-panel-empty when COS is not coordinator-flow |
New copy can read like “nothing happening” while the center conversation is active | Omit rail content (pre-change) unless COORDINATOR_FLOW COS |
I would not block on picking UI-only vs model collapse — both are defensible. I would block merge on scope and doc/goal alignment below.
Major: PR scope vs title
Against main, this branch is ~90 files / 13 commits, including FIX-1955 (secret fields), FIX-1905 (project MCP + Settings), claude-code MCP tools, workforce project-mcp-tools, new goals, etc. The title describes only FIX-1964.
Cleaner approach: Rebase or retarget so this PR is only the shift-manager on-call removal (or split: MCP stack first, then FIX-1964 on updated main). Reviewers and release notes cannot treat this as a small shift-manager fix.
Major: published docs still describe three roster groups
packages/shift-manager/README.md is updated, but apps/docs/docs/shift-manager/overview.md (Roster row + “Not there yet”) and apps/docs/docs/glossary.md still say on call = waiting on you. This PR even adds Settings copy to overview.md without updating those lines — users will see two different stories.
Major (if CI runs goals): goal oracles unchanged
goals/shift-manager/it-shows-who-is-on-shift, it-opens-a-lab, and it-draws-v2s-look still assert three statuses, footer footer-on-call, COS suggestions, and on-call empty-Inbox copy. Package tests were updated; goals were not. Confirm pipeline scope; if goals run, extend this change set or file follow-up before merge.
Nits / optional
- Semantics: “On shift” now includes parked tasks and asks, not only running work.
waitingin roster summary still disambiguates; sidebar/TEAMS only show on-shift count — consider surfacingwaitingin the shell later (no third status required). - Comments:
shell.test.tsxstill mentions “nobody is on call” above an assertion that no longer mentions on call. - Perf: No concerns; fewer panel work per render.
Verification note
Targeted vitest for roster/shell/inbox derive tests pass on this branch. Full pnpm test in shift-manager failed in this environment on unrelated imports (@flow-state-dev/tools/mcp / lab boot), likely from the stacked MCP work without a full monorepo build — worth confirming CI on the retargeted PR.
Recommendation: Retarget or split the PR, align apps/docs (and glossary) with two-status roster, update goals if they run in CI, then merge. The FIX-1964 implementation itself is lean; the main simplify win is not shipping it inside a multi-feature branch.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
Code Snob
A smaller shape exists. #3291 already deleted chiefOfStaffSuggestions() and the only caller. Conversation and TurnComposer still take suggestions, and ComposerShell still has an above slot whose only job was those chips. Nothing passes either, so the chips never render. autoSend and lead do not sit in that slot.
Two leftovers of the same edit: the Roster count is a template around one number, and shell.test.tsx still comments that the empty Inbox mentions on call.
Left alone: the two-status union. A boolean would be a different contract, and the PR already said that is not worth doing.
POC, do not merge: #3295
Fold that subtraction into this PR, then close the POC unmerged after this lands.
Sent by Cursor Automation: Code Snob
…ollow On Call's removal (FIX-1964) - Conversation and TurnComposer no longer take `suggestions`; the composer's `above` slot existed only for them. - Roster's header comment rewrapped. - it-shows-who-is-on-shift, it-opens-a-lab and it-draws-v2s-look grade two statuses, no on-call counts, the WAITING ON YOU column and no suggestion row. All three PASS; ignore-asks still fails as required. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 04da33a2-530f-45a7-8a0f-247635462d3f) |
|
Answering the second-look review, all in a362425:
Your grep found something more: three Shift Manager goal checks still graded on call. Generated by Claude Code |
… the number (FIX-1964) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: efceba74-378f-4f3f-a068-6fa443b493b3) |
|
On the Cursor reviews:
Generated by Claude Code |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e538fc7c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… drops ops.oncall (FIX-1964) Shift Manager publishes, so FIX-1964 gets a patch fragment, and the two pending fragments that promised on-call counts now say on shift. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: cecc75ce-7e20-4ac5-b29d-5c41cf61fe95) |
|
Architect: not approving yet. cursor[bot] still has a live CHANGES_REQUESTED on this PR (the scope / published-docs / goal-oracle majors). Those look addressed in a362425 and 9e538fc and the review threads are resolved; dismiss that review or get a fresh pass so the request state clears. CI on |
|
Status of cursor[bot]'s CHANGES_REQUESTED review (on 321a97b). Each of its three majors is addressed on the current head:
That Cursor automation hasn't re-reviewed later commits, and I can't dismiss a review from this session. Someone with write access needs to dismiss it in the GitHub UI so the request state clears. CI on f146db2 is still running, and I'll fix anything that turns red. Generated by Claude Code |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3d722189-c3c3-4e42-b544-cdf7f81c99ce) |


Requested by Jake · project thread
The problem
Shift Manager talks about On Call everywhere: an
ops.oncallworker in DevTeam, an "on call" worker status in Roster, the sidebar, the footer and the team strip, an ON CALL list in the Shift Coordinator's right panel, a "Who's on call?" suggestion, and on-call counts in Tasks and the empty Inbox. On Call isn't a real feature yet. Today "on call" only means "waiting on you", so the word promises something (webhooks, standing watches) the product doesn't do.What this does
Removes On Call. Nothing is stubbed for its return.
ops/oncallworker is deleted. Theopsteam held only that worker, so DevTeam no longer has anopsteam.What's asked of you
Nothing here is yours to decide. One call is worth a glance: a worker waiting on you reads on shift, not off shift. It's mid-task and holds a slot, and Roster already shows its slots in use. Calling it off shift would contradict that. If you'd rather it read off shift, the change is one line in
workerStates.Parts worth reviewing closely
src/lib/derive.ts→workerStates: the status rule.src/surfaces/ChiefOfStaff.tsx→ChiefOfStaffPanel: with no chief of staff on the coordinator flow, the panel used to show only ON CALL. It now says "No delegates or tasks yet."README.md→ "Shift Coordinator": the suggestions paragraph is gone. It also named aWhat's blocking #<workstream>?suggestion that the code never drew.Links
Linear FIX-1964 · epic FIX-1958 (Shift Manager release candidate). Merges when approved. #3283 (FIX-1962) touches
ChiefOfStaff.tsxnear the panel, and the FIX-1961 sidebar work touchesSidebar.tsx, so expect a small rebase on whichever lands second.Everything else
Verification.
pnpm --filter @flow-state-dev/shift-manager typecheckis clean. Goal checksit-shows-who-is-on-shift,it-opens-a-labandit-draws-v2s-lookwere updated to the two statuses and PASS;it-shows-who-is-on-shift'signore-askscontrol still FAILs as required. Verdict rows are in eachgoal.md.vitest runinpackages/shift-managergives 452 passed, 5 failed. The 5 failures are incheckout.test.ts(4) andcommand.test.ts(1), and the same 5 fail on unchangedmainin this container: they need built pages and a credential-free environment. Two TEAMS-count assertions failed against the new rule before I updated them, so the tests do reach the changed code.Left alone on purpose. Workforce fixtures and docs that use "on-call" as example content (
page-oncall, handbooks) aren't the app's config. Historical goal verdict rows that nameops.oncallare records.Changeset.
.changeset/shift-manager-no-on-call.md(patch). The two pending Shift Manager fragments that mentioned on-call counts now say on shift.DevForce goal.
it-wakes-the-seat-a-file-declaredno longer listsops.oncall. That goal already fails onmainfor reasons unrelated to this PR (its fixture omitsgeneral-leadandresearcher, andeng.emdeclaresonDelegatedPost), and it fails the same way with this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01EwFetgFFCWeki9fG9r2LhV
Note
Medium Risk
Broad UX and counting changes across Roster, sidebar, and Shift Coordinator, driven by a single status rule in derive.ts; behavior is well covered by updated tests and goals but affects how every worker’s shift state is displayed.
Overview
Shift Manager drops the On Call concept (FIX-1964). Workers are only on shift or off shift; anyone running a task or waiting on you (parked task or pending ask) counts as on shift. Roster loses the middle group, renames the last column to WAITING ON YOU, and strips on-call counts from the sidebar, footer, project team strip, Tasks summary, and empty Inbox copy.
Shift Coordinator no longer shows an ON CALL rail list or composer suggestions (including “Who’s on call?”); the right panel is DELEGATES / TASKS only, and suggestion chips are removed from
TurnComposer/Conversation. DevTeam deletes theops.oncallworker and related tests/fixtures.Core logic lives in
workerStatesinderive.ts; docs, changesets, and goal checks are aligned with the two-status model.Reviewed by Cursor Bugbot for commit 8746ac8. Configure here.