Repository navigation
fix(goals): DevTeam wake check reads the current worker list and allows the EM's post entry (FIX-1966) - #3299
Conversation
…ws the EM's post entry (FIX-1966) The check failed on main twice over: its worker list predates the org's general lead and researcher (FIX-1920), and it refused eng.em's `onDelegatedPost` task entry, which FIX-1872 D1 gives the EM. That entry runs the EM's own turn and dispatches; it runs no harness. Leg b now refuses any task entry beside the delegated post, and any harness package import in em.mts, so no coordinator can still run a harness. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukfpBf4vLMrHcW584uZeF
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Second look + architecture pass (read-only, no edits made)Verdict: the approach is right and proportionate. Updating the roster fixture, loosening the "no task entry" rule to "only the delegated post", and importing 1. The harness-import check is narrower than the claim it backs (worth fixing in this PR)
HARNESS_PACKAGES.filter((pkg) => emSource.includes(`"${pkg}`))
You did red-state the 2. Fixture drift is a recurring tax, not a one-offThis is the third time the same hand-typed worker list has gone stale (FIX-1883 removed 3. Merge-order heads-up#3291 edits the same 4. Nits
No correctness bugs found in the diff. The Generated by Claude Code |
There was a problem hiding this comment.
Problem
After FIX-1920 (org general-lead / researcher) and FIX-1872 D1 (EM gets onDelegatedPost), the DevTeam wake goal was red on main for two independent reasons: the hired-worker oracle was stale, and leg (b) still treated any EM task entry as a harness route.
Assessment
This PR is the right shape of fix: extend the fixture roster and allow exactly DELEGATED_POST_ENTRY on the coordinator seat, with a static em.mts guard so BR-4 survives refactors that hide imports inside the delegated-post turn. Scope stays inside one goal — no framework churn.
I do not think a fundamentally different approach is required. What follows are tighten-ups that would make the assertion smaller and harder to game, not a rewrite.
Simpler / cleaner options (optional)
-
EM task entries — Today leg (b) only fails when there are keys besides
DELEGATED_POST_ENTRY. An emptytask.actionsobject would pass even though BR-4 requires the delegated post. You already havesameSetin this file;sameSet(emEntries, [DELEGATED_POST_ENTRY])states the invariant in one place and covers missing post + extra entries. -
HARNESS_PACKAGES— A four-package denylist plus substring"${pkg}scans is maintenance-heavy and weaker thanharness-manager’s ownslot.spec.tsimport sweep (from "..."parsing). Unless product explicitly needs to block direct@flow-state-dev/codex/cursorimports onem.mts, a single check for@flow-state-dev/harness-manager(plus the existingharnessManageridentifier guard, if kept) may be enough and easier to keep aligned with the lab’s real harness surface (coder.mts). -
Reuse —
takesDelegatedPost/takesConversationTasksinworkforcealready encode delegate vs conversation-task shape, but they are not on the public package surface today, so the goal’s key-filter is understandable. Exporting a small test-facing helper (ortakesDelegatedPost) would be a follow-up, not a blocker for this PR. -
Fixture roster — Adding
general-leadandresearchertoorgWorkersis the minimal fix. Deriving wanted ids fromreadDeclaredRoster(you already use it in leg (g)) would reduce fixture/tree skew later, at the cost of the explicit anti-game roster the goal documents — I would not switch without a deliberate contract change. -
Copy — Signal #2 and the leg (b) evidence string still read like “no task entry but its delegated post,” which contradicts FIX-1872 (the EM does declare a task entry; the claim is only that one). Wording like “declares only
onDelegatedPost” would match the code. -
Evidence log — The 2026-10-13 row says manual red states were checked for a
workentry beside the post and aharness-managerimport.GOAL_CONTROLstill lists only the five perturbation controls — fine if those reds stay manual, but worth calling out so nobody assumes CI replays them.
Verdict
Comment, not blocking. The direction matches FIX-1966; merge is reasonable as-is. The sameSet tightening and harness-import simplification are the highest-value nits if you want one more pass before merge.
(Simplify automation — read-only review; no code pushed.)
Sent by Cursor Automation: Review For Best Approach
…IX-1966) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukfpBf4vLMrHcW584uZeF
There was a problem hiding this comment.
Code Snob — already tight. No POC.
Read goals/devforce-lab/it-wakes-the-seat-a-file-declared/fixtures/input.json, goal.md, run.mts (hired-list loop and the BR-4 block), and packages/shift-manager/teams/devteam/workforce/flows/workers/em.mts.
The hired-list check already spreads fixture.orgWorkers. general-lead and researcher are the same three-line kind entries as the coordinators already in that object.
DELEGATED_POST_ENTRY is the one string. otherEntries is the list the note prints. The assigned seat still calls entriesOf.
harnessManager and "@flow-state-dev/harness-manager" are different needles. The two notes are the two red states this PR records. No harness-package list exists in code to import; the four names are README prose. Inlining HARNESS_PACKAGES moves those four lines onto the filter.
The BR-4 quote had to change. The two sentences after it restate em.mts's header and the note; cutting them, and the one-line HARNESS_PACKAGES JSDoc, leaves the check the same length. The section banner still says the EM kind has no entry; rewriting that clause leaves the check the same length. Leg 2 in goal.md is the signal. The verdict row matches the longer red-state rows already in that table.
Left as recorded: the constant import, the kind pins in the fixture, both source notes, the package list as written.
Sent by Cursor Automation: Code Snob
|
@codex review |
There was a problem hiding this comment.
Code Snob — already tight. No POC. This note counts for 43488866. The earlier note described 014f0ca3e, which still filtered otherEntries.
Read goals/devforce-lab/it-wakes-the-seat-a-file-declared/fixtures/input.json, goal.md, run.mts (hired-list loop and the BR-4 block), and packages/shift-manager/teams/devteam/workforce/flows/workers/em.mts.
The hired-list check already spreads fixture.orgWorkers. general-lead and researcher are the same three-line kind entries as the coordinators already in that object.
sameSet(emEntries, [DELEGATED_POST_ENTRY]) is the comparison this file already uses for the hired list and the skill unions. emEntries is the list the note prints. The assigned seat still calls entriesOf. A filter of anything-but-the-post is the longer check, and it lets an empty list pass.
harnessManager and "@flow-state-dev/harness-manager" are different needles. The two notes are the two red states this PR records. No harness-package list exists in code to import; the four names are README prose. Inlining HARNESS_PACKAGES moves those four lines onto the filter.
The BR-4 quote had to change. The two sentences after it restate em.mts's header and the note; cutting them, and the one-line HARNESS_PACKAGES JSDoc, leaves the check the same length. The section banner still says the EM kind has no entry; rewriting that clause leaves the check the same length. Leg 2 in goal.md is the signal. The verdict row matches the longer red-state rows already in that table.
Left as recorded: the constant import, the kind pins in the fixture, sameSet on exactly that one entry, both source notes, the package list as written.
Sent by Cursor Automation: Code Snob
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4348886603
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…X-1966) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukfpBf4vLMrHcW584uZeF
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 53dd6b89-b6f7-4a0d-83ad-d0936ea12377) |


Requested by Jake · project thread
Before:
goals/devforce-lab/it-wakes-the-seat-a-file-declaredfails on main. It expects 7 workers but DevTeam now hires 9 (FIX-1920 added the org'sgeneral-leadandresearcher), and it refuseseng.em'sonDelegatedPosttask entry as "a route to a harness".After: the check passes. The worker list includes the general lead and researcher on
agent. The EM may declare its delegated post entry and nothing else as a task entry, andem.mtsmay not import a harness package.The delegated post entry is what FIX-1872 D1 gives the EM: it runs the EM's own turn, which files rows for other workers, so it dispatches rather than running a harness. The rule's intent (no coordinator runs a harness itself) is kept by refusing any other task entry and by the new import check, which covers a harness run from inside the post entry's turn.
Verification
7c9cc1bb: FAIL on the hired list and oneng.em declares task entries ["onDelegatedPost"].address-the-reviewer,no-commit,swap-documents,drop-own-skill,stopped-at-limit).em.mtsand reverted: aworktask entry beside the post entry fails witheng.em declares task entries ["work"] beside its delegated post; an@flow-state-dev/harness-managerimport fails withthe em kind's own file imports [...].Sibling work: #3291 (FIX-1964) removes
ops.oncall; whichever lands second drops it from this fixture'steamCoordinators. No changeset: goals are private.🤖 Generated with Claude Code
https://claude.ai/code/session_01TukfpBf4vLMrHcW584uZeF
Generated by Claude Code
Note
Low Risk
Changes are limited to a private goals fixture, runner assertions, and goal documentation; no production runtime behavior.
Overview
Updates the it-wakes-the-seat-a-file-declared DevForce lab so it matches current DevTeam roster and EM behavior (FIX-1966).
The fixture now expects org
general-leadandresearcheronagent, so leg (a)’s hired-worker list matches FIX-1920. Leg (b) no longer requireseng.emto declare zero task entries: it must declare only the delegated-post entry (DELEGATED_POST_ENTRY), reflecting FIX-1872 D1 (EM turn files rows; it does not run a coding harness).run.mtsenforces that withsameSet(emEntries, [DELEGATED_POST_ENTRY])and adds a source check thatem.mtsdoes not import harness packages (HARNESS_PACKAGES), so a harness cannot be wired in via imports even if the flow shape hides it.goal.mddocuments the revised signals and adds a 2026-10-13 verdict log row for main + FIX-1966.Reviewed by Cursor Bugbot for commit 29bd0e7. Configure here.