Repository navigation
spec(FIX-1903): end-state figure shows FSD holding the MCP connection with each person's key - #3448
Conversation
… with each person's own key The figure still put the run's credential in host config. Amendment #3179 settled that FSD holds the MCP connection and each person sets their own key on the Settings page; the row names a host alias only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PrPKdauAZJcDc2GUGxNKWS
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Second look / architecture pass: no changes requested.
Generated by Claude Code |
There was a problem hiding this comment.
Summary
This PR does the right thing at the right altitude: it corrects the end-state figure and alt text after the FIX-1905 review superseded “credential in host config” with endpoint in host config + per-person key on Settings + FSD holds the connection (ER-6 / EVOLUTION row on #3174). The OAuth fence rename (no Linear sign-in by OAuth) also lines up with the epic “Bigger” row and FIX-1905’s d4-whose-key flip condition better than “per-person Linear sign-in,” which read like in-scope sign-in.
I’m approving because the substance matches the locked rules; what’s left is figure/copy hygiene, not direction.
Simpler approach worth considering (not blocking)
The content fix is necessary; the shape of the fix may be heavier than the repo’s own layering pattern:
-
Epic end-state = panorama; FIX-1905
what-changes.svg+ ER-6 = credential mechanics. Other epics keep held boxes at ~3 sublines. Here the MCP box grew to five lines (+ taller rects) whiled4-read-at-run-start.svgand FIX-1905 already say “FSD connects; harness gets tools” and the two-input diagram (host config vs Settings). A cleaner change might replace the wrong “credential in host config” line with one merged line (e.g. alias on row · endpoint in host config · FSD connects with your Settings key) instead of appending a fifth line—same truth, less layout churn. -
Two long prose copies. Markdown
![…]alt and SVGaria-labelare both full essays and already diverge (NOT BUILT list, Layer 1, migration wording). Ongoing cost every time the figure moves. Simpler maintenance: short alt (“End-state: in the box, unchanged, replaced, not built”) and letaria-label(or<title>/<desc>) be canonical—or keep one list in sync, not two hand-edited narratives. -
Small clarity nits (if you touch the SVG again): “no key on it” → “on the row” (matches ER-6 / aria-label); unify “connected by FSD” (alt) vs “FSD connects” (visible) with D4’s active voice; optional alignment with SPEC line 31 parenthetical for OAuth (fence stays short; nuance in Bigger row).
What I’d skip
- Duplicating FIX-1905’s topology inside the epic end-state—that would be the approach that went too far.
- Third-party packages: N/A (spec SVG only).
Performance: N/A.
Sent by Cursor Automation: Review For Best Approach
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PrPKdauAZJcDc2GUGxNKWS
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |


Requested by Jake · project thread
Before: the FIX-1903 end-state figure (
specs/epics/FIX-1903/figures/end-state.svg) said a project's MCP endpoint and credential live in host config, and its "not built" fence listed "per-person Linear sign-in". Both contradict amendment #3179, which the #3179 Codex review flagged (P2).After: the figure matches D4 as amended. The row names a host alias only (no URL, no key), FSD connects for the run with the key each person sets on the Settings page, and the endpoint stays host config. The fence now says what is actually out of scope: Linear sign-in by OAuth.
How: one figure amendment from
main. The MCP box gains one line ("FSD connects with your key (Settings)") and grows 6px to fit. The aria-label and the figure's alt text inSPEC.mdsay the same thing. Rendered in light and dark themes and checked; no other text changed. No changeset (spec only).🤖 Generated with Claude Code
https://claude.ai/code/session_01PrPKdauAZJcDc2GUGxNKWS
Generated by Claude Code


Confidence Score: 5/5
This spec-only correction appears safe to merge.Summary
Updates the end-state figure to match the amended MCP design.
Reviews (1) · Last reviewed commit: "spec(FIX-1903): end-state figure shows F..." · Reviewed by Greptile