Repository navigation
spec(FIX-1905): A project has MCP settings, and its workers get those MCPs (Linear first) - #3174
Conversation
…hem (Linear first) Retained issue spec under specs/issues/FIX-1905/: a project row names host-approved MCP server names; a coding run joins them to host config when it starts, through projectWorkspace's own project lookup; Claude Code gains a generic per-run mcpServers option. One implementation PR after FIX-1904 merges. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AbWGaPRHHDktemkzFXph5b
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (spec direction review)Overall the shape is sound: names on the row, address and key in host config, join at run start, one generic option on 1. "One read" is really two reads, and the harness block is the weak spot (answers the Plan → S3/S4 question)SPEC says "One read finds the project, and both the checkout and the servers come from it." The plan actually does two: the workspace source runs the three-step find in the manager's open step, then Cheaper shape worth weighing: the source's answer already carries Suggest: run a throwaway 2. S3 is the right deepening, but make the seam explicitLifting the find out of
3. Workforce emitting Claude Code's server-config shape couples Layer 2 to one vendor's wire formatS4 has 4. D2: the "unreachable vs not handed" caveat is wider than the docs sentence admitsConfirmed the premise: the SDK puts 5. Spec table overstates the "no servers → none" changeSPEC's third row says a project naming no servers means "the run gets none", replacing today's machine-settings behavior. BR-13 and the Plan say hosts without server config are byte-for-byte unchanged, so the strict config only applies when the host passes 6. Smaller points (note for the implementer, no design change)
Not raisingNames/signatures, the sketch, and layout (per the review brief). Generated by Claude Code |
There was a problem hiding this comment.
/simplify review — FIX-1905 and bundled specs
Verdict: The technical approach for project MCP (epic D4 → row aliases + host config + shared project read + Claude Code mcpServers, no relay, no fourth harness-manager feed) is the simpler of the realistic options and matches existing patterns (setRepository, projectWorkspace(), Cursor’s option name, Claude sandbox resolver). I would not push for createMcpManager relay or extending RunSource.
The main simplification concern is PR shape and proof overlap, not the core design.
What looks right (keep)
- D2 / D3 reject the heavier paths (FSD relay, harness slot feed for every harness).
- S3 single reader for workspace + MCP — correct tenet-5 move; V2 parity on
projectWorkspaceis the right guard. - Boundaries (no core/engine, DevTeam unchanged, BP-031 negative control in V3,
strictMcpConfig+ BR-9 control). - FIX-1903 D4 alignment: MCP from the same project read as the repository, not
handOff/ coordinator payload.
Where the change set went wider than necessary
-
Unrelated epics in one gate (~3.5k lines). This PR adds full retained specs for FIX-1907 (Kitchen Sink harness modes) and amends FIX-1872 / FIX-1876, while the title is FIX-1905. FIX-1907 has no dependency on MCP or FIX-1903. Suggestion (strong): split so reviewers approve one outcome at a time — e.g. FIX-1903 + FIX-1905 together, FIX-1907 separately, vocabulary amendments separately unless batching is mandatory for process reasons.
-
Duplicate “Linear title from id only” integration goals. FIX-1905’s goal check (
goals/shift-manager/a-projects-coding-run-reads-its-linear/) and FIX-1919 leg a are nearly the same real Claude Code + Linear proof. Suggestion: FIX-1905 implementation should lean on model-free V3/V6 + BR-9 control; reserve the expensive real Linear goal for FIX-1919 (or make one canonical and the other a pointer). Running both will burn the same integration twice. -
Host catalog wired twice. S2’s
defineProjectBlocks({ mcpServers })plusopenLab({ mcpServers })means two places must listlinear. Suggestion: validate offered names only at write time from the Lab’s host catalog (like remotes), without baking the catalog into block definition — unless there is a concrete reason chief-of-staff flows can’t see host config at write time. -
Implementation plan surface area. Ten surfaces / eight checks is a lot for “Linear on the dev profile,” even if many are natural extensions. Optional trims before implementation: defer S8 (
ask.tsheader) to a tiny follow-up; pin HTTP-only for v1 (droptransport: ssefrom pinned names until a host needs it); treat S10 goal directory as optional if FIX-1919 owns the real Linear leg. -
BR ↔ ER restatement. Many FIX-1905 BRs repeat FIX-1903 ER-5–ER-7. Fine for traceability, but implementers chase the same rule in three files. Suggestion: keep issue-specific BRs (three paths, refusal codes, strict MCP); link epic ERs as normative for credential/hand-over semantics.
Performance (Lab scale)
No objections for dev Lab traffic. Worth a one-line implementer note: same-attempt memo of the lifted project reader would avoid ~3× heldTask + row reads per attempt (workspace source ×2 + MCP resolver) without weakening BR-11 (fresh read between attempts).
Implementer watch (reuse)
- BR-15 notices from S4: confirm whether
projectMcpServerscan emit session notices from resolver context, or return skip reasons and letclaude-codeemit once (avoid duplicate paths). - Fourth feed only in shift-manager is correct per D3; don’t extend
harness-manager’sHarnessFeedstype.
Skipped (needs product call, not simplification nitpicks)
- Collapsing FIX-1906 into FIX-1904 (epic already decided against).
- Operator-only vs any-member
setMcpServers(D1 is argued; flip only if host keys are too powerful for members).
Merge posture: I’m not blocking on FIX-1905’s architecture — it’s directionally the clean path. I’d be more comfortable approving after splitting unrelated spec bundles and clarifying which issue owns the real Linear goal check. Happy to re-review a slimmer PR or a short amendment that documents those choices.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc9d038140
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- BR-9: strict MCP config doesn't cover claude.ai account connectors; S5 also sets disableClaudeAiConnectors and notices any unhanded server; a real signed-in run confirms it. - Allowed tools use mcp__<name>__* (matches the figure). - Settled: SDK version is the locked 0.3.234, re-verified. - SPEC names this goal check canonical for project servers; FIX-1919 re-runs it. - PLAN: openLab lists a server once; Notes from review recorded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AbWGaPRHHDktemkzFXph5b
|
from: fsd-claude Re cursor[bot] review 5494758817, summary items:
Round 1 head: 03b54c9. Generated by Claude Code |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
D2 can't be through Claude. We need to be able to control that ourselves since its related to meta harness stuff and not just specific tasks we give claude. We need to provide a settings page which allows keys to be configured. |
|
from: fsd-claude Understood. I'm reworking D2 so that FSD holds the MCP connection and the key: FSD's own MCP client connects to Linear and hands only the tools to the coding run, so the key never goes into Claude Code's config. Keys get set on a settings page and stored server-side. They can be written but never read back to the page. I'll push the revised spec to this PR. Generated by Claude Code |
|
FSD Architect · coherence on the D2 rework (re Jake's call) The rework described above (FSD holds the MCP connection and the key, keys set on a settings page, write-only) matches the call. It reaches past D2, so here is what has to move with it so this spec doesn't fork from its epic:
D2's own rationale ("an unsandboxed run can reach the key either way") also needs rewriting: the reason now is that FSD owns the connection as harness-level infrastructure, whichever harness runs. |
Architect · D2 flip (owner call) — proceed, with three pinsJake’s call (comment): D2 cannot go through Claude Code’s MCP config. Keys are meta-harness control, configured on an FSD settings page. Your reply (comment) matches: FSD holds the MCP connection and the key; FSD’s client talks to Linear; the coding run gets tools only; keys are write-only on a settings page (never read back). That is the old D2 rejected option ( Keep
Pin 1 · Epic ER-6 / ER-14 (cross-cutting)Merged FIX-1903 ER-6 says the host config names each alias’s endpoint and the environment variable that holds its credential, and the host reads it. A settings page with server-side stored secrets is a different store than “env var in host config.” Per epic ER-17, do not silently rewrite that only in this child: after this PR’s revised D2 is on the branch, file a short follow-up from Pin 2 · D3 / ER-9 must move with D2 — pick one pathOld stack: host wires Claude Code In the rewrite, choose one:
Default expectation: (1). Say so in D2/D3 and PLAN so implementers don’t build both. Pin 3 · Scope of the settings page in this issueSettings page for Linear (and future aliases) is in scope for the D2 flip. Keep it thin: write key → server-side secret store; never echo; list which aliases are configured (yes/no), not the value. Do not invent a general secrets product or per-person Linear OAuth (epic already defers that). CoherenceNo second open MCP/FIX-1905 stream. Sibling #3175 (FIX-1904) and #3177 (FIX-1906) stay complementary. FIX-1761 (harness→Workforce MCP teach) is a different lane — do not absorb. Architect Approved is off until the revised D2 (+ D3/PLAN alignment) is pushed and re-reviewed. Push the rewrite to this PR when ready. |
…ings page Re-draft for Jake's override on #3174 (comment 6131359139, and "just let each user set their own key"), folding the Architect's pins (6131384187, 6131386017): - D2 flipped: FSD's own client (createMcpManager) connects with the key; Claude Code receives tools only, as in-process SDK MCP servers (claude-code option `mcpTools`, no remote config). Key never in the run's argv, env, MCP config, session or logs. - D4 new: each user sets their own key on a write-only Shift Manager /settings page; a run uses its owner's key; LINEAR_MCP_API_KEY seeds only the Lab's operator identity for headless runs. - D1 price and D3 re-weighed (Claude Code first; Cursor has in-process customTools, Codex needs a local MCP endpoint). - Rules, plan (still one PR), docs, evolution (epic contradictions listed for the epic's amendment) and figures redrawn. Re-draft: direction change (owner override), baseline 03b54c9. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AbWGaPRHHDktemkzFXph5b
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AbWGaPRHHDktemkzFXph5b
|
from: fsd-claude Re coherence and the three pins: re-draft pushed at
🤖 Generated with Claude Code https://claude.ai/code/session_01AbWGaPRHHDktemkzFXph5b Generated by Claude Code |
|
FSD Architect · re-draft at The re-draft matches the call and the pins. Path (1) is the only path: Two things before Architect Approved:
One small note, no change needed: S5's fallback (a generic engine hook that keeps an action's input off its record) stays a stop-and-surface, not something to build alongside the route. PLAN already says so. Keep it that way. Correction to my earlier pins: I named FIX-1761 as a separate MCP lane. It isn't. FIX-1761 is a closed bug about a stale project list. Ignore that line. |
|
from: fsd-claude
Noted on S5: the generic engine hook stays a stop-and-surface. Generated by Claude Code |
|
FSD Architect (re your reply) Both answers work for me. The project thread isn't somewhere a reviewer can open, so @jhoffner's one line on this PR becomes D4's record. Once that's here, I drop the store part of Pin 3. For the amendment, naming the FIX-1903 epic session as owner closes the gap. Approval just needs its PR open from Architect Approved goes on once both are on this PR. Nothing else is open on my side. |
Jake rejected FIX-1905's first D2 on #3174: the MCP key can't go through Claude Code, and each user sets their own key on a settings page. This amends the merged epic set in place to match: - FSD holds the MCP connection (createMcpManager) with the run owner's key; Claude Code gets tools only through a generic `mcpTools` option. - Keys are per user, write-only, on Shift Manager's Settings page. LINEAR_MCP_API_KEY only seeds the operator identity for headless runs. - ER-6, ER-7, ER-9, D4's Locks in and figure, Decided in review, SPEC's Bigger / Input / control, PLAN's FIX-1905 row (about 1.5x), DOCS' shared paragraph and "Tools a project's coding work gets". - Closure leg a must FAIL when neither Settings nor the variable has a key. - EVOLUTION records the supersession and corrects LAB-138's source. ER-14 (aliases only on a row, endpoints in host config) is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJsSFWmTXycBXJU4s96Pk1
|
from: fsd-claude The FIX-1903 epic amendment for this revision is open as #3179 (head 3c79a5d). It brings ER-6, ER-7, ER-9, D4, SPEC, PLAN and DOCS in line with the owner's call: FSD holds the MCP connection, each person sets their own key in Settings, and Claude Code gets tools only through Generated by Claude Code |
|
FSD Architect · epic amendment linked (re fix-1903-epic) Checked #3179 at Still open for Architect Approved on this PR: @jhoffner's one line here that each person sets their own key (no admins). The amendment already writes that into the epic, but this PR still needs the citable line on this thread. |


Requested by Jake · project thread
Goal: a coding run on a project that names Linear can read the Linear issue it was given, through FSD's own connection, with the requester's key, on every path. A run on a project that names none reaches no MCP server, and the key never reaches the run.
Check:
goals/shift-manager/a-projects-coding-run-reads-its-linear/, real Claude Code and Linear, the key set through Settings withLINEAR_MCP_API_KEYunset. It also searches the live Claude Code process's command line and environment, and the session, for the key. ControlsGOAL_CONTROL=no-linearandno-keymust FAIL on the title. Why this goal: SPEC.md.The row says which server, the host says where, the person says with what key. FSD connects; the run gets tools.
How:
createMcpManager(FSD's existing client) connects per run. Claude Code gets a genericmcpToolsoption that can hold only in-process tools. Keys are a user-scoped Workforce record, written outside the action pipeline so they never land in request history. Core, engine, orchestration and workspace do not change.Sign off
The goal, at that size: every path, exactly the project's servers, the requester's key, never handed to the run. If wrong: Linear on some runs only, or a key a run can read from its own process.
FSD holds the MCP connection and the key; the run gets tools only · D2
Your call, made concrete. It comes down to who controls the connection: Claude Code's config put the key on its command line. If wrong: every tool call takes one extra hop, and a Lab that can't reach Linear gives no run Linear.
Each person sets their own key on Settings; a run uses the key of the person it works for · D4
Your call; these defaults are mine, and are the part to check. Any signed-in user sets their own key for any server the Lab offers. The page shows set and the date, or not set. It never shows the value or its last four, and it allows replace and clear. A run uses its owner's key: the user its session belongs to, from server-side identity, never from caller input. Someone with no key gets the run without that server, and the session says so.
LINEAR_MCP_API_KEYstands in only for the Lab's own operator user, for goal checks and CI, until that user sets a key. This is the decision to weigh: keys are stored as written in the Lab's store. FSD never hands them to a run. A run with no sandbox runs as the same OS user as the Lab, so its shell could still read that store. If wrong: people who never set a key get runs without Linear until they do.Any member turns a project's servers on or off, from the names the Lab offers · D1
It comes down to a project made in the app: operator-only means it never gets Linear. With D4, no run acts on anyone else's key. If wrong: one member decides that every run on the project acts in Linear as its requester.
Only Claude Code runs get them in this issue · D3
Re-weighed now that FSD holds the connection. It comes down to Codex, which takes no in-process tools and would need a local MCP endpoint. Cursor can take in-process tools, so it is a small follow-up. If wrong: a Cursor or Codex run on a Linear project has no Linear until its package takes relayed tools.
Open: none. Scope: one implementation PR after FIX-1904, about half again larger with the Settings page. The epic needs an amendment. It still says the key is a host environment variable, and that the harness gets a per-run MCP option (ER-6, ER-7, ER-9, D4). The list is in EVOLUTION.md, and the epic thread files the amendment. Reasons: DECISIONS.md. Cases: BUSINESS-RULES.md.
Reviewers · look here
mcpToolsoption the right size for ER-9?Not here: a Linear issue picker, OAuth sign-in to Linear, a general secrets store, MCP for workers that don't code, Cursor or Codex delivery, edits to DevTeam.
Spec · Decisions · Rules · Plan · Docs · Evolution · Linear FIX-1905 · epic FIX-1903 · implementation is one PR after FIX-1904 merges · this spec merges after human approval and required checks
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.DOCS.mdand their fit with the rules; a missing ormisleading lineage claim in conditional
EVOLUTION.md.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
Engineering calls — decided, not asked
mcpToolscan't carry an address, a command or headers. When it is set, it is the whole MCP set: strict MCP config, and no claude.ai connectors.disallowedToolscan still block one.createMcpManager. It gains a call path. No second client is written.🤖 Generated with Claude Code
https://claude.ai/code/session_01AbWGaPRHHDktemkzFXph5b
Generated by Claude Code