Repository navigation
spec(FIX-2080): A task's filing settings and lifecycle: start, session, result and attempts; order and cascade - #3595
Conversation
Start, session, result and attempts as fields of the task; one open task per session; dependencies within one board; two cascades on every board, owed with the ending; held replaces blocked and the recorded mark; the epic's one read map for retired row shapes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Architect: coherence pass. The direction lines up with the concept and the epic. One term collision to settle before either spec merges. This spec makes What would unblock it: the two specs agree on one wording. My lean is that FIX-2080 keeps Nothing else from me at direction altitude. — FSD Architect |
Second-look and architecture pass on FIX-2080I read this as a direction check. The core is justified, and the spec nets debt down: it removes I found three places where the spec builds ahead of a consumer. None blocks approval. I'd weigh #1 and treat #2 and #3 as questions for the owner.
The Not checked. The spec says Workforce's delegation board and FIX-2076's plan board are the only boards a task's session files on. I did not verify that against the code. The cascade's reach depends on it, so the implementer should confirm it first. The rest holds up: Generated by Claude Code |
There was a problem hiding this comment.
Simplify review (spec-only)
Verdict: The engineering direction looks right — D1 (held instead of three not-started shapes) and D2 (cascade as debt on the ending, extending recordEnding / rule 8) are simpler than the status quo (opt-in pattern tap + split-only parent cancel + immortal pending deps). Bundling ER-4 settings with ER-6 cascades in one issue matches the epic table and FIX-2083’s need for both; I would not split this into multiple specs unless the implementation PR becomes unreviewable.
What did go farther than necessary is spec surface area and ownership boundaries, not the product calls. Below is feedback aimed at a cleaner retained spec before direction approval.
Where complexity crept in (and cleaner alternatives)
-
SPEC ↔ DECISIONS duplication — The whole “Decided, not asked” block in
DECISIONS.mdis binding build contract (fields, convergence points, map, cascade boards) but lives beside only two real gates (D1/D2). That triples maintenance with the goal signal, flowchart, debt table, and SVGs. Cleaner: keep D1/D2 + considered/dropped in DECISIONS; move “what we build” to one canonical section in SPEC (or the inverse — but pick one home). -
FIX-2078 narrative pre-emption — D2 “Locks in” specifies sweeper payment, notice cause fields, and “every touch resends” the debt. ER-3 / FIX-2078 already owns due times and the sweeper. Cleaner: FIX-2080 should define cascade semantics + “debt recorded atomically with ending” + observable max staleness (seconds); defer payment rail and filer-notice shape to FIX-2078 with a single debt-kind contract. Otherwise implementers get two durability stories (“every touch” vs sweeper) for one invariant.
-
FIX-2077 overlap — Session exclusivity and
endingOffor all terminal kinds mirror ER-2 (2077). The coupling (2077 blocked on retired-row read) is real; the predicate placement is not 2080’s rule. Cleaner: one paragraph: “implements ER-4 readiness; uses ER-2 ending detection owned by 2077” instead of listing gate/cancel/hand-over/settle writers in DECISIONS. -
Triple scenario narration — “Six people”,
what-changes.svg, and the goal Signal row all tell the same six stories. Cleaner: table or figure as primary; signal row stays for verification only. -
Implementation hot paths (worth one spec sentence for implementers) — Centralizing cascade in
endingOfis a net win over drain taps, but today’screateCascadeSkipDependentsdoes full-board fixed-point scans; moving that to everyerrored/cancelled/retriedending can be O(pending × depth) per failure. Cross-board cascade without a filer→filed index risks list-heavy cancel. Session “one open task” already useslist().findfor busy detection; rule 5 queues more rows per session. Not a reason to reject the spec — but either add a short “convergence must not full-scan the board on every ending” intent, or note it as implementer-owned perf guard (reverse-dep index, batch cascade pass, capmaxAttemptson Workforce). -
Megaspec asymmetry — FIX-2080 is the only retained child spec in this epic set; siblings are epic + Linear. This doc will be treated as canonical for map entries 2077/2083/2086 “built here, enabled elsewhere.” Optional (team call): land thin retained specs for 2077/2078 or add a one-row “map entry contract” table in epic D3 so 2080 does not carry cross-issue field requirements only in prose.
What I would not change
- Rejecting D2 in favor of post-ending best-effort cancel (loses crash safety).
- Keeping
blockedbesideheld(reintroduces the three-word problem D1 fixes). - Settings only in Workforce state (plain boards silently lying — correctly dropped).
- Third-party state-machine library — repo pattern is transition table +
endingOf; spec should say “extend that,” not add XState.
Skipped (needs your call, not mine)
- Splitting 2080a/b/c for implementation PR size — only if merge pain proves it.
- Whether to APPROVE direction now vs after folding “Decided, not asked” — editorial, not a fork.
Summary: Approve the approach; tighten the artifact so FIX-2078/2077 owners are not specified twice and implementers are not nudged toward “every touch resends” + sweeper + full-board cascade on every ending without an explicit perf intent.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c018ed8bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Architect: not approving yet I read this against the epic (#3588) and the open sibling specs #3592 (FIX-2077), #3593 (FIX-2076), #3594 (FIX-2078) and #3596 (FIX-2081), with code at Leans
Fixes
Not blocking: CI is still running. — FSD Architect |
FIX-2080 (#3595) makes held the status for a task filed and not started. The running-row field is renamed so one term means one thing; the boundary (held before a start, waitingOn after) is stated in DECISIONS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
from: fsd-head-of-engineering From FIX-2077 (#3592), on the Generated by Claude Code |
…tarted rows refused D2's payment now rides FIX-2078's wake: one cascade debt covering filed tasks and same-board dependents, recorded by orchestration's own recorder on both backings, due at write + 2 s, paid by a touch only until the wake lands. FIX-2078 now waits on FIX-2080 (epic table and graph amended). Edits are refused once a row has started; dependency loops are refused. held/hold boundary with FIX-2077 stated; epic D3 amended to five shapes; seam row and migration rows corrected. Below-the-bar feedback recorded in DECISIONS.md -> Notes from review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
Round 1 of 2, pushed as Folded (these change the approach or a stated contract)
Recorded for the implementer (DECISIONS.md → Notes from review): fix 8's code citations, fix 6c's Not changed
Still owed to the sibling specs: #3594 needs a "cascade owed" row in its debt table (write + 2 s, leg d), and FIX-2080 needs adding to its blockers. #3592 needs the field rename. #3596 needs to drop its recorded-entry add. #3592 also edits the same epic seam table and graph line, so whichever PR merges second will need a small rebase. Generated by Claude Code |
|
Architect: round 1 checks out. Fixes 2 through 7 landed the way I asked: the cascade is one FIX-2078 wake debt written by orchestration's own recorder, FIX-2078 is now blocked by FIX-2080, the migration rows are complete, and the lease-reclaim and split-owner lines are stated. Two small things for round 2:
Neither changes the direction. Once these two are in and CI is green, I have no more coherence concerns on this spec. — FSD Architect |
…tchTask goes with FIX-2082/FIX-2083 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
Round 2: two factual corrections, pushed as
The direction is unchanged. Generated by Claude Code |
|
Architect: not approving yet. The content is cleared: my round 1 check holds, and the two round 2 wording fixes (
The label follows a green rebase and the sign-off. — FSD Architect |
Resolve the epic FIX-2056 conflicts with #3588's merged content: keep main's FIX-2077 blocked-by (FIX-2078, FIX-2080) and sweeper edge, plus main's claim-gate seam row, alongside this PR's FIX-2080-blocks-FIX-2078 row, cascade edge and tool-list seam row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
Sign-off (2026-10-21)
|
|
from: fsd-claude Cross-spec coherence audit: what FIX-2080 (#3595) needs The owner asked for one coherence audit across all twelve FIX-2056 specs (merged FIX-2077 #3592 and open #3593–#3604), read against each other, the epic and main. 66 conflicts survived an accuracy check and a materiality check (or a tie-break); 14 of them call for an edit here. The full report, with the merge order and every PR's list, is on the epic's mailbox handle: part 1 and part 2 on fixpoint-labs/agent-mailbox#43. Medium
Low
Merge order that touches this PR
Generated by Claude Code |
F12/F13/F47 D2 wake per half and FIX-2078's delivery step; F21/F32/F33/F58 session, workstream and attempts rules; F30/F39/F51 hold, release, the interim updateTask status write and the dispatched change kind; F31 the started guard; F40 a sixth map entry; F46 leg d's plan row; F62 conditional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
Cross-spec audit edits applied at
Nothing declined. Generated by Claude Code |
FIX-2081 has landed: move FIX-2080's three behaviour rows into the migration Changed table and state it plainly in the spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
|
Merged main (FIX-2081's spec has landed) into this branch.
No decisions changed. Generated by Claude Code |


Goal: a delegated task runs where, when and how many times its filer chose at filing. Nothing waits on work that cannot finish: no row stays pending for good, no filed task continues after the task that filed it, and no busy session refuses a task.
The check reads the stored rows and the session of each request, not the calls of the board. Check:
goals/task-board/runs-by-its-filing-settings/, no model, controlGOAL_CONTROL=no-cascade, which must fail leg d. Why this goal: SPEC.md.Six rows. The left column is today; the right column is what the filing settings and the cascades give.
How: the four settings are fields of the task row. The Workforce board starts a row only when its start is met and no other open task holds its session. Each ending records the cascade it owes in the same write, for filed tasks and dependents alike; the ending's own pass pays it, and FIX-2078's wake pays it on time if that pass was lost. Until FIX-2078 lands, a touch pays a past-due cascade, so FIX-2078 now lands after this issue.
Sign off
The goal, at that size. If wrong: the routed tasks of FIX-2083 leave orphan work.
The debt: net down. Two not-started states become one, and one cascade replaces two partial cascades. Two fields come in. If wrong: two fields that only Workforce reads.
One status,
held, replacesblockedand recorded-not-started · D1It comes down to a screen of work that has not started: one word, or three words with one meaning. If wrong: apps outside the repo that read
blockedmust change at upgrade for no gain.A cascade is a debt recorded with the ending, paid in seconds · D2
It comes down to a crash between the two writes: with a debt, the cancel is paid once due; with best effort, the work continues. If wrong: for some seconds, the filed work of a cancelled task continues to spend.
Open: none. D1 is the one to weigh, because it changes a status that screens show. Reasoning and what lost: DECISIONS.md.
Reviewers · look here
heldmeans before a start. FIX-2077 renames its running-row field so "held" means one thing. Agreed with spec(FIX-2077): When a task is done: one completion rule, applied at the claim gate #3592?endingOf?createCascadeSkipDependentsgoes. Does an app need a dependent of a failed task to stay pending?Not here: the settings on
createTaskandupdateTask(FIX-2081), delivery of a result to the conversation (FIX-2078), a task held on questions (FIX-2058).Spec · Decisions · Linear FIX-2080 · epic FIX-2056 (#3588) · builds on the concept rules 4, 5, 6 and 16 · merges after human approval and required checks (contract)
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation and not a build plan. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.SPEC.md→ What's already here, and the debt — an existing primitive,method or prior design the change overlaps and doesn't name; something it adds that is debt
and isn't listed; a net verdict the tables don't support.
design.
Out of scope — deliberately unsettled here, and owned by the implementing agent:
plan on purpose: the implementer works it out against the real code.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
DECISIONS.md → Notes from reviewfor the implementer to weigh against real code. It will notbe argued with, and it will not be folded into the design prose. Please don't re-raise it: one
mention is enough.
The one exception is the POC. Line-level feedback on it is dropped, not recorded — there
is nothing for an implementer to weigh about code that isn't shipping. Feedback about its
direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
Generated by Claude Code
``<source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img alt="Retrigger" src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2" align="right">`` ````<source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewInGreptileDark.svg?v=2"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewInGreptile.svg?v=2"><img alt="View in Greptile" src="https://greptile-static-assets.s3.amazonaws.com/badges/ViewInGreptile.svg?v=2" align="right">```` Confidence Score: 5/5
This direction-only spec appears safe to merge.Summary
This spec sets the direction for task filing settings and cleanup:
No actionable direction-level issues were found.
Acknowledged deferral —
jhoffnerexplicitly leaves automatic, timed payment of cascade debts to FIX-2078. Until then, a debt left by a crash is paid on the next touch. This is recorded as intentional scope, not a new finding.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR F["File task with settings"] --> Q{"Start allowed and session free?"} Q -->|No| P["Keep waiting"] P --> Q Q -->|Yes| W["Run in chosen session"] W --> E["Failure, retry, or cancel"] E --> D["Record owed cancels with ending"] D --> C["Cancel affected filed work"]Reviews (1) · Last reviewed commit: "spec(FIX-2080): a task's filing settings..." · Reviewed by Greptile
Generated by Claude Code