Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions specs/epics/FIX-2056/DECISIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ It comes down to the cycle: a child blocked by FIX-2058 would keep this epic fro
|---|---|
| **Instead of** | Extending the durable keys' accepted cost (no second spelling read) to the task rows this epic retires |
| **Because** | BP-030. The rows are a user's open work in a persistent store; dropping them loses work a person filed. The durable keys are replay detail the owner accepted losing |
| **Locks in** | One map in the collection layer, built and tested by FIX-2080 for all four shapes: a post to a routed task, blocked to held, a parked split to running, a reopened row to pending. FIX-2077, FIX-2083 and FIX-2086 each turn their shape's entry on in the PR that stops writing it, and build no read of their own. The map is removed no earlier than FIX-2071 |
| **Locks in** | One map in the collection layer, built and tested by FIX-2080 for all six shapes: a post to a routed task, blocked to held, the recorded-not-started mark to held, a parked split to running, a reopened row to pending, a row parked for a turn to pending. FIX-2077, FIX-2083 and FIX-2086 each turn their shape's entry on in the PR that stops writing it, and build no read of their own. The map is removed no earlier than FIX-2071 |

**What would change my mind:** no persistent store outside tests and local dev databases holds
these rows. Then the map is dead code, and the durable keys' rule covers rows too.
Expand Down Expand Up @@ -89,11 +89,11 @@ FIX-2081's own scope.

| Seam | Owner, then who else touches it |
|---|---|
| The task tool list (`orchestration/src/skills/task-tools-capability.ts`) | FIX-2081 owns the list and field rules. FIX-2080's settings, FIX-2082's wait and FIX-2086's `message` land after it |
| The task tool list (`orchestration/src/skills/task-tools-capability.ts`) | FIX-2080 lands first: it removes `blockTask`, adds `status` (held or pending) to `updateTask`'s patch, turns the busy-session refusal into a wait and adds `held` to the status filter. Then FIX-2081 owns the list and field rules, and FIX-2082's wait and FIX-2086's `message` land after it |
| Who a filing can reach (`workforce/src/conversation-board/board.ts`, `reach()`) | FIX-2081 replaces a task session's roster arm with the self-step grant, after FIX-2076's plan rows land, so a worker files its own steps with or without delegates |
| The claim gate (`task-board/task-entry.ts`, `blocks/record-result.ts`) and the request's end | FIX-2077 owns the predicate and where it runs: after the engine's last drain on every terminal path, which follows `onFinished` (`engine/src/execution/runAction.ts:2447`→`:2630`→`:2641`, `:2773`→`:2918`→`:2936`), through an engine seam for framework packages, not an author hook. FIX-2082's waits wake on its ending; FIX-2078 calls it when a filed task ends |
| The wait (`tasks/helpers/wait-for-response.ts`) and its limits | FIX-2082 owns it and its limits: 5 waits deep; a tree 5 deep, 100 under its top task. FIX-2076 only sets which boards wait. A board's dispatch rides the row's wait. A bare `dispatcher({ wait: true })` has no row, and the engine awaits acceptance only (`core/src/blocks/dispatcher.ts:169-171`, `engine/src/context/dispatch-operation.ts:273-280`): FIX-2082 adds an engine wait that returns the result |
| The sweeper (`engine/src/durability/durability-sweeper.ts:40-50`), re-armed only from wait gates | FIX-2078 adds a due-time source the re-arm reads and a step that pays board debts |
| The sweeper (`engine/src/durability/durability-sweeper.ts:40-50`), re-armed only from wait gates | FIX-2078 adds a due-time source the re-arm reads and a step that pays board debts, FIX-2080's cascade debt among them |
| `afterRun`, the notice and `runTaskBoard` (`workforce/src/conversation-board/board.ts`) | FIX-2078 moves the notice, replaces resends with due times, removes the `reportOwed` marker and keeps Shift Manager's error route on the ending path ([f](#f)); FIX-2077 removes the split settle; FIX-2084 renames the entry `dispatch` |
| The collection read (`tasks/collection/`) | FIX-2080 owns the map; the retiring children turn entries on |
| Queued messages | FIX-2077 runs them through today's message entry; FIX-2070 makes it `receive` |
Expand Down
7 changes: 4 additions & 3 deletions specs/epics/FIX-2056/SPEC.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ The reviewed snapshot; live state, and each issue's gap rows, are in Linear.
|---|---|---|
| [FIX-2076](https://linear.app/fixpoint-labs/issue/FIX-2076) · board modes | Plan and delegation boards; wrong boards refused | — |
| [FIX-2077](https://linear.app/fixpoint-labs/issue/FIX-2077) · when a task is done | Rule 6 at the claim gate, after background work; a wait leaves a task running | FIX-2078, FIX-2080, FIX-2081 |
| [FIX-2078](https://linear.app/fixpoint-labs/issue/FIX-2078) · endings and debts | Every ending to its filer once; due times and the sweeper | — |
| [FIX-2078](https://linear.app/fixpoint-labs/issue/FIX-2078) · endings and debts | Every ending to its filer once; due times and the sweeper | FIX-2080 |
| [FIX-2080](https://linear.app/fixpoint-labs/issue/FIX-2080) · filing settings | Start, session, result, attempts; cascades; the one read for retired rows ([D3](DECISIONS.md#d3)) | — |
| [FIX-2081](https://linear.app/fixpoint-labs/issue/FIX-2081) · five tools | Five task tools, one rule per field; delegates as authority | FIX-2076, FIX-2080 |
| [FIX-2082](https://linear.app/fixpoint-labs/issue/FIX-2082) · waits | `getTask` and the waited dispatch as one wait; 5 deep, 100 under a top task | FIX-2076, FIX-2077, FIX-2081 |
Expand Down Expand Up @@ -100,14 +100,15 @@ flowchart LR
T -->|"updateTask"| S
T -->|"createTask, delegates"| R["FIX-2083 · routed tasks"]
L -->|"session, result, attempts"| R
E["FIX-2078 · endings and debts"] -->|"the sweeper recovers a lost wait"| B
L -->|"dependents cancelled, with their cause"| E["FIX-2078 · endings and debts"]
E -->|"the sweeper recovers a lost wait"| B
E -->|"result to the conversation"| R
R -->|"no post entry"| K["FIX-2084 · worker contract"]
E -->|"onTaskSettled, dispatch"| K
H["FIX-2085 · schedules"]
```

An edge is what one issue hands the next. FIX-2076, FIX-2078, FIX-2080 and FIX-2085 start at once;
An edge is what one issue hands the next. FIX-2076, FIX-2080 and FIX-2085 start at once;
every child blocks the closure, left off. The longest chain is four.

## What stays as it is
Expand Down
4 changes: 2 additions & 2 deletions specs/epics/FIX-2056/figures/d3-read-old-rows.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 12 additions & 3 deletions specs/epics/FIX-2056/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ repo rewrite at upgrade. Each tool's `<tool>_tasks` action follows its tool. Shi
| `assignTask` | `assignee` at filing, or `updateTask({ assignee })` before it starts | FIX-2081 |
| `cancelTask` | `updateTask({ status: "cancelled" })` | FIX-2081 |
| `completeTask`, `failTask` | Return or throw: the claim gate records the ending | FIX-2081 |
| `blockTask`, `TaskCollection.block`, `unblock` | `updateTask({ status: "held" })` and `"pending"` before it starts; `waitForUser` after | FIX-2080 |
| `blockTask` | `updateTask({ taskId, patch: { status: "held" } })` and `"pending"` before it starts (flattened by FIX-2081); `waitForUser` after | FIX-2080 |
| `TaskCollection.block`, `unblock` | `TaskCollection.hold`, `release` | FIX-2080 |
| The `"blocked"` task status, and `"blocked"` in `listTasks`' status filter | `"held"` | FIX-2080 |
| `Task.undispatched`, `TaskInit.undispatched` | `held` | FIX-2080 |
| Change kinds `blocked`, `unblocked` | `held`, `released` | FIX-2080 |
| Change kind `dispatched` | `released`: every release of a held row emits it | FIX-2080 |
| The board's `counts.blocked` | `counts.held` | FIX-2080 |
| `createCascadeSkipDependents` | Nothing: every board cancels a failed or cancelled row's dependents | FIX-2080 |
| `TaskCollection.reopen` | A follow-up: `createTask` in the task's session | FIX-2086 |
| `DELEGATED_POST_ENTRY` | A routed task through `WORKER_TASK_ENTRY` | FIX-2083 |
| `settleSplitTask` | Nothing: a split task stays running, and the claim gate settles it when a request for it ends with no piece open | FIX-2077 |
Expand All @@ -28,10 +35,12 @@ repo rewrite at upgrade. Each tool's `<tool>_tasks` action follows its tool. Shi
| The agent worker's `run` entry | `respond` | FIX-2084 |

Behaviour that changes without a removed name, carried by the owner's changeset the same way.
Behaviour lines live here, not in the table above: whichever of FIX-2080 and FIX-2081 merges
second moves FIX-2080's behaviour rows into this table.
Behaviour lines live here, not in the table above.

| Changed | Now | Owner |
|---|---|---|
| `updateTask` on a started or finished task | Refused, naming the field and the state; a started task takes only a cancel, and a message steer once FIX-2086 lands | FIX-2081 |
| Reassigning a running task | Refused: cancel it and file it again | FIX-2081 |
| A follow-up into a busy session being refused | It waits, then starts in that session when the open task ends | FIX-2080 |
| A dependency on another board, waiting for good | Refused at filing: cross boards with a wait or a held task | FIX-2080 |
| Plan-and-execute and supervisor cascading only a failed step | A cancelled step's dependents are cancelled too, with the same `skipped` label | FIX-2080 |
Loading
Loading