Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3d7effe
test(FIX-2087): the closure's goal and the task-surface sweep in CI
claude Oct 23, 2026
63da04f
test(FIX-2087): the closure's first verdicts
claude Oct 23, 2026
f6d06f1
test(FIX-2087): the sweep reads tools and endings by symbol; controls…
claude Oct 23, 2026
b6f75bf
test(FIX-2087): a forwarder exempts only its forwarding; every block …
claude Oct 23, 2026
fdb18c5
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude Oct 23, 2026
b76f76b
test(FIX-2087): j1 counts only notice requests that ran a turn; j1:he…
claude Oct 23, 2026
e7c24c7
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude Oct 23, 2026
7e07954
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude Oct 23, 2026
deaccbd
test(FIX-2087): row 3 grades the closure's own findings
claude Oct 23, 2026
1ba899d
test(FIX-2087): classify the closure goal in FIX-1792's census
claude Oct 23, 2026
89217e4
test(FIX-2087): the closure's verdict on main with every closure fix …
claude Oct 23, 2026
024a259
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude Oct 23, 2026
5e5ee0e
test(FIX-2087): row 3 grades FIX-2123, FIX-2135 and FIX-2136
claude Oct 23, 2026
455b3fb
test(FIX-2087): a hearing is a notice admitted, not a request started
claude Oct 23, 2026
1defdcc
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude Oct 23, 2026
e51ac8b
test(FIX-2087): row 3 runs FIX-2138's regression test
claude Oct 23, 2026
cde0a95
test(FIX-2087): round 3's verdicts
claude Oct 23, 2026
46a6629
Merge origin/main into fix/FIX-2087
claude Oct 23, 2026
4ec08e6
test(goals): grade FIX-2147, FIX-2149 and FIX-2150 in the closure's r…
claude Oct 23, 2026
8a5ed55
refactor(goals): fold the shorter one-task notes from #3790 (083cef8a…
claude Oct 23, 2026
77dd49e
fix(goals): the closure fails closed, and grades a word-for-word foll…
claude Oct 23, 2026
683c151
fix(goals): every control's tags must go red, and the door rule reads…
claude Oct 23, 2026
9a35628
fix(goals): read a control's red from its tagged failures, and bring …
claude Oct 24, 2026
b6516a8
docs(goals): the closure's goal states how a control is read and what…
claude Oct 24, 2026
eb33735
docs(goals): round 4's verdicts in the closure's log (FIX-2087)
claude Oct 24, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(FIX-2087): row 3 grades the closure's own findings
The closure's findings (FIX-2097, FIX-2110 to FIX-2122) are children of
FIX-2056 blocking FIX-2087, so row 3 reads them from Linear and failed each
as "has no check here". Each now runs its regression tests, and names the
run elsewhere in the closure that grades it end to end (`by`: a goal some
entry runs, a row-1 assertion, or the sweep). A `by` that names no such run
is a failure, so a stale reference can't pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
  • Loading branch information
claude committed Oct 23, 2026
commit deaccbd6176a0fc6e63d46d297baa043af4cd102
53 changes: 50 additions & 3 deletions goals/workforce-coordination/runs-on-one-task/children.mts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ export interface Check {
controls?: Record<string, string[]>;
/** What row 1 walks of it, printed beside it. */
walked?: string;
/**
* The runs elsewhere in this closure that grade it end to end, for a closure finding whose fix
* landed in a goal another entry already runs, or whose failing check was a row-1 assertion:
* a goal path some entry here runs, a row-1 assertion tag (`a:follow-up`), or `sweep`. Printed
* beside it; one that names no such run is a failure, so a stale reference can't pass silently.
*/
by?: string[];
}

/** Each child's checks, by issue id. */
Expand Down Expand Up @@ -55,6 +62,32 @@ export const CHECKS: Record<string, Check[]> = {
{ vitest: { filter: "@flow-state-dev/orchestration", files: ["test/task-board/drain-pays-owed-cascade.test.ts", "test/collection/owes-a-touch.test.ts", "test/collection/filing-settings.test.ts", "test/skills/task-tools-capability.test.ts"] } },
{ vitest: { filter: "@flow-state-dev/workforce", files: ["test/conversation-board-filing-settings.test.ts", "test/worker-plans-its-steps.test.ts"] } },
],
// The closure's own findings, each a child blocking FIX-2087 once filed: its regression tests,
// and the run that found it, which now grades it (`by`).
"FIX-2097": [{ vitest: { filter: "@flow-state-dev/store-sqlite", files: ["test/write-after-close.test.ts"] }, by: ["workforce/split-to-roster"] }],
"FIX-2110": [{ vitest: { filter: "@flow-state-dev/workforce", files: ["test/worker-plans-its-steps.test.ts"] }, by: ["a:answers-after-steps", "a:lands-once", "task-board/waits-on-a-task-it-filed"] }],
"FIX-2111": [
{ vitest: { filter: "@flow-state-dev/workforce", files: ["test/task-session-stays-open.test.ts", "test/project-coordinator.test.ts"] }, by: ["a:follow-up", "a:once", "task-tools/steer-and-follow-up"] },
],
"FIX-2112": [
{ vitest: { filter: "@flow-state-dev/orchestration", files: ["test/tasks/wait-on-task.test.ts", "test/tasks/task-notice.test.ts"] }, by: ["j1:read-once", "j1:heard-once", "task-board/waits-on-a-task-it-filed"] },
],
"FIX-2113": [
{ vitest: { filter: "@flow-state-dev/orchestration", files: ["test/tasks/notice-defer.test.ts", "test/tasks/pass.test.ts"] } },
{ vitest: { filter: "@flow-state-dev/workforce", files: ["test/steer-while-filed-work-open.test.ts"] }, by: ["j2:steer-shows"] },
],
"FIX-2114": [
{ vitest: { filter: "@flow-state-dev/orchestration", files: ["test/collection/deps-read-committed.test.ts"] } },
{ vitest: { filter: "@flow-state-dev/workforce", files: ["test/deps-read-committed.test.ts"] }, by: ["task-board/runs-by-its-filing-settings"] },
],
"FIX-2115": [{ vitest: { filter: "@flow-state-dev/workforce", files: ["test/coordinator-routed-tasks.test.ts"] }, by: ["coordinators/files-tasks-down-the-owners-chain"] }],
"FIX-2116": [{ by: ["coordinators/hands-each-post-to-its-delegates"] }],
"FIX-2117": [{ by: ["task-board/a-worker-plans-its-own-steps"] }],
"FIX-2118": [{ by: ["task-board/every-ending-reaches-its-filer"] }],
"FIX-2119": [{ by: ["sweep"] }],
"FIX-2120": [{ by: ["goal-seek-loop/replans-until-done"] }],
"FIX-2121": [{ by: ["hand-offs/ask-survives-a-restart", "hand-offs/survives-a-restart-and-runs-once"] }],
"FIX-2122": [{ vitest: { filter: "@flow-state-dev/orchestration", files: ["test/collection/filing-settings.test.ts"] }, by: ["a:follow-up", "task-tools/steer-and-follow-up"] }],
};

/** The goals the closure rule names besides the children's: coordinators, hand-offs, FIX-2005's privacy leg, and the goal-seek loop (journey j3). */
Expand Down Expand Up @@ -86,6 +119,17 @@ async function childrenFromLinear(): Promise<Array<{ id: string; title: string }
.map((n: any) => ({ id: n.issue.identifier, title: n.issue.title }));
}

/** Every goal some entry runs, for checking `by`. */
const RUN_GOALS = new Set([...Object.values(CHECKS).flat(), ...NAMED].flatMap((c) => (c.goal === undefined ? [] : [c.goal])));

/** Report a check's `by`, and fail one that names no run here (`tags` are row 1's assertions). */
function checkBy(owner: string, check: Check, tags: readonly string[], failures: string[], report: string[]): void {
if (check.by === undefined) return;
const stale = check.by.filter((b) => !(b === "sweep" || tags.includes(b) || RUN_GOALS.has(b)));
report.push(` ${owner} graded by ${check.by.join(", ")}`);
if (stale.length > 0) failures.push(`children:${owner} — graded by ${stale.join(", ")}, which no run in this closure holds`);
}

/** Run one check (and its controls); push a failure per red run or control that stayed green. */
function runCheck(owner: string, check: Check, failures: string[], report: string[], say: (s: string) => void): void {
const runs: Array<{ control?: string; args: string[]; cmd: string }> = [];
Expand Down Expand Up @@ -122,8 +166,8 @@ function runCheck(owner: string, check: Check, failures: string[], report: strin
}
}

/** Run row 3. */
export async function runChildren(failures: string[], report: string[], say: (s: string) => void): Promise<void> {
/** Run row 3. `tags` are row 1's assertions, which a check's `by` may name. */
export async function runChildren(failures: string[], report: string[], say: (s: string) => void, tags: readonly string[]): Promise<void> {
const read = await childrenFromLinear().catch(() => undefined);
const set = read ?? Object.keys(CHECKS).map((id) => ({ id, title: "(not read: LINEAR_API_KEY unset)" }));
report.push(`row 3: ${set.length} children blocking FIX-2087${read === undefined ? ", the built-in set (Linear not read)" : ", read from Linear"}:`);
Expand All @@ -135,7 +179,10 @@ export async function runChildren(failures: string[], report: string[], say: (s:
failures.push(`children:${c.id} — a child blocking the closure has no check here`);
continue;
}
for (const check of checks) runCheck(c.id, check, failures, report, say);
for (const check of checks) {
runCheck(c.id, check, failures, report, say);
checkBy(c.id, check, tags, failures, report);
}
}
for (const check of NAMED) runCheck("named", check, failures, report, say);
}
2 changes: 1 addition & 1 deletion goals/workforce-coordination/runs-on-one-task/run.mts
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ await runGoal(async (failures, tell) => {
if (ctl.status !== 0) failures.push(`sweep:control — the plants were not reported exactly:\n${ctl.stdout.slice(-1500)}`);
report.push(`sweep --control: ${/CONTROL (OK|BROKEN).*/.exec(ctl.stdout)?.[0] ?? "no verdict"}`);
}
if (parts.has("children")) await runChildren(failures, report, say);
if (parts.has("children")) await runChildren(failures, report, say, Object.keys(TAGS));
if (parts.has("gaps")) printGaps(report, failures);
if (control !== undefined) {
const red = failures.filter((x) => tagOf(x) === control.mustFail);
Expand Down
Loading