Repository navigation
FIX-2087: closure QA for one task primitive: the walk, the sweep in CI, and 13 findings #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3d7effe
test(FIX-2087): the closure's goal and the task-surface sweep in CI
claude 63da04f
test(FIX-2087): the closure's first verdicts
claude f6d06f1
test(FIX-2087): the sweep reads tools and endings by symbol; controls…
claude b6f75bf
test(FIX-2087): a forwarder exempts only its forwarding; every block …
claude fdb18c5
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude b76f76b
test(FIX-2087): j1 counts only notice requests that ran a turn; j1:he…
claude e7c24c7
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude 7e07954
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude deaccbd
test(FIX-2087): row 3 grades the closure's own findings
claude 1ba899d
test(FIX-2087): classify the closure goal in FIX-1792's census
claude 89217e4
test(FIX-2087): the closure's verdict on main with every closure fix …
claude 024a259
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude 5e5ee0e
test(FIX-2087): row 3 grades FIX-2123, FIX-2135 and FIX-2136
claude 455b3fb
test(FIX-2087): a hearing is a notice admitted, not a request started
claude 1defdcc
Merge remote-tracking branch 'origin/main' into fix/FIX-2087
claude e51ac8b
test(FIX-2087): row 3 runs FIX-2138's regression test
claude cde0a95
test(FIX-2087): round 3's verdicts
claude 46a6629
Merge origin/main into fix/FIX-2087
claude 4ec08e6
test(goals): grade FIX-2147, FIX-2149 and FIX-2150 in the closure's r…
claude 8a5ed55
refactor(goals): fold the shorter one-task notes from #3790 (083cef8a…
claude 77dd49e
fix(goals): the closure fails closed, and grades a word-for-word foll…
claude 683c151
fix(goals): every control's tags must go red, and the door rule reads…
claude 9a35628
fix(goals): read a control's red from its tagged failures, and bring …
claude b6516a8
docs(goals): the closure's goal states how a control is read and what…
claude eb33735
docs(goals): round 4's verdicts in the closure's log (FIX-2087)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
goals/task-board/every-ending-reaches-its-filer/controls.mts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * This goal's named control and its kill point, as scratch patches (`goals/lib/module-patch.mts`). | ||
| * Exported so a goal that composes this one (FIX-2087's closure walk) reuses them rather than | ||
|
jhoffner marked this conversation as resolved.
Resolved
|
||
| * copying them. | ||
| * FIX-2087's closure imports these `from`/`to` anchors for its `GOAL_CONTROL` legs: renaming one breaks that run too. | ||
| */ | ||
| import type { ModulePatch } from "../../lib/index.mts"; | ||
|
|
||
| /** Each named control, by its `GOAL_CONTROL` name. */ | ||
| export const PATCHES: Record<string, ModulePatch[]> = { | ||
| // The sweeper fires no wake: only a fast path or a touch pays a debt. The | ||
| // patch skips the fire of each due wake. The wake step still resumes waits | ||
| // past their deadline (FIX-2082), a debt this goal does not grade. | ||
| "no-sweeper-payment": [ | ||
| { | ||
| module: "packages/engine/src/durability/durability-sweeper.ts", | ||
| from: String.raw` if \(fireWake === undefined\) continue;`, | ||
| to: " continue;" | ||
| } | ||
| ] | ||
| }; | ||
| /** Leg b's second process dies the moment an ending's delivery would send a notice it owes. */ | ||
| export const KILL_AFTER_ENDING: ModulePatch = { | ||
| module: "packages/orchestration/src/tasks/notice/delivery.ts", | ||
| // The first line of the delivery's send half, after the ending's write. | ||
| from: String.raw` const notices = owedNotices\(row, board\.collectionId, rows, filerOf\);`, | ||
| to: ' if (process.env.GOAL_KILL === "after-ending" && Object.keys(row.metadata ?? {}).some((k) => k.startsWith("noticeOwed:"))) process.exit(0); const notices = owedNotices(row, board.collectionId, rows, filerOf);' | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| * This goal's named control, as scratch patches (`goals/lib/module-patch.mts`). Exported so a | ||
| * goal that composes this one (FIX-2087's closure walk) reuses it rather than copying it. | ||
| * FIX-2087's closure imports these `from`/`to` anchors for its `GOAL_CONTROL` legs: renaming one breaks that run too. | ||
| */ | ||
| import type { ModulePatch } from "../../lib/index.mts"; | ||
|
|
||
| /** Each named control, by its `GOAL_CONTROL` name. */ | ||
| export const PATCHES: Record<string, ModulePatch[]> = { | ||
| // Both cascades off: no ending records the debt, so nothing pays one, and a | ||
| // touch doesn't sweep for dependents an ending missed. | ||
| "no-cascade": [ | ||
| { | ||
| module: "packages/orchestration/src/tasks/collection/internal.ts", | ||
| from: String.raw` if \(recording\?\.owesCascade\?\.\(row as Task, ending\) !== true\) return row;`, | ||
| to: " return row;" | ||
| }, | ||
| { | ||
| module: "packages/orchestration/src/tasks/collection/cascade.ts", | ||
| from: String.raw` await cancelDeadDependents\(writes, now\);`, | ||
| to: "" | ||
| } | ||
| ] | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.