Repository navigation
fix(orchestration): a task's ending reaches its filer once, on the defaults too (FIX-2123) #3733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5c8a130
fix(orchestration): a task's ending reaches its filer once, on the de…
claude 7e5b3c9
docs(orchestration): when a task's ending reaches its filer (FIX-2123)
claude 0501d15
fix(orchestration): hold no request-end hook where no notice can be h…
claude adbcf0b
fix(orchestration): a parked filing request holds no notice; a live t…
claude 697bcf9
test(orchestration): name the person-park step awaitApproval, not a r…
claude 4d9568b
docs(orchestration): a parked filing request holds no notice; arrives…
claude dc20268
Merge branch 'fix/FIX-2123' of https://github.com/fixpoint-labs/flow-…
claude 0652a15
fix(orchestration): no board I/O at a park; the pass sends what a par…
claude 69831f2
docs(orchestration): a parked request holds no notice; a deadline-pas…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(orchestration): hold no request-end hook where no notice can be h…
…eld (FIX-2123) The send at the filing request's end registered a request-end hook at every filing on a board that delivers. A context built outside a request's run (testBlock's) never runs its hooks, and the engine keeps owed hooks process-wide: every later host shutdown in the process then waited out its 10 s drain budget. On CI's shared module cache that made wait-on-task.test.ts time out test by test. The hook is registered only where a notice can be held for the request: a host that records which requests have ended (`requestHost.waits.ended`). Anywhere else nothing is held, so nothing needs sending at its end. Regression test: a row filed under testBlock, then a host's dispose finishes in under 2 s (it took the 10 s budget before). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
- Loading branch information
commit 0501d15228db0cbc4473d2182bb398c448f212ed
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reuse:
whenRequestEndsmirrors theonRequestEnded+ skip-suspendedpattern already inwait-on-task/task-request. Not wrong to duplicate once, but a tiny shared registrar would keep park-timing rationale in one place if more features register end hooks.