Repository navigation
fix(orchestration): a task's ending reaches its filer once, on the defaults too (FIX-2123) #3733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5c8a130
fix(orchestration): a task's ending reaches its filer once, on the de…
claude 7e5b3c9
docs(orchestration): when a task's ending reaches its filer (FIX-2123)
claude 0501d15
fix(orchestration): hold no request-end hook where no notice can be h…
claude adbcf0b
fix(orchestration): a parked filing request holds no notice; a live t…
claude 697bcf9
test(orchestration): name the person-park step awaitApproval, not a r…
claude 4d9568b
docs(orchestration): a parked filing request holds no notice; arrives…
claude dc20268
Merge branch 'fix/FIX-2123' of https://github.com/fixpoint-labs/flow-…
claude 0652a15
fix(orchestration): no board I/O at a park; the pass sends what a par…
claude 69831f2
docs(orchestration): a parked request holds no notice; a deadline-pas…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(orchestration): a parked filing request holds no notice; a live t…
…aker is never replaced (FIX-2123) Review 5630613272 on #3733: - A notice is held only while the request that filed its task is running, not while it is parked on a person or a wait. Core's RequestWaits gains an optional `running(requestIds)`, which the engine implements (in_progress, this session); `ended` folded suspended and running together. The request sends what it held as it parks too: the record still reads in_progress while its hooks run, so the filer's pass is owed shortly instead. - A request that runs again after its park notes the rows it filed when it resolves the board, so it sends what it held as it next parks or ends. Registered once per request and board; never on a ledger that owes no notices (a plan board). - A wait on a task whose notice another request took answers arrivesAsNotice whether that notice is under way or done. - A copy that finds the notice taken by a request that hasn't ended, running or parked, runs nothing and records itself as turned away, so the notice doesn't age out while it is delivered. - A filing's metadata can't carry notice records. Tests: a filer parked on a person hears its task during the park, and its resumed wait answers arrivesAsNotice; a request that runs again after its park sends the held notice as it ends; a second copy beside a running or parked taker runs nothing (red when the live-taker line goes); engine `running` tells running from parked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
- Loading branch information
commit adbcf0b364b8fbbf199eae5d034274b7a4569f1f
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@flow-state-dev/core": patch | ||
| "@flow-state-dev/engine": patch | ||
| --- | ||
|
|
||
| `RequestWaits` gains an optional `running(requestIds)`: whether each request of the running session is running its own work now (`in_progress`), as opposed to parked (`suspended`) or ended. The engine's request host implements it (FIX-2123). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify later: This hook scans
listAll()on every request end for rows withfiler.requestId === own. For session-sized boards that’s fine, but it’s O(board) on the request-end critical path (after drains). A per-requestSet<taskId>filled at file time (same idea aslapsedByRequestinwait-on-task) would shrink the hook and avoid re-scanning unrelated rows.