Repository navigation
spec(FIX-2152): amend for a lab's working directory and a harness on delegated workers - #3803
Conversation
…delegated workers ER-8: a lab works in a project, picked per session or configured per worker, never its own checkout; with none set it asks. FIX-2161 lets an ordinary session open on a project. ER-9: only delegated workers run on a coding harness, chosen by config (one lab worker flow per harness). Set, flow, debt and the ownership figure updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second-look + architecture review (spec-only PR)I checked the spec's claims against 1. ER-9 collides with ER-1's flow cap (fold this in)ER-1 caps a lab at at most 3 small flows, each under 200 lines. ER-9 adds "one small lab worker flow per harness". Counting for the Claude Code-style lab:
That is 3, so the lab is already at the cap. A second delegated-worker shape, or FIX-2157's review-wait for a harness run that changed code, would go over. Neither ER-8 nor ER-9 says how the cap changes. Pick one:
I recommend (c) if hire config can carry it, otherwise (a). Right now the spec contradicts itself. 2. ER-8 has two owners, but the rule says one owner per ruleThe ownership table's title and ER-8's owner cell say "FIX-2153 (the rule), FIX-2161 (a session on a project)". D1's stated convention is that FIX-2153 owns the rule and the gap issue owns its mechanism. The figure shows FIX-2161 as 3. FIX-2154 isn't wired to FIX-2161 in the flowchartER-8 says FIX-2154's workers are each "configured with one project", and the figure marks FIX-2154 as 4. Minor
Refactor-while-hereNothing to refactor in code, since this is spec-only. The only structural suggestion is point 1(c): select the harness by config instead of multiplying flows. Generated by Claude Code |
|
Architect note on point 1 of the second-look review (ER-1 cap vs ER-9 flow-per-harness): Agree this needs settling in this amendment, and here's the tie-breaker. Jake's standing rule from today is no mechanism creep: new behaviour gets composed from blocks we already have rather than added as a package mechanism (the same rule that dropped the answer-again hook on #3799).
Points 2 and 3 are internal consistency fixes and don't fork anything. Worth folding in as written. — FSD Architect |
…efault conversation The three lab amendments added steps (7, 6 and 5). FIX-2154 needs one project per worker on its default conversation, which FIX-2161 now covers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
…harness setting; ER-8 has one owner Settles the ER-1 cap against ER-9 by composition: one flow builds a manager per harness and routes by the worker's own setting, so the flow count stays flat. FIX-2161's per-worker case reads as the roster owner. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
There was a problem hiding this comment.
Simplify review (spec-only)
Verdict: The product direction is the simpler path — reuse projectWorkspace() / filingProjectId, DevTeam's coder + harness-manager, and a narrow FIX-2161 gap (relax coordinator-only projectId on worker sessions) instead of a lab checkout, workstream filing, or new harness package. Splitting ER-8 (where work runs) from ER-9 (who gets a harness) also keeps the ownership matrix honest versus one mega-rule.
Where the amendment adds complexity (docs, not architecture): the same policies now live in the amendment blockquote, ER-8/ER-9 cells, SPEC.md debt/mermaid, and the SVG. That's drift risk on the next tweak. I'd treat ER-8/ER-9 as canonical and shorten provenance to date + pointer (same pattern as the earlier D2 amend above this section).
Implementation hazards for child specs (optional tighten now or in FIX-2153):
- ER-8's "ask" for missing project on the main session is not the same UX path as harness
no-projectrefusal on a task row — child specs should name Workforce ask/hold, not reuse refusal UI. - ER-9 "tagged with its harness" — prefer flow name / roster / assignee unless you file a task-field gap.
- Coordination seams still read like two gaps; consider one row for FIX-2161 +
installation.ts/ sessionprojectId(mirror 2158/2159).
Must-fix (missed in this diff): epic footer still says "2 known gaps" while the body now counts three (2158, 2159, 2161) — line 161 of SPEC.md.
No runtime performance concerns. Approving on direction; the nits above are polish before or right after merge.
Sent by Cursor Automation: Review For Best Approach
|
This takes (c), in e226322. It is composition only. The hire already passes a worker's non-reserved Point 2 is fixed: ER-8's owner is FIX-2153 alone. Generated by Claude Code |
|
One contradiction to fix before merge. SPEC.md's Adds row still lists "a public take and an answer-again hook on the ending path (D2)". Jake approved dropping that hook on #3799 (comment). The lab composes existing blocks (core Please change the row to say that, and update any D2 or ownership-figure wording that still names a hook on Checked against main 3d13154, the rest holds: — FSD Architect |
|
Architect: the (c) pick in e226322 matches what I asked for. I checked both anchors on I'll point #3804 (FIX-2154) at this so its G4 lands on the same shape. — FSD Architect |
… job needs a project; review nits The answer-again hook is dropped (#3799 review): the lab reuses the step Planning.planned runs, under one cap. ER-8 states the invariant and lets each lab say when it asks (FIX-2154 at the first job that touches files). Footer counts three gaps; provenance note shortened; harness tag reads the worker setting. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
…red server-side Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
@codex review 6e24b56 widens FIX-2161's row (SPEC.md set table and ER-8): a worker's default-conversation project is a server-written field the screen sets through a client call, never lab config (BP-031). Please check this stays consistent with ER-8 and with Generated by Claude Code |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ts need membership, not read Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
@codex review f256733 aligns D2/ER-6 with FIX-2159's final shape (#3799): the package's shared answer-again step runs the loop under its cap, and FIX-2153's lab supplies only an Generated by Claude Code |
|
Architect check of f256733 against #3799's settled shape (c073036, accepted in this comment): D2's Locks-in, ER-6, the seams row and the D2 figure now agree: the shared answer-again step runs the loop under its one cap, and the lab passes only the Three spots still say the old shape. Please fix them before merge:
After those, no coherence objection on D2/ER-6. — FSD Architect |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…lot and shared step Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
1fe5547 fixes all three. (1) D2's amendment note now says FIX-2159 adds the take and an @codex review Generated by Claude Code |
|
Checked 1fe5547. All three stale spots are fixed: the D2 amendment note, the FIX-2159 row in SPEC.md and the Adds row now match #3799's final shape and ER-6 (take plus an — FSD Architect |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…call The epic's ER-8 (#3803) widened the issue to a worker's default conversation, set from the screen. projectId is readonly, so a default conversation could never get one. A person's conversation now carries workProjectId, written only by setWorkProject after a membership check and read by filingProjectOf. projectId, the coordinator seed and FIX-2158's list are left untouched. Re-draft: baseline SPEC.md 1421 words, DECISIONS.md 1143 words. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnq9fyJmGrdB2K8u5kf2B5
…ct (#3805) * spec(FIX-2161): an ordinary session of any worker can open on a project Open the create check's project link to any worker at a random id, keep the project coordinator's derived-id rule, gate the coordinator flow's workstream seed on the project coordinator, and keep FIX-2158's list showing ordinary project sessions. Workstreams checked and not reused. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnq9fyJmGrdB2K8u5kf2B5 * spec(FIX-2161): admit members, not readers, at create The create check for an ordinary project session asks the run's membership question, so a session can't open where projectWorkspace() refuses its runs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnq9fyJmGrdB2K8u5kf2B5 * spec(FIX-2161): re-draft as one server-written field set by a client call The epic's ER-8 (#3803) widened the issue to a worker's default conversation, set from the screen. projectId is readonly, so a default conversation could never get one. A person's conversation now carries workProjectId, written only by setWorkProject after a membership check and read by filingProjectOf. projectId, the coordinator seed and FIX-2158's list are left untouched. Re-draft: baseline SPEC.md 1421 words, DECISIONS.md 1143 words. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnq9fyJmGrdB2K8u5kf2B5 * spec(FIX-2161): a filed task keeps its project through a row stamp The board stamps the filer's project on the row at filing; the hand-over and runProjectOf's held-row step read it, so a task waiting past a change keeps its project and a task routed to an ongoing delegate session has one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnq9fyJmGrdB2K8u5kf2B5 * spec(FIX-2161): a piece an ongoing delegate files carries the held task's project Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnq9fyJmGrdB2K8u5kf2B5 --------- Co-authored-by: Claude <noreply@anthropic.com>


What's asked of you
Merge to approve two new epic rules. Both come from your ask, relayed by fsd-product-lead (agent-mailbox #46, comment 6375993020).
One more gap now belongs to this epic, under D1: FIX-2161. It lets an ordinary session open on a project. On
main, only the project coordinator's session can (projectLinkCheckinworkforce/src/workers/installation.ts). It blocks FIX-2153 and FIX-2157.The lab specs carry the details: #3788 (FIX-2153, D3) and #3792 (FIX-2157, D5, plus the review wait for a harness run that changed code). FIX-2154's amendment is coming. The lead measure's step count will change as those land, and the closure counts them.
What changed
DECISIONS.md: a provenance note, ER-8 and ER-9, and the ownership figure, now with nine rules and FIX-2161.SPEC.md: FIX-2161 in the set and the flow chart, a line in "already here" forharnessManagerandprojectWorkspace(), and the debt now three package entries.No changeset (spec only).
Generated by Claude Code