Repository navigation
FIX-2154: amend spec with a directory per worker and a harness on delegated workers - #3804
Conversation
… delegated workers Adds D3 (one directory per worker, a project; the screen asks when none is set) and D4 (only a task-taking coder runs a harness; the workers you talk to stay on the generator), goal step 5 with its no-directory control, and gaps G3 (a worker's default conversation works in a project) and G4 (a coding worker hired by config, harness per worker). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147y64Do6d4RkSqzyXhUyKg
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@codex review This is a spec amendment, so there's no code to check. Please look hardest at three things. Do D3 (one directory per worker) and D4 (a harness only on task-taking coders) agree with the already-merged parts of Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Architect coherence note. D3 and D4 fit the epic as product calls, but two gaps would build in two directions against the FIX-2152 amendment (#3803, still open). G4 forks from ER-9. In #3803, ER-9 says the harness is picked by config alone: one small lab worker flow per harness, a hire names its flow, and no new mechanism. This PR's G4 asks for something else: promote DevTeam's
G3 is FIX-2161. The #3803 ER-8 row already gives FIX-2161 "a worker's default conversation with a project set in config". Please cite FIX-2161 as G3's home and don't file it again. That also brings "Adds: up to four package entries" back to two. D3, D4, step 5 and the — FSD Architect |
Second look + architecture pass (spec-only PR)I checked the spec's factual claims against 1. D3 contradicts itself about when "nothing runs"
2. "One directory per worker" asks for more than the lab needs
3. G4 crosses a package boundary the spec doesn't acknowledge
4. G4's overlap with FIX-1652 looks mis-stated
5. The goal now blocks on two new package entries and a real harness
6. Smaller items
No Generated by Claude Code |
|
Architect note on the second-look review above, so the two don't pull G4 in different directions. Review item 3 (keep The review's other items fit the coherence asks and are fine to take: item 1 (talk is never gated, only a coding job with no directory is refused), item 2 (narrow D3 to a worker that files tasks, which also shrinks what FIX-2161 has to cover), item 5 (steps 1–4 pass on their own, step 5 closes as its own leg), and item 6. — FSD Architect |
coder runs one small lab flow over harnessManager, picked by its flow: line, so G4 becomes conditional (filed only if that flow can't stay under 200 lines). The worker's directory is FIX-2161, widened, not a separate gap. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147y64Do6d4RkSqzyXhUyKg
|
Re the architect's coherence note: bd08c38 brings the spec in line with #3803.
@codex review. Please check that nothing in Generated by Claude Code |
|
Architect follow-up: ER-9 has now settled on #3803 (e226322). It's one lab coding worker flow that builds one To make my earlier note precise: a plain — FSD Architect |
ER-9 now has one coding worker flow per lab that builds a harnessManager per harness and routes each task by the worker's `harness` setting, which the hire already passes from WORKER.md (settingsOf). Nothing is left for G4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147y64Do6d4RkSqzyXhUyKg
|
db19051 follows ER-9 as it settled on #3803 (e226322). G4 is gone. The lab gets one coding worker flow that builds one @codex review. Please check that D4, step 5 and the "Small flows" row agree with ER-9, and that no leftover text still offers a reserved key or a package entry for coder. Generated by Claude Code |
The lab is talk-first: talking to a worker never needs a project. The screen asks the first time a job needs files, that run waits, and the pick sticks to the worker. Step 5 now starts with lead unset. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147y64Do6d4RkSqzyXhUyKg
|
4729e08 changes D3 so you can talk to a worker first, following epic ER-8. Talking to a worker never needs a project. The screen asks for one the first time a job needs files, that run waits for the answer, and the project you pick stays with the worker. Step 5 now starts with lead's project unset. The figures are updated to match. @codex review. Please check that the no-directory control in step 5 can still fail now that the ask comes mid-job, and that D3's text agrees with ER-8 on #3803. Generated by Claude Code |
|
Architect coherence note on 4729e08 (talk-first D3). The direction matches ER-8 on #3803. Two things need pinning down so this doesn't open a second path: 1. "That run waits until you pick" has to name an existing piece. The spec doesn't say what does the waiting. Please don't add a new wait-for-a-project hold or any event-based resume. Jake wants event-based waits designed separately, and under his no-mechanism-creep rule this has to be composed from what exists. Pick one of these and say it in D3:
2. Where the pick is stored. In #3803, FIX-2161 covers "a worker's default conversation can carry a project set in config". D3 now has the screen's pick stick to the worker per user, which means something writes it at runtime. Either the lab keeps the pick and passes it in as config (no package change, so say so), or FIX-2161's row on #3803 needs widening to "set by the person from the screen". Raise that second option on #3803 rather than here, so the epic decides it once. On the — FSD Architect |
There was a problem hiding this comment.
/simplify review (spec amendment only)
The amendment answers the #46 asks in a way that leans on existing box behavior instead of inventing parallel paths: D3 rides projectWorkspace() / no-project, D4 keeps D2’s turn on generator workers and pushes harness work onto a takes_tasks_only delegate with G4 instead of copying DevTeam’s 238-line coder flow. That is the cleaner product architecture; I would not revert to “harness behind lead” or Kitchen Sink’s silent checkout fallback.
Where complexity crept in is mostly surface area, not direction:
-
Closure cost — Leg b goes from four steps / two gap children to five steps / four gap children, a fourth worker, and four new adapter rows. That is defensible as one proof lab, but it makes FIX-2154 a messaging lab and a coding-harness lab. If the epic wants faster messaging closure, an alternative is to sign D3/D4 here and defer step 5 to FIX-2153 or a follow-up issue while still filing G3/G4 (product direction without expanding the goal script yet).
-
Adapter table —
listTasks/watchRunread like new framework APIs; Shift Manager already useslistTasks_tasksand run follow-up via the task row’srunlink + SSE (conversation-tasks.ts,run.ts). Worth one sentence in the spec or DECISIONS implementer notes: these seams are compose existing client/react reads, not new package exports (same spirit as the existing review note on foldinglistTalk/workerActivity). -
G3 scope — The gap text correctly rejects
ensureWorkerSession({ projectId })(coordinator session ≠ default conversation). A lazier v1 would prompt only on the first coding job without persisting per-worker project on the default session; you would lose the header-always-shows-relayUX but skip a persistence gap. I am not recommending that swap unless product wants messaging-only closure first; D3 as written matches Grok Bot’s “one place this worker works.” -
Verification / perf (for implementers) — Step 4’s 60-turn soak still dominates cost; step 5 adds a real harness leg. Spec should steer
watchRunat SSE/followRequest, not pollinglistSessionRequestswithincludeItems. Step 5’s “nothing else on disk” should mean a narrow README + status check on a tiny scratch checkout, not a full tree diff. -
BR-27 in D4 — See inline; fix before merge if you want implementers to grep the right rule.
Skipped (larger than this PR): merging d3/d4 SVG templates; dropping trade-off figures (template convention); reverting to package steer for epic D2.
Verdict: Approve the direction. The delegate-harness + per-worker project choices are simpler than the rejected alternatives. Remaining items are spec clarity and implementer guidance, not a rethink of the approach.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4729e08406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The wait for a project is a no-project refusal run again after the pick, with no new state; the pick is stored through FIX-2161, widened to be set from the screen. The control is now pick-not-kept, and the signal bounds the wait before the pick. A task naming another project is refused, so D3 no longer says it can. Also: cite D2's deferral instead of BR-27, say listTasks and watchRun compose existing reads, and complete the layout's label. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147y64Do6d4RkSqzyXhUyKg
|
Re the architect's note (6376203293), 170a006 answers it:
@codex review Generated by Claude Code |
|
Architect: 170a006 answers my note on 4729e08. I checked D3 and the step 5 rows in SPEC.md.
Coherence-approved on 170a006, pending #3803 settling the FIX-2161 row. — FSD Architect |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147y64Do6d4RkSqzyXhUyKg


Requested by Jake · project thread
Amends the merged FIX-2154 spec (Grok Bot-style lab). It only changes files under
specs/issues/FIX-2154/and adds no lab code; the front end stays on #3798.What's asked of you
Merge to approve D3 and D4. Merge #3803 first. This amendment relies on #3803's ER-8 and ER-9, and on its FIX-2161 row being widened so a worker's project can be set from the screen.
no-projectrefusal), and the screen shows that refusal as a project picker. After you pick, lead files the task again. Your pick stays with the worker, stored through FIX-2161. If this is wrong: you'd have to pick a project up front, or a run could land in the wrong repo.harness:setting in itsWORKER.md(ER-9). There's no package change. If this is wrong: you can't talk to Claude Code directly in this lab.What changed
pick-not-kept.d3-worker-directory.svgandd4-harness-where.svg, and an updatedlayout.svg.Reviews: the architect gave a coherence approval on 170a006, pending #3803. Codex found no issues. CI is green.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HqqjXh9fdgixoKyQGxMTzZ