Repository navigation
FIX-2342: Teammates lab runs coding tasks on Claude Code, Codex or Cursor, named by the worker - #4222
Conversation
…the worker Three task-only coding workers, one per harness, each naming its harness in WORKER.md (ER-9), all on the lab's one coding flow. Chief of Staff assigns the one the user names, else Claude Code. A harness this machine isn't set up for fails the task at once with a line naming it, and never runs on another. The task line, its popup and the Background item name the harness, and the model only once the run reports one. Cursor under the lab's default runs folder hits ENAMETOOLONG (FIX-2344). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiCsRqCenZsFQRpJBHi (cherry picked from commit b8dfbd4)
…label test a window it can see Main's README dropped the table, which the inventory test requires; the table is regenerated from the lab as it is now. The coding-agent screen test looked for the line before the run reports its model, a 30ms window at fast() speed, so it runs at 0.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEeU2NQEBYRRxCJf5b
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (read-only review of b8946e6)The shape is sound. The ER-9 routing (worker file names 1.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8946e68d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| watchTasks(sessionId, onChange) { | ||
| return watchFeed(sessionId, (items) => [...boardRows(items).values()].map(toBoardTask), stableList(onChange)); | ||
| return watchFeed(sessionId, (items) => [...boardRows(items).values()].map((row) => toBoardTask(row, (worker) => harnesses.get(worker))), stableList(onChange)); |
There was a problem hiding this comment.
Read live spend independently of task-change snapshots
During a coding run without subsequent lifecycle or progress events, the model label remains absent even after the harness reports it. This subscription reads only task-change snapshots, but recordSpend deliberately emits no such event (packages/orchestration/src/tasks/collection/resource-backed.ts:1106–1114), and lease renewals emit none either. Read or subscribe to the current task row’s spend so the conversation, background item, and popup update while the task runs; the fixture’s direct BoardTask.model updates bypass this production path.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed: recordSpend publishes no task-change, so on a real host the model shows with the task's next board change, in practice its ending. Not fixing it in this PR. The read path that exists is polling the board's listTasks_tasks action, as the Claude Code-style lab does, but each list is a request recorded on the Chief of Staff's conversation. This lab reads that conversation's activity and window from its latest 20 requests, so a poll over a long run would push the real turns out of view. The clean fix is a package one, either a throttled board event on live spend or a non-request read of the row, and it's going to Jake as a follow-up. The PR body now says the model appears at the end.
Generated by Claude Code
…tory table The table was removed on purpose; the inventory script's table check goes in #4176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEeU2NQEBYRRxCJf5b
… check Main's README dropped the table on purpose, so the lab's inventory test is red on main. This is #4176's script, test and package.json change as is; it no-ops once #4176 lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEeU2NQEBYRRxCJf5b
|
Generated by Claude Code |
Requested by Jake · project thread
Closes FIX-2342 (under FIX-2152). Builds on FIX-2341 (#4216, merged); based on main.
Also on this branch: the coding-agent screen test runs at a slower fixture speed so it can see the line before the run reports its model (at
fast()speed that window was 30ms and the test flaked; a control with the model reported at once fails it).Known red, not this PR's:
test/inventory.test.tsinlabs/teammatesfails on main too. The README's inventory table was removed on purpose, and #4176 removes the inventory script's table check. It goes green once #4176 merges.What changes
coderworker is nowclaude-code, andcodexandcursorjoin it. EachWORKER.mdnames itsharness:, and all three run on the lab's one coding flow. The task row gets no harness field.showSettings: ["harness"], so each worker's harness rides on its roster row.teammates.codex. With no agent named, it assigns toteammates.claude-codeand goes ahead without asking.cursorSignIn.codex login, then start the task again."taskSpendView); nothing is guessed.@flow-state-dev/cursorwith Kitchen Sink's settings for a local run:composer-2.5, the SDK's sandbox off, and the same env pass list.What's missing
ENAMETOOLONG(FIX-2344). The Cursor SDK names a folder after the run's whole cwd flattened into one name, andharness-manager's worktree paths are about 242 characters before the root. This is a package fix (ER-4). The README lists it under Not wired yet, and a shortrunsRootworks today.task-changerows, and a run's live spend writes none. A live read is a package follow-up (Codex review thread).teammates.coderin an existing local store fail as assigned to a fired worker. Delete.fsdev/teammates.sqliteafter upgrading.Verification
labs/teammatesvitest: all pass except the inventory test above. New screen tests:TaskCard, 5 screen tests fail.openTeammateson a scratch git checkout):roster()returnsharnessfor the three coding workers.codex login, then start the task again." No other harness ran.check-retired-terms, goalstscandvite buildpass.No changeset: the lab is private.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NczDiEeU2NQEBYRRxCJf5b