Repository navigation
FIX-2342: Cursor is the Teammates lab's default coding agent - #4226
Conversation
Jake's call: with no agent named, Chief of Staff assigns a coding task to teammates.cursor. The host's fallback harness and the README follow. The goal's step 5 names Claude Code, so it keeps proving a real Claude Code run while Cursor waits on FIX-2344. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEeU2NQEBYRRxCJf5b
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture passVerdict: the change is right-sized. Seven files, 22/22 lines, every one traces to "Cursor is the default". I don't see a leaner or better approach. Findings below, in priority order. 1. Merge-order hazard (blocking on process, not code)The PR body says it: until FIX-2344 lands, a coding task that names no agent hits 2. The default is stated in three places that can driftThe same decision now lives in:
Plus prose in 3. Hidden coupling worth a note:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fad77ca553
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `teammates.claude-code` (Claude Code), `teammates.codex` (Codex) and `teammates.cursor` (Cursor). | ||
| When the user names one ("have Codex do it"), assign it to that one. When they name none, assign | ||
| it to `teammates.claude-code` and go ahead: never ask which. Tell the user you started a coding | ||
| it to `teammates.cursor` and go ahead: never ask which. Tell the user you started a coding |
There was a problem hiding this comment.
Land the Cursor path fix before selecting it by default
With the standard lab configuration, an unnamed coding request now goes to Cursor, but labs/teammates/README.md:147–150 documents that Cursor fails with ENAMETOOLONG under the default runs folder. In the reviewed tree, fsdev.config.mts:33 still selects that folder, and the required FIX-2344 mitigation is absent. This turns an opt-in harness failure into a failure of ordinary coding requests. Land the path fix before switching the default, or include a Cursor-compatible workspace path in this change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. This is the dependency the PR body leads with: Cursor as the default is the product call, and the path fix is FIX-2344, which another thread is building in harness-manager or the cursor package. It has no PR yet. I'm keeping it out of this lab change because the fix belongs in the packages, so the order is FIX-2344 first, then this PR. I'll leave this thread open until FIX-2344 lands, then merge main in.
Generated by Claude Code
|
Generated by Claude Code |
Requested by Jake · project thread
Follow-up to #4222 (FIX-2342, merged), from the product lead's review on agent-mailbox #46.
Depends on FIX-2344 (#4227). Merge #4227 first. Cursor fails with
ENAMETOOLONGunder the lab's default runs folder. Until #4227 lands, a coding task that names no agent fails on a real machine unlessrunsRootis short. Merging this first makes the out-of-the-box path fail.Known red, not this PR's:
Test (3/3)fails onlabs/claude-code-styletest/inventory.test.ts, and it fails on main too since #4200. #4127 fixes it by dropping that lab's table check.What changes
teammates.cursor(chief-of-staff/WORKER.md). The host's fallback harness (TEAMMATES_HARNESS, for a coding worker whose file names none) is nowcursortoo, and so is the README.a-worker-talks-to-another-while-you-talknow asks "Have Claude Code fix…", so it runs on Claude Code by name rather than relying on the default.App.tsxpasses only!takesTasksworkers toWorkersList, so the coding agents get no row, icon or status line. The screen tests assert none of the three has adata-workerrow.task-sessionsonly, so workforce'srecipientRefusalrefuses them by name (task_sessions_only) and leaves them off thesendMessagetool's "Workers you can message" list.Verification
labs/teammatesvitest 62/62 and typecheck pass; the screen file passed 3 runs in a row;check-retired-termspasses.No changeset: the lab is private.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NczDiEeU2NQEBYRRxCJf5b