Repository navigation
spec(issue): shared task actions on the Inbox client (FIX-2381) - #4373
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDLxJJmXUSvc2F7Nrp
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (direction review of FIX-2381)Verdict: the direction is sound. Hanging the actions off Worth folding
Architecture notes (no change requested)
NetFold items 1–5 (1 and 4 matter most); the rest is notes for the implementer. Generated by Claude Code |
There was a problem hiding this comment.
/simplify review (spec FIX-2381)
Verdict: The direction is the right simplification relative to the original issue shape. Folding createTaskActions(client, board) and a second answer call (D1/D2) matches the epic and removes the main constructor/API duplication. inbox.board(at) + one extracted send loop is a cleaner end state than exporting constants or payload builders alone (correctly rejected in the goal section).
I do not think a materially different architecture beats this spec; the remaining complexity is mostly surface area and underspecified edges, not the wrong home (./inbox).
What already went the right way
- Extending
createInboxClientinstead of a second factory — aligns with FIX-2369 review fold. - Keeping
answerOneas the only answer path — avoids parallel routing. - Leaving DevTool’s suffix mirror alone — good package-boundary restraint.
- Scoping lab adapter copy to FIX-2382 — avoids a 14-deep adapter stack here.
Where the approach still adds more than necessary (consider trimming in the spec)
-
refilevs today’sInboxRow— D3/SPEC copycontext,labels, andpriorityfrom the row, butInboxRowinpackages/orchestration/src/inbox/types.tstoday only carriesboard,id,title,goal,assignee, status/holds/holder, etc. Either pin how those fields arrive (FIX-2379 row view? overrides-only? widen the type?) or deferrefileto a follow-up slice so the first package PR stays cancel/steer/release (+ maybe retry). -
retry(id)before FIX-2383’s verb is spec’d — Publicboard(at)includesretry“in whatever shape FIX-2383 settles.” That couples direction approval here to a verb not yet retained in-repo. Safer simplification: spec optionalretryon the first merge, or state explicitly that the package PR may ship withoutretryuntil 2383’s spec merges. -
Two public naming stories —
taskActionName(tool, board)plus moved/re-exportedtaskToolSuffixis defensible for Shift Manager’sholder.action, but worth documenting that apps mutating tasks should useboard(at).*, andtaskActionNameis for readers constructingholder(andcreateTask_*on re-file). Longer-term simpler shape (not required for this merge): store collection id on the holder and resolve the action inside orchestration — would drop the exported constant pattern. -
at.boardvsInboxRow.board— Spec saysat.boardis the collection id ("tasks"), while Shift Manager setsInboxRow.boardto the board ref (`<sessionId>.tasks`). Callers must use existingcollectionOfBoardglue; worth one sentence in SPEC so implementers don’t passrow.boardstraight intoboard(at). -
Shared send routine should not regress Shift Manager’s listing behavior — Today
answerRowQuestionlists one page (limit: 100). Shift Manager’srunActioninpackages/shift-manager/src/lib/action.tspaginates up to 20×100 when finding output. If this routine becomes the single path for task-card actions, the spec should require parity with that pagination (or cite extracting fromaction.ts), not blindly copy the answer path’s single-page list. -
LabReader“exposes board actions” — Prefer returninginbox.board({ flowId, sessionId, board })from a small helper over new methods onLabReader, so FIX-2382 buttons call one API.
Skipped (product / sequencing — mention only)
- Whether goal-check belongs in
packages/workforce/testvs orchestration/integration-tests tier (valid either way; workforce harness is realistic but couples packages). - Epic table still lists FIX-2381 with “answer” — this spec correctly drops it (D2); epic wording should follow on a later pass.
Performance note (inherited, amplified)
Centralizing the send/wait/list loop is correct for consistency, but it amplifies an existing chatty pattern (poll + session request list with includeResultOutput). Not a reason to reject the spec; the implementer should treat pagination/timeouts as part of the shared routine contract (see #5).
Recommendation: Merge for direction after tightening refile typing, at.board mapping, and shared-routine listing parity in the spec text. Optional scope cut: ship cancel / steer / release first; add refile and nail-down retry when row types and FIX-2383 are settled.
Sent by Cursor Automation: Review For Best Approach
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e813f22878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…y lands with FIX-2383, paging) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDLxJJmXUSvc2F7Nrp


Requested by Jake · project thread
Spec for FIX-2381, child of epic FIX-2369 (#4358). Retained at
specs/issues/FIX-2381/.The one call (D1): the board's task actions hang off the Inbox client apps already have:
inbox.board({ flowId, sessionId, board }).cancel(id) / .steer(id, words) / .release(id) / .retry(id) / .refile(row, overrides), bound once per board, with no second constructor (the epic's review folded that out).taskActionName(tool, board)is the one place an app gets an action name.answerOnealready answers a row's question or confirm.reads.tsafter FIX-2379, following the epic's build order. The Claude Code-style lab's copy is removed in FIX-2382's lab stack.Approve by merging.
Generated by Claude Code