Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
spec(FIX-2381): fold round-1 review (context on the browser row, retr…
…y lands with FIX-2383, paging)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NczDiDLxJJmXUSvc2F7Nrp
  • Loading branch information
claude committed Oct 31, 2026
commit 897774e030ae1c8cfdfbcd805a4d602da5deb26c
20 changes: 19 additions & 1 deletion specs/issues/FIX-2381/DECISIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,16 @@ already do.
## D3 · A re-file copies what a browser's row carries

`refile(row, overrides)` sends `goal`, `title`, `context`, `assignee`, `labels` and `priority`
Comment thread
jhoffner marked this conversation as resolved.
Resolved
from the row, overrides winning. It doesn't copy `input`, `metadata` or `deps`: a browser's row
from the row, overrides winning. It takes a `RefileRow` of exactly those fields, not an
`InboxRow`, which carries fewer. It doesn't copy `input`, `metadata` or `deps`: a browser's row
doesn't carry the first two (BP-015 keeps them on the server), and old `deps` may name finished
rows. An override can set any of them.
Comment thread
jhoffner marked this conversation as resolved.
Resolved

- **`context` joins the conversation board's browser fields.** It is the rest of the brief the
user or a worker wrote beside `goal`, which is exposed already. Without it, a browser's re-file
drops part of the brief with no sign. The other way, a server read just for re-file, adds an
action to fetch text that is no more private than the goal.

- **Re-file vs retry:** retry (FIX-2383) keeps the id, the history and the spend, and is the
default after a failure. Re-file is for a task that should run again *changed*, which a started
task's locked fields otherwise forbid ("cancel it and file it again", in the board's own words).
Expand All @@ -55,10 +61,22 @@ rows. An override can set any of them.
FIX-2379's slice merges, per the epic's build order (`2379 → 2381 → 2380`).
- **E5 · The Claude Code-style lab's copy goes in FIX-2382's lab stack**, which owns `adapter.ts`
in that wave. This issue's PRs don't touch the lab.
- **E7 · The send routine pages the session's requests** (20 × 100, as Shift Manager's
`runAction`), and a finished action whose answer isn't found rejects.
- **E6 · No changeset unless the package PR adds a public export**, which it does: one `minor`
fragment for `@flow-state-dev/orchestration`.

## How it got here

- Drafted 2026-10-31 from the issue, the epic's decisions and review record, and the code on
`main` at `675f61441`.

## Notes from review

- Codex (e813f22): one P2, folded. A browser's row has no `context`, so re-file would drop it.
The conversation board now exposes `context` (D3).
- Cursor (e813f22): direction approved. Folded: `retry` lands with FIX-2383's verb; `at.board` is
the collection id, not a row's ref; `taskActionName` is for readers, and apps call `board(at)`;
the routine pages requests like `runAction`; `RefileRow` names the copied fields;
`LabReader.taskActions` is one getter returning `inbox.board(...)`. Its performance note (one
send-wait-list per action) is inherited from the answer path and left as it is.
26 changes: 18 additions & 8 deletions specs/issues/FIX-2381/SPEC.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,32 @@ flowchart LR
## What changes

- **`@flow-state-dev/orchestration/inbox`** gains, on `InboxClient`, `board(at)`, which returns
the board's actions bound to `at = { flowId, sessionId, board }` (`board` is the collection id,
such as Workforce's `"tasks"`) ([D1](DECISIONS.md#d1)):
the board's actions bound to `at = { flowId, sessionId, board }` ([D1](DECISIONS.md#d1)).
`board` is the **collection id** (Workforce's `"tasks"`), not a row's board ref
(`<sessionId>.tasks`); a reader holding a ref gets the id with its own `collectionOfBoard`:
- `cancel(id)` → `updateTask { id, status: "cancelled" }`, resolving to the ids it took along.
- `steer(id, message)` → `updateTask { id, message }`.
- `release(id)` → `updateTask { id, status: "pending" }` on a held row.
- `retry(id)` → FIX-2383's verb, in whatever shape its spec settles. The task keeps its id.
- `retry(id)` → FIX-2383's verb. It lands with FIX-2383's implementation: the package PR stacks
on it, and adds `retry` only once that verb exists on its base. Until then the surface is the
other four.
- `refile(row, overrides?)` → `createTask` with the row's `goal`, `title`, `context`,
Comment thread
jhoffner marked this conversation as resolved.
Resolved
`assignee`, `labels` and `priority`, overrides winning, resolving to the new task id
([D3](DECISIONS.md#d3)).
([D3](DECISIONS.md#d3)). Its input is a `RefileRow` with exactly those fields, so a browser's
row or a server's `Task` fits.
- **Workforce's conversation board exposes `context` to the browser**, beside `goal`. Without it a
re-file from a browser's row would silently drop part of the brief ([D3](DECISIONS.md#d3)).
- **`taskActionName(tool, board)`** is exported from the same entry: the one place an app gets a
Comment thread
jhoffner marked this conversation as resolved.
Resolved
board's action name (for an `InboxRow.holder`, say). It uses `taskToolSuffix`, which moves to a
board's action name, for a reader that builds an `InboxRow.holder` or a test that acts on the
board directly. An app that changes a task calls `board(at)`, never a name it built. It uses `taskToolSuffix`, which moves to a
browser-safe leaf module so `./inbox` stays free of the task board's runtime.
- **One send routine.** The answer path's send, wait, list-the-output, reject-on-`ok:false` loop
Comment thread
jhoffner marked this conversation as resolved.
Resolved
becomes the routine every board action and every row answer goes through.
becomes the routine every board action and every row answer goes through. It pages the
session's requests to find the answer (20 pages of 100, as Shift Manager's `runAction` does),
and a finished action whose answer it can't find rejects rather than reading as a yes.
- **Shift Manager** (second PR, stacked per the build order): `reads.ts` drops its
`UPDATE_TASK_ACTION` copy for `taskActionName`, and `LabReader` exposes the board's actions for
FIX-2382's buttons to call.
`UPDATE_TASK_ACTION` copy for `taskActionName`, and `LabReader.taskActions(conversation)` returns
`inbox.board(...)` for that conversation, one getter, for FIX-2382's buttons to call.
- **Docs:** the orchestration README's Inbox section gains the board actions. The epic's guide
(*building a workforce app from the packages*, FIX-2387) names them; no page of its own.

Expand All @@ -94,6 +103,7 @@ engine. Workforce's board id.
|---|---|
| `createInboxClient` and its `answerRowQuestion` loop | **Extends.** The loop becomes the shared routine; the client gains `board(at)` |
| The task tools' `updateTask` and `createTask` actions | **Reuses.** No new board verb here; the helper only names and sends them |
| Workforce's `CONVERSATION_BOARD_CLIENT_FIELDS` | **Extends** by one field, `context` |
| `taskToolSuffix` in `task-tools-capability.ts` | **Moves** to a leaf module, re-exported where it is today |
| FIX-2383's retry verb | **Reuses**, as this issue's base branch |
| Shift Manager's `UPDATE_TASK_ACTION`, the Claude Code-style lab's copy and `run` loop | **Replaced:** Shift Manager's here; the lab's in FIX-2382's lab stack, which owns that file in the wave |
Expand Down
Loading