Repository navigation
spec(epic): keep the bus; D1/D6 flip in queries/s; FIX-2426/2428 review fixes (FIX-2367) - #4477
Conversation
…ew fixes (FIX-2367) Epic D1/D6: the first flip fired at the labs' view counts and the owner kept the bus (#4445). Both now flip under 100 store queries/s at 100 idle views. D6's publish wraps raw-registry entries too. Set table ids swapped in. FIX-2426: open fork settled; wrap every write method at every entry; wake capped at one read per interval; bus vs wire topics, tenantId required; crossesProcesses may change, delivered as a transition event (FIX-2427); PGlite pool timings dropped as unestablished. FIX-2428: D3 comment and ER-5 tie; one way to follow a session; refused topic answers as missing; contracts/engine changesets; pushSecret shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
Second look + architecture pass (spec-only PR, so findings are about the approach, not code)Verdict: the direction holds (keep the bus is the owner's call and the amendment records it coherently). Four points worth acting on before #4476 builds against this. 1.
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…lineage limit
- ChangeNotice gains optional origin { requestId }; ER-1 widened to allow it (an id, not rows)
- A scope's subscriber hears notices narrowed under it; the session stream filters by kind
- Lineage-shared session resources publish the writer's topic only, as a stated limit
- Epic SPEC notes FIX-2410's shared state-only read
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
… seams - Resources a scope's client.derived reads now publish, and a resource notice reads state for them (Codex P2: a derived org count stayed stale). - origin, narrowed notices, kind filtering and the lineage limit are cited as decided in FIX-2426 (#4477), not raised. - D2: version-based dedupe recorded as dropped; safe failure is a duplicate read. Over-notifying bound stated. Routes share the seam's publish helper. - Two structural suggestions recorded in Notes from review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
…4477) - The parked-wait gap (Codex, jhoffner) is closed by FIX-2426's amended contract: crossesProcesses is a transition event that wakes waiting views. This issue now drives that event from its ping and makes no engine change. - Pins the ping (2 s) and stale rule (3 s) FIX-2426 leaves here. - The listener opens on the first subscriber, not when stores resolve. - The LISTEN reconnect is shared with subscribeViaListen, not copied. - Decided-not-asked inherits FIX-2426 instead of restating it. - Goal signal (3) kills the backend while the view is parked, with no later write; signal (2) bounds the ping rate. - Below-the-bar notes recorded verbatim in DECISIONS.md. Re-draft: DECISIONS.md baseline 1210 words, now 1741 (verbatim review notes included). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
…wers on another (#4476) * spec(FIX-2427): the Postgres bus, a change on one process reaches viewers on another Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn * spec(FIX-2427): review round 1, built on FIX-2426's crossing event (#4477) - The parked-wait gap (Codex, jhoffner) is closed by FIX-2426's amended contract: crossesProcesses is a transition event that wakes waiting views. This issue now drives that event from its ping and makes no engine change. - Pins the ping (2 s) and stale rule (3 s) FIX-2426 leaves here. - The listener opens on the first subscriber, not when stores resolve. - The LISTEN reconnect is shared with subscribeViaListen, not copied. - Decided-not-asked inherits FIX-2426 instead of restating it. - Goal signal (3) kills the backend while the view is parked, with no later write; signal (2) bounds the ping rate. - Below-the-bar notes recorded verbatim in DECISIONS.md. Re-draft: DECISIONS.md baseline 1210 words, now 1741 (verbatim review notes included). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn --------- Co-authored-by: Claude <noreply@anthropic.com>
Amendment to the merged epic spec FIX-2367 (#4294) and its merged children FIX-2426 (#4445) and FIX-2428 (#4443). Rewritten in place; review history stays on the original PRs. #4476 (FIX-2427) and #4478 (FIX-1506) depend on this PR: it owns every FIX-2426 change, including the live
crossesProcessescontract and the notice seams FIX-1506 raised.The owner's decision: keep the bus
Epic D1's flip, as written ("widen if the queries fit with headroom at the labs' view counts"), fired: the labs and Shift Manager run one to five views, at 4.00 store queries a second each. The owner kept the bus anyway (comment). Widening would make polling the shipped way to deliver user and org changes, which FIX-1506 rules out, and FIX-380 would lose its seam.
D1 and D6 now flip in D1's own metric: store queries a second from session-stream connections, under 100 at 100 idle open views (widened to all three scopes for D1, the session stream alone for D6). Today that's about 1,200 widened and 400 for the session alone. 100 views is a small app, twenty times the labs. The bar is twelve times under the estimate, so only a redesigned read crosses it, not a tuned one.
Evidence correction (Codex P2, comment). The 4.00 queries a second per view still holds. The pool shares and the 70–100-view crossover are gone, from the POC too: PGlite runs every query behind one lock, so its timings include waits.
What else changed
resolveStoresand at each entry that takes a raw registry (runAction, BullMQ's job processor,fsdev runandchat). A board change has its own kind; the session stream wakes only onitems/request/run. Set table ids swapped in.patchField/incField/pushToArray/deleteFieldincluded. The wake reads at most once perintervalMs, and per-tick notice folding is allowed. Bus topic (tenantIdrequired) and wire topic (topic.*, no user, org or tenant id) are split, and a resource-narrowed topic is its own channel.crossesProcessesmay change: transitions arrive as an event (onCrossingChange), and a change to not crossing wakes waiting streams back onto the timed read. "Decided, not asked" is trimmed to what this issue decides.useSession({ live })stays the one way to follow a session; the headline example is now a flow read, and FIX-2429 movesliveBoardDriver. A refused topic gets the same answer as a missing session (hiddenSessionResponse), and the POST is added to the scoping table. Engine, contracts and core changesets, plus the client migration line.UserStreamEventis removed;StreamEventstays.pushSecrettakesstring | (() => string), and a failed ticket is logged.joseis allowed.{ userStream, push }both stay.Reviewers · look here
Epic spec · FIX-2426 · FIX-2428
No changeset: specs only. The POC wasn't re-run (it only stops printing timings; statement counts are untouched).
Generated by Claude Code