Repository navigation
Conversation
Adapter of the epic's two seams: the Ably bus fills FIX-2426's bus slot over REST, and the FIX-2428 mint signs a subscribe-only Ably token for the granted topics. The browser half ships in @flow-state-dev/ably/client behind a push slot on createClient. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (direction-level only)Read SPEC/DECISIONS against the FIX-2426 and FIX-2428 specs on 1. D3's fold has no plumbing, and duplicates FIX-2426's (above the line)
2. Opaque channel hash key is unspecified (above the line)"A keyed hash of the bus topic" must produce the same name on every process (publisher on process 1, mint on process 2). The spec doesn't say what the key is. FIX-2428 already hit this class of problem with 3. Two options that must be set together (restraint / footgun)
4. Goal check vs CI (answers the reviewer question)Real-Ably two-process runs are fine as an implementer-at-completion check, but most of leg b/c's assertion is checkable hermetically: the signed token request's Architecture notes (not asks)
No concerns with the debt table or the "Not here" list. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7078971a52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| channel. The message carries `kind` and `origin` only, never the bus topic. | ||
| - **A narrowed notice publishes on its resource's channel and its scope's**, so both hear it, by | ||
| FIX-2426's hearing rule. Two messages, before D3's fold. |
There was a problem hiding this comment.
Preserve resource identity in scope-channel notices
When a resource-narrowed notice is also published to its scope's channel, a subscriber listening only to that scope receives neither the resource identifier nor any way to recover it: the channel identifies the broad scope, and the payload contains only kind and origin. This makes the adapter unable to satisfy specs/issues/FIX-2426/DECISIONS.md:52–54, which requires broad subscribers to receive the original narrowed topic on both the bus and the wire. Preserve a safe resource or wire-topic discriminator in the message without exposing tenant, user, or organization IDs.
Useful? React with 👍 / 👎.
|
Architect read on #4486 (FIX-380, the Ably adapter), checked at The direction is right. Ably fills both seams, the mint stays the one place access is decided, and the bus side mostly follows FIX-2426. Three places change merged contracts without editing them. This PR only touches
Other forks: none with #4476 (FIX-2427). Both are adapters of the same slot that report — FSD Architect |
- Epic FIX-2367: memory-bus control fails leg a's 1 s, not "B never updates" (FIX-2428 D3 keeps the poll); amendment logged. - Closure grades memory-bus on the 1 s consistently; j4 waits on epic D5 and FIX-380's spec (#4486). - a:same-source moved to anti-game; goals/lib reuse row widened; j3 on row 1's processes, j4 on FIX-380's wiring. Other Cursor notes recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
Owner decision on #4512: the closure proves the Postgres bus and the polling fallback. j4 is the Next host's polling fallback only; D3 is decided (no Ably), its figure dropped, and the wait on epic D5 and #4486 removed. Epic FIX-2367: FIX-380 (Ably) is a future transport behind the bus seam and gates nothing; serverless polls today, in this epic, with a native Vercel WebSocket transport named as a later adapter. Seams keep their Ably fit. Amendment logged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
Goal: on a serverless host with Ably, a screen that uses the framework hook gets a change from a different instance in less than one second. A caller gets an Ably credential only for the topics that the mint granted. An app without Ably gets none of this code.
The check reads the result of each client read and the answer from Ably. It does not read calls to
publish. Check:goals/realtime/ably/, real Ably. The controlsGOAL_CONTROL=memory-busandGOAL_CONTROL=wide-tokenmust fail.One package and two options. The hook that a screen uses does not change.
How: the Ably bus sends each notice to Ably over REST. The mint from FIX-2428 checks each topic as before. Then it signs an Ably token that can only subscribe, and only to the granted channels.
Sign off
The goal: push on serverless through Ably, a credential only for granted topics, and no code for apps without Ably. If wrong: Vercel apps poll and pay an Ably bill.
The debt: up, by one vendor package and two options (
pushoncreateFlowStateand oncreateClient). It removes no code. If wrong: a package that nobody installs.An Ably token lives one hour or less; a reconnect in that hour gets no new check · D1
The deciding row is who sees the reconnect. Ably sees it, not our server, so a new mint in the browser does not make it safe. This is the one to weigh: it applies epic rule ER-4 to a service that our server cannot see. If wrong: a revoked user knows that something changed, but not what, for one hour or less.
The Ably package holds the browser half; the app gives it to its client · D2
The deciding row is an app without Ably: each bundler must resolve an optional import. If wrong: one setup line that nobody needed.
A topic sends one Ably message at once, then one each 500 ms or less · D3
The deciding row is the bill during a streaming reply: one message for each write, multiplied by each viewer. If wrong: a change comes half a second later, to save money that nobody was concerned about.
Open: none. D1 is the one to weigh. Reasons and alternatives: DECISIONS.md.
Analysis: right approach. The author did it in this dispatch, not a fresh agent. It changed nothing. DECISIONS.md → Analysis.
Reviewers · look here
pushis oncreateFlowState, not on each host handler, and it replaces the WebSocket ofserve(). Is this the correct place for the delivery seam?Not here: items, presence, barge-in or mobile push over Ably (the old spike). The epic removed them.
Spec · Decisions · Linear FIX-380 · epic FIX-2367 · builds on FIX-2426 (the bus) and FIX-2428 (the mint) · merges after human approval and required checks (contract)
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation and not a build plan. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.SPEC.md→ What's already here, and the debt — an existing primitive,method or prior design the change overlaps and doesn't name; something it adds that is debt
and isn't listed; a net verdict the tables don't support.
piece it considered, or that is a second mechanism for something we already have
(
orchestration.md).design.
Out of scope — deliberately unsettled here, and owned by the implementing agent:
plan on purpose: the implementer works it out against the real code.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
DECISIONS.md → Notes from reviewfor the implementer to weigh against real code. It will notbe argued with, and it will not be folded into the design prose. Please don't re-raise it: one
mention is enough.
The one exception is the POC. Line-level feedback on it is dropped, not recorded — there
is nothing for an implementer to weigh about code that isn't shipping. Feedback about its
direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
Generated by Claude Code