Repository navigation
feat(claude-code-style): open a thread as a sheet in threads mode #4798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat(claude-code-style): open a thread as a sheet in threads mode
Threads mode opened a thread by replacing the board in the right pane with an in-pane view and a back arrow. Session mode already opens a background task as a flyout sheet over the main thread. Threads mode now uses the same Sheet, and the board stays in the pane behind it. - Sheet takes its scroll feed from the opener instead of creating it, since the thread composer needs the same feed to scroll after a send. - ThreadView renders as a Sheet: the action row and Pin sit at the top of the body, the question, review card and composer in the footer. - ThreadsBoard no longer early-returns the thread view in place of the board. - Tests query the thread as a dialog and close it with the sheet's Close button; one new test covers opening, the board staying put, and Esc. - README describes the sheet. Supersedes the "thread view replaces the board" decision in FIX-2157's DECISIONS.md, which copied the original app's in-pane layout. The spec is left as history. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a task message contains a long URL or unbroken identifier, moving these entries into
Sheetremoves the previous feed's inheritedoverflow-wrap:anywhere. The sheet body has no equivalent rule, andEntry's user-message bubble only setswhitespace-pre-wrap, so text now overflows the bubble and requires horizontal scrolling instead of wrapping. Preserve the wrapping rule on the thread content when rendering it inside the sheet.Useful? React with 👍 / 👎.