Repository navigation
feat(claude-code-style): open a thread as a sheet in threads mode - #4798
Conversation
Threads mode opened a thread by replacing the board in the right pane with an in-pane view and a back arrow. Session mode already opens a background task as a flyout sheet over the main thread. Threads mode now uses the same Sheet, and the board stays in the pane behind it. - Sheet takes its scroll feed from the opener instead of creating it, since the thread composer needs the same feed to scroll after a send. - ThreadView renders as a Sheet: the action row and Pin sit at the top of the body, the question, review card and composer in the footer. - ThreadsBoard no longer early-returns the thread view in place of the board. - Tests query the thread as a dialog and close it with the sheet's Close button; one new test covers opening, the board staying put, and Esc. - README describes the sheet. Supersedes the "thread view replaces the board" decision in FIX-2157's DECISIONS.md, which copied the original app's in-pane layout. The spec is left as history. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture reviewRead the diff against 1. Sheet's
|
- Sheet takes an optional `feed`; it keeps its own when the opener does not send into the body. TasksPane reverts to its original shape. - Sheet holds onClose in a ref, so its Esc listener subscribes once. - Esc is ignored during IME composition, and yields to a dialog opened over the sheet (the keys sheet) when focus is in that dialog. - Sheet footer no longer sets muted, extra-small text for its contents. - ThreadView drops the redundant resetKey (the board keys it by task) and a duplicated Esc sentence. - Tests: a send from the thread composer scrolls the body smoothly; Esc during IME composition keeps the thread open; Esc with the keys sheet open closes only the keys sheet. layOutFeeds moves to test/feed-layout.ts so both screen tests share it. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1025de5188
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {work?.entries.map((entry) => ( | ||
| <Entry key={entry.id} entry={entry} mark={entry.kind === "user" ? feed.mine(entry.id) : undefined} /> | ||
| ))} |
There was a problem hiding this comment.
Preserve wrapping for task-thread messages
When a task message contains a long URL or unbroken identifier, moving these entries into Sheet removes the previous feed's inherited overflow-wrap:anywhere. The sheet body has no equivalent rule, and Entry's user-message bubble only sets whitespace-pre-wrap, so text now overflows the bubble and requires horizontal scrolling instead of wrapping. Preserve the wrapping rule on the thread content when rendering it inside the sheet.
Useful? React with 👍 / 👎.
…is FIX-2579's Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFwcBPHKUUUieLJosT
What
Threads mode (Projects view) now opens a thread as a sheet over the main thread, the same flyout session mode uses for background tasks. The board stays in the right pane. Before, a thread replaced the board with an in-pane view and a back arrow.
Why
Session mode and threads mode showed task detail in two different places. One flyout pattern for both reduces UI inconsistency.
Changes
Sheettakes its scroll feed from the opener. The thread composer needs the same feed to scroll after a send.ThreadViewrenders as aSheet. The action row and Pin sit at the top of the body. The question, review card and composer sit in the footer.ThreadsBoardno longer swaps itself out for the thread view.TasksPanecreates its own feed for the same reason.Decisions to know
DECISIONS.mdentry "the thread view replaces the board". That spec is left as history. An amendment is a separate follow-up.Testing
pnpm testinlabs/claude-code-style: 25 files, 173 tests pass.pnpm typecheckinlabs/claude-code-style: passes.🤖 Generated with Claude Code