Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (PR #4930, FIX-2479 s4)Read from the diff of the files listed on the PR, not a re-run of the tests. The approach (rename in place, no aliases, 1. Delete the dead matcher instead of renaming it (
|
Renames the harness-manager exports that said row or state for a read model, a resource or a lifecycle: HarnessReadinessView (and its schema), HarnessUsageView, HarnessUsageWindowView, PullRequestRecordResourceState, PullRequestWaitInput, PlaceStatus (and placeStatusSchema), and the internal RunRecordWrite and sessionTask. The stored place `state` field stays (D2). Rewords app-visible messages #19-#34: task where the row was the board's task, run record or resource elsewhere, including the scripted coder's steps and commit message. The changeset lists the renames and names the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
5c4b5bf to
ae33788
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae3378828e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return prompt.split("\n").find((line) => line.startsWith("Row ")) ?? "a row"; | ||
| /** A prompt line naming the task (`Task …`), else "a task". The manager's prompt writes no such line today. */ | ||
| function taskLine(prompt: string): string { | ||
| return prompt.split("\n").find((line) => line.startsWith("Task ")) ?? "a task"; |
There was a problem hiding this comment.
Update the task-line producer alongside the scripted matcher
Shift Manager's buildWorkerPrompt still emits Row ${run.issue}, phase ${run.phase}, attempt ${run.attempt}. (packages/shift-manager/teams/devteam/phase.mts:103), so its shared scripted harness now always writes the fallback a task into SCRIPTED-RUN.md. For a no-repository project containing a prior saved scripted run, subsequent tasks write identical content instead of a task-specific artifact. The completion check at phase.mts:359–363 rejects that unchanged file fingerprint, causing those tasks to exhaust their retries. Update the prompt producer together with this matcher, or normalize the existing identity-bearing line while preserving its task and attempt information.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed and fixed in 436ab05. Shift Manager's devteam prompt now writes Task <id>, phase <p>, attempt <n>. (phase.mts:103), which is the line the scripted harness reads. The two goal readers that matched the old Row line follow it, and the scripted harness's comment no longer says that no prompt writes the line.
fsd-checkout.test.ts now asserts that the committed SCRIPTED-RUN.md names its task. With the old prompt line it fails with expected 'A scripted run, no model.\n\na task' to match /\nTask \S+, phase …/, and with the fix it passes. The fix is merged up into s5 and s6.
Generated by Claude Code
…arness reads Codex found the scripted harness now looks for a `Task …` line while Shift Manager's devteam prompt still wrote `Row …`, so every scripted run wrote "a task" and a no-repository project's retries all wrote the same file. The prompt says Task; the two goal readers follow; fsd-checkout asserts the written file names its task (red with the old prompt line). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
The answer prompt writes a Task line too, so matching "\nTask " let the conversation's run commit at once instead of holding. Match the implement phase's line, the only one that names a phase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Code Review ✅ Approved 1 closed / 1 findings🔴 High risk · Renaming exported harness-manager types and schemas without aliases breaks existing consumers that import the old public names. Renames harness-manager's row-named exports and error messages to task, run record, and resource nouns (for example ✅ 1 closed✅ Bug: Feature-run check now also matches the answer prompt, so the hold is lost
VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Stacked on #4926 (FIX-2479 s3, orchestration and the hold marker). This PR's base is
fix/FIX-2479-s3-orchestration-and-hold; GitHub rebases it ontomainwhen #4926 merges. Not ready to merge while its base is notmain.The problem
Harness-manager still exported names that said row for things that aren't store rows: a harness's readiness and usage reads, a screen's pull-request record, the task a pull-request wait reads, and State for the place lifecycle. Sixteen of its error and status messages, including the scripted coder's steps and commit message, said row for a task or a run record (#19–#34).
What this does
Names. Every use in the tree moves with them: shift-manager, both labs' adapters, the UI registry's readiness component and its two lab copies.
HarnessReadinessRow,harnessReadinessRowSchemaHarnessReadinessView,harnessReadinessViewSchemaHarnessUsageRow,HarnessUsageWindowRowHarnessUsageView,HarnessUsageWindowViewPullRequestRecordRowPullRequestRecordResourceStatePullRequestWaitRowPullRequestWaitInputPlaceState,placeStateSchemaPlaceStatus,placeStatusSchema(the storedstatefield stays, D2)RunRowWrite,sessionRow(not exported)RunRecordWrite,sessionTaskThe pattern follows s1–s3:
*View/*Inputfor read models (as inTaskView,TaskViewInput),*ResourceStatefor stored data,*Statusfor a lifecycle.Messages feat(core): merge block-declared resources into flow scope configs #19–feat(core): add decomposer helper factory #34 say task where the row was the board's task, run record for the run record (
writeRunRow's target,RunRecordState), and resource for the worktree resource. Only the noun changes.Changeset
.changeset/resource-names.md: rows added to the rename table, harness-manager movedpatch→minor(breaking renames, pre-1.0), the message rule's coverage line names harness-manager, and the Docs line names each renamed root export forpackages/harness-manager/README.mdand the published harness-manager page.What's asked of you
Check the new names. The noun for each one was a judgement call.
Parts worth reviewing closely
writeRunRowwrites, the run record resource. "Run record" is the package's own name for it (runRecordCollection,RunRecordState). "The run's resource was opened" says less.taskLinenow looks for aTask …line and falls back to "a task". Nothing in the tree has ever written theRow …line the old matcher looked for, so it always fell back. The comment now says so. Removing the matcher is a separate cleanup.readRunRow,openRunRow,writeRunRowkeep their names. They aren't on this sub-PR's list.readRunRowis a root export, so say if it should move here.Verification
claim-board.spec.ts, which matches the reworded feat(core): implement helper.contextReducer for distill/denoise/compress #28 and fails on the old text. Labs: teammates 261 and claude-code-style 260. On the parallel run one claude-code-style test hit the 5s timeout; run alone,entry-lines.test.tsxpassed 14/14. ui 383. Shift-manager: 713 passed, and 1 failed (command.test.ts), which needs the builtdist-clientpages. That failure is the environment, not this change, and the same as on FIX-2479 s3: task names in orchestration, and a task's own hold says task #4926.node scripts/check-root-exports.mjs origin/mainPASS. The renamed exports clear only through the changeset's README mention, as expected.node scripts/check-retired-terms.mjsPASS.reviewran as a single pass and found nothing that must change. Folded: the scripted coder's comment.Spec: SPEC · DECISIONS · Linear FIX-2479 · below in the stack: #4926
Generated by Claude Code