Repository navigation
FIX-2479 s5: resource and task names in workforce and shift-manager - #4931
Conversation
…as task (red) Red before the change: the parse path and the row read return kind "row", newOwnHolds does not exist, the DevTool's waitPrompt shows an answered "task" question, and the Inbox lists the stored hold as "row". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…task Where a name said row for a task it says task: TaskDecision, TaskWritten, ticketClaimsTask, HandedOverTaskError, createTaskDispatch (blocks/dispatch-task), TaskDispatchOptions, TaskTruth/taskTruthOf, RefiledTask, isOpenTask, InboxTaskInput, TaskViewInput, TaskView/taskView (inbox/task-view), TaskViewStatus. RowHold is OwnHold (ownHoldSchema, isOwnHold, openOwnHolds, newOwnHolds, OwnHoldSource): the task's own hold, beside a run's mirrored stop. D1: a task's own hold is written source.kind "task". A stored "row" reads as "task" through withCurrentHoldMarker, at the hold schema's parse and at the collection's row read (both backings cast stored rows rather than parse them), so no reader branches on "row". refuseWithOpenHold follows; OwnerRunRefusal "no_row" is "no_resource". The DevTool reads a hold on its stop's marker. Messages #35-#69 say task. Changeset appended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…that don't parse Review fold: inboxItems and taskView take the caller's rows as given, so a replayed stream item or a raw read still carrying "row" lost its question. openUserHolds reads each hold through withCurrentHoldMarker first (red shown by the new inbox test before the change). Task-view prose follows the rename. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…s kept shapes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…ch options name Codex review (P2): pullRequestWait compared source.kind === "task" on holds a screen hands it unparsed (a replayed pre-upgrade task-change item), so a wait stored as "row" lost its PR-open line. isOwnHold and isExternalHold now read a hold through withCurrentHoldMarker and take an unparsed hold's shape, so openHolds, holdActorOf and externalHoldOf do too; pullRequestWait and the Inbox read call the predicate instead of comparing the word. Red shown by the new harness-manager and external-wait tests before the change. RowDispatchOptions is CreateTaskDispatchOptions, not TaskDispatchOptions: that name is one FIX-2083 retired (the runs-on-one-task sweep refused it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Renames the harness-manager exports that said row or state for a read model, a resource or a lifecycle: HarnessReadinessView (and its schema), HarnessUsageView, HarnessUsageWindowView, PullRequestRecordResourceState, PullRequestWaitInput, PlaceStatus (and placeStatusSchema), and the internal RunRecordWrite and sessionTask. The stored place `state` field stays (D2). Rewords app-visible messages #19-#34: task where the row was the board's task, run record or resource elsewhere, including the scripted coder's steps and commit message. The changeset lists the renames and names the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…d-hold' into fix/FIX-2479-s4-harness-manager
Renames the workforce exports that said row for a resource: WorkerResourceState
(and workerResourceStateSchema, parseWorkerResourceState answering { worker }),
StandardWorkerResourceState, ProjectResourceState, WorkerInventoryResourceState,
SubscriptionResourceState, WorkerMessageResourceState, ReportResourceState, the
internal MessageChainResourceState, projectResourcesAccessor/At and
subscriptionResourceKey; WorkerUsageView for the usage query's answer and
RoundTasks for a coordinator round's tasks. Shift-manager's board read model is
BoardTaskView (toBoardTaskView, allTasks, openTasks) and toMessages; ToolRow and
the rendered rows stay.
Rewords app-visible messages #71-#81 to say resource. The changeset lists the
renames and names packages/workforce/README.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second-look / architecture reviewMechanical rename, consistent with s1–s4. Approach is sound; no better shape for the rename itself. One real defect and a few smaller notes. Should fix
Worth considering
ArchitectureNo refactor opportunity worth taking here. The rename table is the right unit of work, and folding in deeper restructuring (e.g. merging Checked and fine
Base is still Generated by Claude Code |
Mechanism check (advisory, never blocks)Rows from
|
messageChainResourceStateSchema and projectResourcesAccessor have no consumers outside their own modules, so they stop being exported. The roster's rendered list line keeps its *Row name and no longer shadows workforce's WorkerResourceState type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…ame) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
…9) into s5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UNkLD7mJaky2QRikkQ8Z4
Code Review ✅ Approved 2 closed / 2 findings🔴 High risk · Renaming exported workforce and shift-manager types and functions without aliases breaks downstream imports and could prevent dependent applications from building. Renames workforce and shift-manager stored-data and read-model exports from *Row to *ResourceState or *View names, with matching messages and changeset updates. Roster's list-row component was renamed to WorkerResourceState, which was resolved this session. No issues found. ✅ 2 closed✅ Quality: Roster's list-row component renamed to WorkerResourceState
Closed: Quality: Workforce README still documents the retired row names
VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Stacked on #4930 (FIX-2479 s4, harness-manager). This PR's base is
fix/FIX-2479-s4-harness-manager; GitHub rebases it ontomainwhen #4930 merges. Not ready to merge while its base is notmain.The problem
Workforce still exported names that said row for stored data: a worker, a project, the inventory's worker, a subscription, a message in the log, an error report. It also used row for the usage query's answer and for a coordinator round's tasks. Shift-manager's board read model was
BoardRow. Eleven workforce errors and tool descriptions said row for a resource (#71–#81).What this does
Names. Every use in the tree moves with them, including the teammates lab's adapter and five goals.
WorkerRow,workerRowSchemaWorkerResourceState,workerResourceStateSchemaparseWorkerRow→{ row }parseWorkerResourceState→{ worker }StandardWorkerRow,standardWorkerRowSchema,standardWorkerRow()StandardWorkerResourceState,standardWorkerResourceStateSchema,standardWorkerResourceState()ProjectRow,projectRowSchemaProjectResourceState,projectResourceStateSchemaprojectRowsAccessor,projectRowsAt(not exported)projectResourcesAccessor,projectResourcesAtWorkerInventoryRow,workerInventoryRowSchemaWorkerInventoryResourceState,workerInventoryResourceStateSchemaSubscriptionRow,subscriptionRowSchema,subscriptionRowKeySubscriptionResourceState,subscriptionResourceStateSchema,subscriptionResourceKeyWorkerMessageRow,workerMessageRowSchema(root and/browser)WorkerMessageResourceState,workerMessageResourceStateSchemaMessageChainRow,messageChainRowSchema(not exported)MessageChainResourceState,messageChainResourceStateSchemaWorkerUsageRow(and its two internal schemas)WorkerUsageView(workerUsageViewSchema,workerSourceSpendSchema)ReportRow,reportRowSchemaReportResourceState,reportResourceStateSchemaRoundRows,roundRowsOf(not exported)RoundTasks,roundTasksOfBoardRow,toBoardRowBoardTaskView,toBoardTaskViewallRows,openRows,toMessageRowsallTasks,openTasks,toMessagesSame pattern as s1–s4:
*ResourceStatefor stored data,*Viewfor a read model (as inHarnessUsageView,TaskView).ToolRowand the rendered list rows stay. None of the new names is retired ingoals/**/rules.mjsordocs/contributing/glossary.mjs.Messages feat(thought-fabric): implement working memory (FIX-199) #71–perf: reduce server response latency and improve perceived performance #81 say resource: "the worker resources could not be written", "declares no project resources", "a document seeds a resource". Only the noun changes. feat(devtool): Redesign stream view for chat-first readability (FIX-278) #78 reads "a resource seeds stored state that then becomes the source", because "a resource seeds a resource" says nothing.
Changeset
.changeset/resource-names.md: workforce added atminor, its rows in the rename table, workforce added to the message rule's coverage line, and the Docs line names each renamed root export forpackages/workforce/README.mdand the published messaging-workers page.What's asked of you
Check the new names. As in s4, picking each noun was a judgement call.
Parts worth reviewing closely
parseWorkerResourceStateanswers{ worker }now, not{ row }. The return shape is part of the export, and{ row }kept the retired word. Its two callers are in workforce.BoardTaskViewrather thanBoardTask. The teammates lab already has its ownBoardTask. The read model followsTaskView.ConversationBoards.rowsand the localrowvariables are unchanged: they aren't on this sub-PR's list.WorkerRowinterface, claude-code-style'sProjectRow, and the goals' localBoardRow/ProjectRow/WorkerRoware declared in those files and aren't workforce exports. The rule's whole-tree turn will rule on them.Verification
inventory-binder.test.tson the reworded Docs site navigation structure #74. Shift-manager 714 passed and 5 skipped (81 files), withdist-clientbuilt first socommand.testruns. teammates lab 261 passed.node scripts/check-root-exports.mjs origin/main: PASS. The renamed workforce roots pass only because the changeset names them for the README, as intended.node scripts/check-retired-terms.mjs: PASS.node goals/workforce-coordination/runs-on-one-task/sweep.mjs: PASS.allRows/openRowsin devtool and the goals are untouched. I fixed the doc comments on the renamed declarations that still said row.Spec: SPEC · DECISIONS · Linear FIX-2479 · below in the stack: #4930
Generated by Claude Code