Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Upgrades to felt (running on multiple modes, multiple backends, single test target option) #22260

Merged
nturgut merged 16 commits into from
Nov 12, 2020
Merged

Upgrades to felt (running on multiple modes, multiple backends, single test target option) #22260

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
40848e0
testing running the tests on all build modes
Nov 3, 2020
f2213f3
don't run debug mode on other browsers
Nov 3, 2020
75465a3
fix platform message test failures
Nov 3, 2020
eae835f
some cleanup. change dispose platform channel message
Nov 3, 2020
5889d0c
adding flags to control the integration tests better with felt
Nov 3, 2020
8117c92
running tests by target name, selecting web rendering backend
Nov 4, 2020
3d7e145
fix conditions
Nov 4, 2020
0f13714
carrying some conditions to helper methods. Adding comments
Nov 4, 2020
dfb5353
create a blocked list for failing canvaskit test
Nov 4, 2020
78fad8e
parse parameters before all integration tests
Nov 4, 2020
9b5f830
Give better warning to developers for tests that are blocked for CI
Nov 9, 2020
2598808
address some reviwer comments (more remains)
Nov 9, 2020
1812790
remove named parameters
Nov 9, 2020
73fab26
also run with auto mode
Nov 10, 2020
c997661
add verbose option
Nov 11, 2020
f373ba6
reduce the number of tests running. skip url_test for now
Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove named parameters
  • Loading branch information
nturgut committed Nov 10, 2020
commit 18127900828a56da52ac6e8645ff01f53d231a88
47 changes: 23 additions & 24 deletions lib/web_ui/dev/integration_tests_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,14 @@ class IntegrationTestsManager {
IntegrationArguments.fromBrowser(_browser);
final int exitCode = await runProcess(
executable,
arguments.getTestArguments(testName, mode,
isCanvaskitBackend: canvaskitBackend),
arguments.getTestArguments(testName, mode, canvaskitBackend),
workingDirectory: directory.path,
environment: enviroment,
);

if (exitCode != 0) {
final String command = arguments.getCommandToRun(testName, mode);
final String command =
arguments.getCommandToRun(testName, mode, canvaskitBackend);
io.stderr
.writeln('ERROR: Failed to run test. Exited with exit code $exitCode'
'. To run $testName locally use the following command:'
Expand Down Expand Up @@ -422,16 +422,16 @@ abstract class IntegrationArguments {
}
}

List<String> getTestArguments(String testName, String mode,
{bool isCanvaskitBackend = false});
List<String> getTestArguments(
String testName, String mode, bool isCanvaskitBackend);

String getCommandToRun(String testName, String mode);
String getCommandToRun(String testName, String mode, bool isCanvaskitBackend);
}

/// Arguments to give `flutter drive` to run the integration tests on Chrome.
class ChromeIntegrationArguments extends IntegrationArguments {
List<String> getTestArguments(String testName, String mode,
{bool isCanvaskitBackend = false}) {
List<String> getTestArguments(
String testName, String mode, bool isCanvaskitBackend) {
return <String>[
'drive',
'--target=test_driver/${testName}',
Expand All @@ -446,8 +446,8 @@ class ChromeIntegrationArguments extends IntegrationArguments {
];
}

String getCommandToRun(String testName, String mode,
{bool isCanvaskitBackend = false}) {
String getCommandToRun(
String testName, String mode, bool isCanvaskitBackend) {
String statementToRun = 'flutter drive '
'--target=test_driver/${testName} -d web-server --$mode '
'--browser-name=chrome --local-engine=host_debug_unopt';
Expand All @@ -464,8 +464,8 @@ class ChromeIntegrationArguments extends IntegrationArguments {

/// Arguments to give `flutter drive` to run the integration tests on Firefox.
class FirefoxIntegrationArguments extends IntegrationArguments {
List<String> getTestArguments(String testName, String mode,
{bool isCanvaskitBackend = false}) {
List<String> getTestArguments(
String testName, String mode, bool isCanvaskitBackend) {
return <String>[
'drive',
'--target=test_driver/${testName}',
Expand All @@ -479,11 +479,10 @@ class FirefoxIntegrationArguments extends IntegrationArguments {
];
}

String getCommandToRun(String testName, String mode,
{bool isCanvaskitBackend = false}) {
String getCommandToRun(
String testName, String mode, bool isCanvaskitBackend) {
final String arguments =
getTestArguments(testName, mode, isCanvaskitBackend: isCanvaskitBackend)
.join(' ');
getTestArguments(testName, mode, isCanvaskitBackend).join(' ');
return 'flutter $arguments';
}
}
Expand All @@ -492,8 +491,8 @@ class FirefoxIntegrationArguments extends IntegrationArguments {
class SafariIntegrationArguments extends IntegrationArguments {
SafariIntegrationArguments();

List<String> getTestArguments(String testName, String mode,
{bool isCanvaskitBackend = false}) {
List<String> getTestArguments(
String testName, String mode, bool isCanvaskitBackend) {
return <String>[
'drive',
'--target=test_driver/${testName}',
Expand All @@ -506,11 +505,10 @@ class SafariIntegrationArguments extends IntegrationArguments {
];
}

String getCommandToRun(String testName, String mode,
{bool isCanvaskitBackend = false}) {
String getCommandToRun(
String testName, String mode, bool isCanvaskitBackend) {
final String arguments =
getTestArguments(testName, mode, isCanvaskitBackend: isCanvaskitBackend)
.join(' ');
getTestArguments(testName, mode, isCanvaskitBackend).join(' ');
return 'flutter $arguments';
}
}
Expand Down Expand Up @@ -538,9 +536,10 @@ class IntegrationTestsArgumentParser {
/// `blockedTestsListsMapForModes` list for the relevant compile mode.
String buildMode;

/// Whether to use html or canvaskit backend.
/// Whether to use html, canvaskit or auto for web renderer.
///
/// If not set html rendering backend will be used.
/// If not set all backends will be used one after another for integration
/// tests. If set only the provided option will be used.
String webRenderer;

void populateOptions(ArgParser argParser) {
Expand Down