Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Upgrades to felt (running on multiple modes, multiple backends, single test target option) #22260

Merged
nturgut merged 16 commits into from
Nov 12, 2020
Merged

Upgrades to felt (running on multiple modes, multiple backends, single test target option) #22260

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
40848e0
testing running the tests on all build modes
Nov 3, 2020
f2213f3
don't run debug mode on other browsers
Nov 3, 2020
75465a3
fix platform message test failures
Nov 3, 2020
eae835f
some cleanup. change dispose platform channel message
Nov 3, 2020
5889d0c
adding flags to control the integration tests better with felt
Nov 3, 2020
8117c92
running tests by target name, selecting web rendering backend
Nov 4, 2020
3d7e145
fix conditions
Nov 4, 2020
0f13714
carrying some conditions to helper methods. Adding comments
Nov 4, 2020
dfb5353
create a blocked list for failing canvaskit test
Nov 4, 2020
78fad8e
parse parameters before all integration tests
Nov 4, 2020
9b5f830
Give better warning to developers for tests that are blocked for CI
Nov 9, 2020
2598808
address some reviwer comments (more remains)
Nov 9, 2020
1812790
remove named parameters
Nov 9, 2020
73fab26
also run with auto mode
Nov 10, 2020
c997661
add verbose option
Nov 11, 2020
f373ba6
reduce the number of tests running. skip url_test for now
Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't run debug mode on other browsers
  • Loading branch information
nturgut committed Nov 10, 2020
commit f2213f39b8b403732144ee711df71e388d92c399
4 changes: 3 additions & 1 deletion lib/web_ui/dev/integration_tests_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ class IntegrationTestsManager {

int numberOfPassedTests = 0;
int numberOfFailedTests = 0;
final Set<String> buildModes = {'debug', 'profile', 'release'};
final Set<String> buildModes = _browser == 'chrome'
? {'debug', 'profile', 'release'}
: {'profile', 'release'};
for (String fileName in e2eTestsToRun) {
for (String mode in buildModes) {
if (!blockedTestsListsMapForModes[mode].contains(fileName)) {
Expand Down