This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enabling semantics tests for safari, ios-safari and firefox #22662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Nov 23, 2020
| // TODO(nurhan): https://github.com/flutter/flutter/issues/50754 | ||
| skip: browserEngine == BrowserEngine.webkit || | ||
| browserEngine == BrowserEngine.edge); | ||
| skip: browserEngine == BrowserEngine.edge); |
Contributor
There was a problem hiding this comment.
This file isn't running on edge anyway.
Contributor
Author
There was a problem hiding this comment.
That's true. I think I'll create another PR for removing all edge requirements though. Since our Edge testing code is for legacy edge. If we change it to new Edge all should pass (I hope :) )
nturgut
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 24, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…22662) * enable safari tests for almost all the methods for semantics tests * enable almost all semantics tests for firefox * Safari desktop have different scroll max values for different versions * fix assert
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests on the semantics_test.dart was only running on chrome. This PR enables most of the unit test methods (excluding 2 of them) on safari, ios-safari and firefox
Related Issues
flutter/flutter#50590
flutter/flutter#46638
Tests
This PR is for enabling more unit tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.