Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enabling semantics tests for safari, ios-safari and firefox #22662

Merged
nturgut merged 4 commits into from
Nov 23, 2020
Merged

Enabling semantics tests for safari, ios-safari and firefox #22662

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e89a293
enable safari tests for almost all the methods for semantics tests
Nov 21, 2020
5a15497
enable almost all semantics tests for firefox
Nov 21, 2020
3c3b8d2
Safari desktop have different scroll max values for different versions
Nov 23, 2020
365b23c
fix assert
Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix assert
  • Loading branch information
nturgut committed Nov 23, 2020
commit 365b23c8963a9693ef047bb4a609ed815495a2bc
2 changes: 1 addition & 1 deletion lib/web_ui/test/engine/semantics/semantics_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ void _testHorizontalScrolling() {
operatingSystem == OperatingSystem.macOs) {
browserMaxScrollDiff = 1;
}
expect(scrollable.scrollLeft, 10 - browserMaxScrollDiff);
expect(scrollable.scrollLeft >= (10 - browserMaxScrollDiff), isTrue);

scrollable.scrollLeft = 20;
expect(scrollable.scrollLeft, 20);
Expand Down