Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 23, 2020

Description

The tests were still flaky, see: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8863001188407459360/+/steps/Host_Tests_for_host_profile/0/stdout?format=raw

Although I couldn't repro this locally or on a cloud linux box, there is clearly a race condition that might cause the same failure, due to the below reason.
There was an automatically resubmitted frame due to kResubmitFrame. And the failed check is not running on raster thread, so it could happen before or after the 2nd frame's SubmitFrame is called. Hence the flake.

The solution is to remove those similar checks, which is really unnecessary. Instead, we just need to make sure there is only a single external_view_embedder->GetSubmittedFrameCount() during the 2 frames before and after resubmitting.

Related Issues

Fixes flutter/flutter#66056

Tests

I added the following tests:

Updated tests such as:
ShellTest::SkipAndSubmitFrame
ShellTest::ReSubmitFrame
ShellTest::DiscardLayerTreeOnResize

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@google-cla google-cla bot added the cla: yes label Nov 23, 2020
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 23, 2020
@fluttergithubbot fluttergithubbot merged commit 054bfef into flutter:master Nov 23, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShellTest.SkipAndSubmitFrame is flaky

3 participants