This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix shell_unittests flakes related to external_view_embedder #22683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests were still flaky, see: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8863001188407459360/+/steps/Host_Tests_for_host_profile/0/stdout?format=raw
Although I couldn't repro this locally or on a cloud linux box, there is clearly a race condition that might cause the same failure, due to the below reason.
There was an automatically resubmitted frame due to
kResubmitFrame. And the failed check is not running on raster thread, so it could happen before or after the 2nd frame's SubmitFrame is called. Hence the flake.The solution is to remove those similar checks, which is really unnecessary. Instead, we just need to make sure there is only a single
external_view_embedder->GetSubmittedFrameCount()during the 2 frames before and after resubmitting.Related Issues
Fixes flutter/flutter#66056
Tests
I added the following tests:
Updated tests such as:
ShellTest::SkipAndSubmitFrame
ShellTest::ReSubmitFrame
ShellTest::DiscardLayerTreeOnResize
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.