Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix shell_unittests flakes related to external_view_embedder #22683

Merged
fluttergithubbot merged 3 commits into from
Nov 23, 2020
Merged

Fix shell_unittests flakes related to external_view_embedder #22683

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bd4ca9
fix flake
Nov 23, 2020
dfbfe80
more comment
Nov 23, 2020
3f77f55
format
Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more comment
  • Loading branch information
Chris Yang committed Nov 23, 2020
commit dfbfe803b28da4b8d3ad26dc5c849a8269be6ddb
2 changes: 2 additions & 0 deletions shell/common/shell_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,6 +2101,8 @@ TEST_F(ShellTest, DiscardLayerTreeOnResize) {
ASSERT_TRUE(raster_thread_merger_ref->IsMerged());

end_frame_latch.Wait();
// 2 frames are submitted because `kResubmitFrame`, but only the 2nd frame should be
// submitted with `external_view_embedder`, hence the below check.
ASSERT_EQ(1, external_view_embedder->GetSubmittedFrameCount());
ASSERT_EQ(expected_size, external_view_embedder->GetLastSubmittedFrameSize());

Expand Down