Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
races
  • Loading branch information
Emmanuel Garcia committed Jun 3, 2022
commit b249ed5068ff17f95f191033bea62dab171db617
3 changes: 2 additions & 1 deletion testing/scenario_app/bin/android_integration_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ void main(List<String> args) async {
});

await step('Killing logcat process...', () async {
logcatProcess.kill();
final bool delivered = logcatProcess.kill(ProcessSignal.sigkill);
assert(delivered);
});

await step('Dumping logcat (Errors only)...', () async {
Expand Down
4 changes: 2 additions & 2 deletions testing/scenario_app/bin/utils/process_manager_extension.dart
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ Future<int> pipeProcessStreams(Process process, {StringSink? out}) async {
await stdoutCompleter.future;
await stderrCompleter.future;

stderrSub.cancel();
stdoutSub.cancel();
await stderrSub.cancel();
await stdoutSub.cancel();
return exitCode;
}

Expand Down