Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable scenario tests on Android #33574

Merged
fluttergithubbot merged 30 commits into from
Jun 3, 2022
Merged

Re-enable scenario tests on Android #33574

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
20f7e76
Re-enable scenario tests on Android
May 23, 2022
c19d233
Disable MSAAx4 test
May 24, 2022
24ed36c
clear logs
May 24, 2022
7c0019b
fix race in test
May 24, 2022
3f3886e
retrigger
May 27, 2022
2625afc
handle null bitmap
May 27, 2022
b249ed5
races
May 27, 2022
1e47e0d
remove
May 27, 2022
e375904
race
May 27, 2022
6ceae9c
Add exit code
May 27, 2022
dc610e7
Use the Skia gold client
Jun 1, 2022
400529c
Fix dependencies
Jun 1, 2022
48b3b9b
wait for skia gold comparisons
Jun 1, 2022
5c51644
offset
Jun 1, 2022
4bd33bd
fix issue
Jun 1, 2022
60e75ba
dump logcat and symbolize
Jun 1, 2022
30886ba
fix SIGSEGV
Jun 1, 2022
828239d
iOS fixes
Jun 2, 2022
4ac55d1
ignore if the sink is closed
Jun 2, 2022
fecc650
add extension to test name
Jun 2, 2022
54c79ab
fix id
Jun 2, 2022
a040b24
retrigger
Jun 2, 2022
a4b71d2
use transformer to account for slow producer
Jun 2, 2022
8403523
comments
Jun 2, 2022
04e36ad
update goldens
Jun 2, 2022
d8f612a
remove async
Jun 2, 2022
0312c76
Remove async onBeginFrame
Jun 3, 2022
6e5049a
ensure fullscreen
Jun 3, 2022
7f7637a
remove old files
Jun 3, 2022
2d5232c
format
Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable MSAAx4 test
  • Loading branch information
Emmanuel Garcia committed Jun 3, 2022
commit c19d2337b60ff25cd7e196c53beaea89891f9408
2 changes: 1 addition & 1 deletion .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ targets:
runIf:
- DEPS
- .ci.yaml
- testing/scenario_app/**
- testing/**
- shell/platforms/android/**

- name: Linux Benchmarks
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/android/android_context_gl_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ TEST(AndroidSurfaceGL, CreateSnapshopSurfaceWhenOnscreenSurfaceIsNull) {
EXPECT_NE(android_surface->GetOnscreenSurface(), nullptr);
}

TEST(AndroidContextGl, MSAAx4) {
// TODO(https://github.com/flutter/flutter/issues/104463): Flaky test.
TEST(AndroidContextGl, DISABLED_MSAAx4) {
GrMockOptions main_context_options;
sk_sp<GrDirectContext> main_context =
GrDirectContext::MakeMock(&main_context_options);
Expand Down