Move firebase test lab logs to a staging bucket #35149
Conversation
|
@dnfield Are we still running firebase test lab test in engine CI? |
|
We run firebase test lab but we don't use Cirrus at all.. This script gets invoked from https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine.py#547 |
Got it. For this case, we will need to update the bucket then. For context: we are moving the log location from |
keyonghan
changed the title
|
Updated title and body to remove cirrus keywords. |
ci/firebase_testlab.py
Outdated
| import sys | ||
|
|
||
| BUCKET = 'gs://flutter_firebase_testlab' | ||
| BUCKET = 'gs://flutter_firebase_testlab_staging' |
There was a problem hiding this comment.
nit: should this just be an env variable coming from LUCI?
There was a problem hiding this comment.
SGTM. Let's put the project as an env as well. /cc @ricardoamador
|
@keyonghan @dnfield to circle back the bucket and project have been updated in the firebase_testlab.py script in the engine repo. Do we need to change the bucket in the invoking recipe script? That one is using flutter_infra_release. |
After supporting env here, we need to update recipes to setup these two variable values there. |
|
We should hold this until the recipes env support. |
| BUCKET = os.environ['STORAGE_BUCKET'] | ||
| PROJECT = os.environ['GCP_PROJECT'] |
There was a problem hiding this comment.
These should either get defaulted to something sensible or there should be an error thrown if they're not set.
|
The Linux Android AOT Engine test will fail until the recipes change has been merged. |
* Updated the bucket for firebase testing to the staging project. * updated the project. * Adding environment variables for gcp project and storage bucket. * Updated to exit if environment variables were not provided.
* Updated the bucket for firebase testing to the staging project. * updated the project. * Adding environment variables for gcp project and storage bucket. * Updated to exit if environment variables were not provided.
* Updated the bucket for firebase testing to the staging project. * updated the project. * Adding environment variables for gcp project and storage bucket. * Updated to exit if environment variables were not provided.
* Updated the bucket for firebase testing to the staging project. * updated the project. * Adding environment variables for gcp project and storage bucket. * Updated to exit if environment variables were not provided.
* Updated the bucket for firebase testing to the staging project. * updated the project. * Adding environment variables for gcp project and storage bucket. * Updated to exit if environment variables were not provided.
* Updated the bucket for firebase testing to the staging project. * updated the project. * Adding environment variables for gcp project and storage bucket. * Updated to exit if environment variables were not provided.
3 participants
Description
Save logs to staging for firebase tasks.
Issues
This addresses and OKR for this quarter for security improvements.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.