Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move firebase test lab logs to a staging bucket #35149

Merged
ricardoamador merged 5 commits into from
Aug 4, 2022
Merged

Move firebase test lab logs to a staging bucket #35149

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a333e71
Updated the bucket for firebase testing to the staging project.
Aug 3, 2022
e6efd02
updated the project.
Aug 3, 2022
0a099e7
Merge remote-tracking branch 'upstream/main' into cirrus_firebase_log…
Aug 3, 2022
e13ab65
Adding environment variables for gcp project and storage bucket.
Aug 4, 2022
3b397cd
Updated to exit if environment variables were not provided.
Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ci/firebase_testlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
import subprocess
import sys

BUCKET = 'gs://flutter_firebase_testlab'
BUCKET = os.environ['STORAGE_BUCKET']
PROJECT = os.environ['GCP_PROJECT']
Copy link
Contributor

@dnfield dnfield Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should either get defaulted to something sensible or there should be an error thrown if they're not set.

Copy link
Contributor Author

@ricardoamador ricardoamador Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

script_dir = os.path.dirname(os.path.realpath(__file__))
buildroot_dir = os.path.abspath(os.path.join(script_dir, '..', '..'))
out_dir = os.path.join(buildroot_dir, 'out')
Expand All @@ -28,7 +29,7 @@ def run_firebase_test(apk, results_dir):
[
'gcloud',
'--project',
'flutter-infra',
PROJECT,
'firebase',
'test',
'android',
Expand Down