remove disabled rasterization support

impeller/entity/contents/content_context.cc

@@ -163,22 +163,6 @@ static std::unique_ptr<PipelineT> CreateDefaultPipeline(
   return std::make_unique<PipelineT>(context, desc);
 }
 
-template <typename PipelineT>
-static std::unique_ptr<PipelineT> CreateDefaultNonRenderingPipeline(
-    const Context& context) {
-  auto desc = PipelineT::Builder::MakeDefaultPipelineDescriptor(context);
-  if (!desc.has_value()) {
-    return nullptr;
-  }
-  // Apply default ContentContextOptions to the descriptor.
-  const auto default_color_fmt =
-      context.GetCapabilities()->GetDefaultColorFormat();
-  ContentContextOptions{.color_attachment_pixel_format = default_color_fmt,
-                        .enable_rasterization = false}
-      .ApplyToPipelineDescriptor(*desc);
-  return std::make_unique<PipelineT>(context, desc);
-}
-
 ContentContext::ContentContext(std::shared_ptr<Context> context)
     : context_(std::move(context)),
       tessellator_(std::make_shared<Tessellator>()),
@@ -314,11 +298,6 @@ ContentContext::ContentContext(std::shared_ptr<Context> context)
   porter_duff_blend_pipelines_[{}] =
       CreateDefaultPipeline<PorterDuffBlendPipeline>(*context_);
 
-  if (context_->GetCapabilities()->SupportsDisabledRasterization()) {
-    point_field_geometry_pipelines_[{}] =
-        CreateDefaultNonRenderingPipeline<PointFieldGeometryPipeline>(
-            *context_);
-  }
   if (context_->GetCapabilities()->SupportsCompute()) {
     auto pipeline_desc =
         PointsComputeShaderPipeline::MakeDefaultPipelineDescriptor(*context_);

impeller/entity/contents/content_context.h

@@ -278,8 +278,6 @@ using FramebufferBlendSoftLightPipeline =
                     FramebufferBlendSoftlightFragmentShader>;
 
 /// Geometry Pipelines
-using PointFieldGeometryPipeline =
-    RenderPipelineT<PointsVertexShader, NonRenderingFragment>;
 using PointsComputeShaderPipeline = ComputePipelineBuilder<PointsComputeShader>;
 
 /// Pipeline state configuration.
@@ -669,12 +667,6 @@ class ContentContext {
     return GetPipeline(framebuffer_blend_softlight_pipelines_, opts);
   }
 
-  std::shared_ptr<Pipeline<PipelineDescriptor>> GetPointFieldGeometryPipeline(
-      ContentContextOptions opts) const {
-    FML_DCHECK(GetDeviceCapabilities().SupportsDisabledRasterization());
-    return GetPipeline(point_field_geometry_pipelines_, opts);
-  }
-
   std::shared_ptr<Pipeline<ComputePipelineDescriptor>> GetPointComputePipeline()
       const {
     FML_DCHECK(GetDeviceCapabilities().SupportsCompute());
@@ -806,8 +798,6 @@ class ContentContext {
   mutable std::shared_ptr<Pipeline<ComputePipelineDescriptor>>
       point_field_compute_pipelines_;
 
-  mutable Variants<PointFieldGeometryPipeline> point_field_geometry_pipelines_;
-
   template <class TypedPipeline>
   std::shared_ptr<Pipeline<PipelineDescriptor>> GetPipeline(
       Variants<TypedPipeline>& container,

impeller/entity/geometry.cc

@@ -843,8 +843,6 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
 
   using PS = PointsComputeShader;
 
-  // using VS = PointFieldGeometryPipeline::VertexShader;
-
   auto points_data = host_buffer.Emplace(
       points_.data(), points_.size() * sizeof(Point), alignof(Point));
 
@@ -859,14 +857,6 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
   cmd.label = "Points Geometry";
   cmd.pipeline = renderer.GetPointComputePipeline();
 
-  // auto options = OptionsFromPass(pass);
-  // options.blend_mode = BlendMode::kSource;
-  // options.stencil_compare = CompareFunction::kAlways;
-  // options.stencil_operation = StencilOperation::kKeep;
-  // options.enable_rasterization = false;
-  // options.sample_count = SampleCount::kCount1;
-  // cmd.pipeline = renderer.GetPointFieldGeometryPipeline(options);
-
   PS::FrameInfo frame_info;
   frame_info.count = points_.size();
   frame_info.radius = radius;
@@ -892,30 +882,6 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
     }
   }
 
-  // cmd.BindVertices(vtx_buffer);
-
-  // // Ensure correct synchronization by submitting vertex computation into
-  // // a different render pass.
-  // {
-  //   auto render_target = RenderTarget::CreateOffscreen(
-  //       *renderer.GetContext(),  // context
-  //       {1, 1},                  // size
-  //       "Geometry Snapshot",     // label
-  //       RenderTarget::
-  //           kDefaultColorAttachmentConfigNonRendering,  //
-  //           color_attachment_config
-  //       std::nullopt  // stencil_attachment_config
-  //   );
-  //   auto cmd_buffer = renderer.GetContext()->CreateCommandBuffer();
-  //   auto vertex_render_pass = cmd_buffer->CreateRenderPass(render_target);
-
-  //   if (!vertex_render_pass->AddCommand(std::move(cmd)) ||
-  //       !vertex_render_pass->EncodeCommands() ||
-  //       !cmd_buffer->SubmitCommands()) {
-  //     return {};
-  //   }
-  // }
-
   return {
       .type = PrimitiveType::kTriangle,
       .vertex_buffer = {.vertex_buffer = {.buffer = buffer,

impeller/renderer/pipeline_builder.h

@@ -16,15 +16,6 @@
 
 namespace impeller {
 
-class NonRenderingFragment {
- public:
-  static constexpr std::string_view kLabel = "";
-  static constexpr std::string_view kEntrypointName = "";
-  static constexpr ShaderStage kShaderStage = ShaderStage::kFragment;
-  static constexpr std::string_view kGeneratorName = "";
-  static constexpr std::array<DescriptorSetLayout, 0> kDescriptorSetLayouts{};
-};
-
 //------------------------------------------------------------------------------
 /// @brief      An optional (but highly recommended) utility for creating
 ///             pipelines from reflected shader information.
@@ -69,40 +60,22 @@ struct PipelineBuilder {
       const Context& context,
       PipelineDescriptor& desc) {
     // Setup debug instrumentation.
-    if (!std::is_same<FragmentShader, NonRenderingFragment>::value) {
-      desc.SetLabel(SPrintF("%s Pipeline", FragmentShader::kLabel.data()));
-    } else {
-      desc.SetLabel(SPrintF("%s Pipeline", VertexShader::kLabel.data()));
-    }
+    desc.SetLabel(SPrintF("%s Pipeline", FragmentShader::kLabel.data()));
 
     // Resolve pipeline entrypoints.
     {
       auto vertex_function = context.GetShaderLibrary()->GetFunction(
           VertexShader::kEntrypointName, ShaderStage::kVertex);
-
-      std::shared_ptr<const ShaderFunction> fragment_function;
-      if (!std::is_same<FragmentShader, NonRenderingFragment>::value) {
-        fragment_function = context.GetShaderLibrary()->GetFunction(
-            FragmentShader::kEntrypointName, ShaderStage::kFragment);
-      }
-
-      if (!std::is_same<FragmentShader, NonRenderingFragment>::value) {
-        if (!vertex_function || !fragment_function) {
-          VALIDATION_LOG << "Could not resolve pipeline entrypoint(s) '"
-                         << VertexShader::kEntrypointName << "' and '"
-                         << FragmentShader::kEntrypointName
-                         << "' for pipeline named '" << VertexShader::kLabel
-                         << "'.";
-          return false;
-        }
-      } else {
-        if (!vertex_function) {
-          VALIDATION_LOG << "Could not resolve pipeline entrypoint(s) '"
-                         << FragmentShader::kEntrypointName
-                         << "' for pipeline named '" << VertexShader::kLabel
-                         << "'.";
-          return false;
-        }
+      auto fragment_function = context.GetShaderLibrary()->GetFunction(
+          FragmentShader::kEntrypointName, ShaderStage::kFragment);
+
+      if (!vertex_function || !fragment_function) {
+        VALIDATION_LOG << "Could not resolve pipeline entrypoint(s) '"
+                       << VertexShader::kEntrypointName << "' and '"
+                       << FragmentShader::kEntrypointName
+                       << "' for pipeline named '" << VertexShader::kLabel
+                       << "'.";
+        return false;
       }
 
       desc.AddStageEntrypoint(std::move(vertex_function));

impeller/renderer/render_target.h

@@ -53,12 +53,6 @@ class RenderTarget final {
       .store_action = StoreAction::kDontCare,
       .clear_color = Color::BlackTransparent()};
 
-  static constexpr AttachmentConfig kDefaultColorAttachmentConfigNonRendering =
-      {.storage_mode = StorageMode::kDevicePrivate,
-       .load_action = LoadAction::kDontCare,
-       .store_action = StoreAction::kDontCare,
-       .clear_color = Color::BlackTransparent()};
-
   static RenderTarget CreateOffscreen(
       const Context& context,
       ISize size,