capabilities and license

ci/licenses_golden/licenses_flutter

@@ -1295,6 +1295,7 @@ ORIGIN: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_alp
 ORIGIN: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_alpha_nodecal.frag + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_noalpha_decal.frag + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_noalpha_nodecal.frag + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/impeller/entity/shaders/geometry/points.vert + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/shaders/glyph_atlas.frag + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/shaders/glyph_atlas.vert + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/shaders/glyph_atlas_sdf.frag + ../../../flutter/LICENSE
@@ -3889,6 +3890,7 @@ FILE: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_alpha
 FILE: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_alpha_nodecal.frag
 FILE: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_noalpha_decal.frag
 FILE: ../../../flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur_noalpha_nodecal.frag
+FILE: ../../../flutter/impeller/entity/shaders/geometry/points.vert
 FILE: ../../../flutter/impeller/entity/shaders/glyph_atlas.frag
 FILE: ../../../flutter/impeller/entity/shaders/glyph_atlas.vert
 FILE: ../../../flutter/impeller/entity/shaders/glyph_atlas_sdf.frag

impeller/entity/contents/content_context.cc

@@ -311,8 +311,12 @@ ContentContext::ContentContext(std::shared_ptr<Context> context)
       CreateDefaultPipeline<YUVToRGBFilterPipeline>(*context_);
   porter_duff_blend_pipelines_[{}] =
       CreateDefaultPipeline<PorterDuffBlendPipeline>(*context_);
-  point_field_geometry_pipelines_[{}] =
-      CreateDefaultNonRenderingPipeline<PointFieldGeometryPipeline>(*context_);
+
+  if (context_->GetCapabilities()->SupportsDisabledRasterization()) {
+    point_field_geometry_pipelines_[{}] =
+        CreateDefaultNonRenderingPipeline<PointFieldGeometryPipeline>(
+            *context_);
+  }
 
   if (solid_fill_pipelines_[{}]->GetDescriptor().has_value()) {
     auto clip_pipeline_descriptor =

impeller/entity/contents/content_context.h

@@ -276,6 +276,7 @@ using FramebufferBlendScreenPipeline =
 using FramebufferBlendSoftLightPipeline =
     RenderPipelineT<FramebufferBlendVertexShader,
                     FramebufferBlendSoftlightFragmentShader>;
+
 /// Geometry Pipelines
 using PointFieldGeometryPipeline =
     RenderPipelineT<PointsVertexShader, NonRenderingFragment>;
@@ -669,6 +670,7 @@ class ContentContext {
 
   std::shared_ptr<Pipeline<PipelineDescriptor>> GetPointFieldGeometryPipeline(
       ContentContextOptions opts) const {
+    FML_DCHECK(GetDeviceCapabilities().SupportsDisabledRasterization());
     return GetPipeline(point_field_geometry_pipelines_, opts);
   }
 

impeller/entity/geometry.cc

@@ -902,6 +902,8 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
     const ContentContext& renderer,
     const Entity& entity,
     RenderPass& pass) {
+  FML_DCHECK(renderer.GetDeviceCapabilities().SupportsDisabledRasterization());
+
   auto divisions_per_circle = ComputeResultSize(
       entity.GetTransformation().GetMaxBasisLength() * radius_, points_.size());
   auto total = divisions_per_circle * points_.size() * 3;
@@ -951,7 +953,6 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
   frame_info.radian_step = k2Pi / divisions_per_circle;
   frame_info.points_per_circle = divisions_per_circle * 3;
   frame_info.divisions_per_circle = divisions_per_circle;
-  frame_info.total_length = total;
 
   VS::BindFrameInfo(cmd, host_buffer.EmplaceUniform(frame_info));
   VS::BindGeometryData(
@@ -968,7 +969,6 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
       .vertex_buffer = {.vertex_buffer = {.buffer = buffer,
                                           .range =
                                               Range{0, total * sizeof(Point)}},
-
                         .index_buffer = index_buffer,
                         .index_count = index_count,
                         .index_type = IndexType::k32bit},
@@ -984,7 +984,7 @@ GeometryResult PointFieldGeometry::GetPositionUVBuffer(
     const ContentContext& renderer,
     const Entity& entity,
     RenderPass& pass) {
-  return {};
+  FML_UNREACHABLE();
 }
 
 /// @brief Compute the exact storage size needed to store the resulting buffer.

impeller/entity/shaders/geometry/points.vert

@@ -13,7 +13,6 @@ uniform FrameInfo {
   float16_t radian_step;
   int points_per_circle;
   int divisions_per_circle;
-  int total_length;
 }
 frame_info;
 

impeller/renderer/backend/metal/context_mtl.mm

@@ -62,6 +62,7 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
       .SetSupportsComputeSubgroups(DeviceSupportsComputeSubgroups(device))
       .SetSupportsReadFromResolve(true)
       .SetSupportsReadFromOnscreenTexture(true)
+      .SetSupportsDisabledRasterization(true)
       .Build();
 }
 

impeller/renderer/capabilities.cc

@@ -66,6 +66,11 @@ class StandardCapabilities final : public Capabilities {
     return supports_decal_tile_mode_;
   }
 
+  // |Capabilities|
+  bool SupportsDisabledRasterization() const override {
+    return supports_disabled_rasterization_;
+  }
+
   // |Capabilities|
   PixelFormat GetDefaultColorFormat() const override {
     return default_color_format_;
@@ -88,6 +93,7 @@ class StandardCapabilities final : public Capabilities {
                        bool supports_read_from_onscreen_texture,
                        bool supports_read_from_resolve,
                        bool supports_decal_tile_mode,
+                       bool supports_disabled_rasterization,
                        PixelFormat default_color_format,
                        PixelFormat default_stencil_format)
       : has_threading_restrictions_(has_threading_restrictions),
@@ -102,6 +108,7 @@ class StandardCapabilities final : public Capabilities {
             supports_read_from_onscreen_texture),
         supports_read_from_resolve_(supports_read_from_resolve),
         supports_decal_tile_mode_(supports_decal_tile_mode),
+        supports_disabled_rasterization_(supports_disabled_rasterization),
         default_color_format_(default_color_format),
         default_stencil_format_(default_stencil_format) {}
 
@@ -118,6 +125,7 @@ class StandardCapabilities final : public Capabilities {
   bool supports_read_from_onscreen_texture_ = false;
   bool supports_read_from_resolve_ = false;
   bool supports_decal_tile_mode_ = false;
+  bool supports_disabled_rasterization_ = false;
   PixelFormat default_color_format_ = PixelFormat::kUnknown;
   PixelFormat default_stencil_format_ = PixelFormat::kUnknown;
 
@@ -202,6 +210,12 @@ CapabilitiesBuilder& CapabilitiesBuilder::SetSupportsDecalTileMode(bool value) {
   return *this;
 }
 
+CapabilitiesBuilder& CapabilitiesBuilder::SetSupportsDisabledRasterization(
+    bool value) {
+  supports_disabled_rasterization_ = value;
+  return *this;
+}
+
 std::unique_ptr<Capabilities> CapabilitiesBuilder::Build() {
   return std::unique_ptr<StandardCapabilities>(new StandardCapabilities(  //
       has_threading_restrictions_,                                        //
@@ -215,6 +229,7 @@ std::unique_ptr<Capabilities> CapabilitiesBuilder::Build() {
       supports_read_from_onscreen_texture_,                               //
       supports_read_from_resolve_,                                        //
       supports_decal_tile_mode_,                                          //
+      supports_disabled_rasterization_,                                   //
       *default_color_format_,                                             //
       *default_stencil_format_                                            //
       ));

impeller/renderer/capabilities.h

@@ -37,6 +37,8 @@ class Capabilities {
 
   virtual bool SupportsDecalTileMode() const = 0;
 
+  virtual bool SupportsDisabledRasterization() const = 0;
+
   virtual PixelFormat GetDefaultColorFormat() const = 0;
 
   virtual PixelFormat GetDefaultStencilFormat() const = 0;
@@ -79,6 +81,8 @@ class CapabilitiesBuilder {
 
   CapabilitiesBuilder& SetSupportsDecalTileMode(bool value);
 
+  CapabilitiesBuilder& SetSupportsDisabledRasterization(bool value);
+
   std::unique_ptr<Capabilities> Build();
 
  private:
@@ -93,6 +97,7 @@ class CapabilitiesBuilder {
   bool supports_read_from_onscreen_texture_ = false;
   bool supports_read_from_resolve_ = false;
   bool supports_decal_tile_mode_ = false;
+  bool supports_disabled_rasterization_ = false;
   std::optional<PixelFormat> default_color_format_ = std::nullopt;
   std::optional<PixelFormat> default_stencil_format_ = std::nullopt;
 

impeller/renderer/capabilities_unittests.cc

@@ -29,6 +29,7 @@ CAPABILITY_TEST(SupportsComputeSubgroups, false);
 CAPABILITY_TEST(SupportsReadFromOnscreenTexture, false);
 CAPABILITY_TEST(SupportsReadFromResolve, false);
 CAPABILITY_TEST(SupportsDecalTileMode, false);
+CAPABILITY_TEST(SupportsDisabledRasterization, false);
 
 }  // namespace testing
 }  // namespace impeller

impeller/renderer/pipeline_builder.h

@@ -21,7 +21,7 @@ class NonRenderingFragment {
   static constexpr std::string_view kLabel = "NonRendering";
   static constexpr std::string_view kEntrypointName = "non_rendering_main";
   static constexpr ShaderStage kShaderStage = ShaderStage::kFragment;
-  static constexpr std::string_view kGeneratorName = "";
+  static constexpr std::string_view kGeneratorName = "NonRendering";
   static constexpr std::array<DescriptorSetLayout, 0> kDescriptorSetLayouts{};
 };