Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS] Use CVDisplayLink to drive repaint #49159

Merged
knopp merged 8 commits into from
Feb 27, 2024
Merged

[macOS] Use CVDisplayLink to drive repaint #49159

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d546a7d
[macOS] Use CVDisplayLink to drive repaint
knopp Dec 25, 2023
02ca690
Nits
knopp Jan 19, 2024
b393e2c
extract constant out
knopp Feb 21, 2024
a34e734
rename main thread to platform thread
knopp Feb 21, 2024
85840f4
add TODO
knopp Feb 21, 2024
58931a0
header gueards
knopp Feb 21, 2024
0f32c9a
Use correct timescale for host time
knopp Feb 26, 2024
a4910bc
nit: reorder header
knopp Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add TODO
  • Loading branch information
@knopp
knopp committed Feb 27, 2024
commit 85840f491f3baf41a674316b8f74d214e57e453a
1 change: 1 addition & 0 deletions shell/platform/darwin/macos/framework/Source/FlutterEngine.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,7 @@ - (void)engineCallbackOnPreEngineRestart {

- (void)onVSync:(uintptr_t)baton {
@synchronized(_vsyncWaiters) {
// TODO(knopp): Use vsync waiter for correct view.
FlutterVSyncWaiter* waiter = [_vsyncWaiters objectForKey:@(kFlutterImplicitViewId)];
Copy link
Member

@cbracken cbracken Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we'll need to generalise this for multi-views, in which case, you'll want to add a TODO here to wire up the proper view ID with an issue link. You may need to file a new subissue under flutter/flutter#142845 if nothing existing fits.

Copy link
Member Author

@knopp knopp Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a TODO for this. Right now it seems a bit unclear how exactly vsync is going to work with multiview. We might not have a viewId available.

At least for the multiview MVP we'll probably use some heuristic for this - i.e. if views are on different displays use waiter for view on primary display, or with display with higher refresh. We'll cross that bridge when we get there, but either way this should be a minor change.

[waiter waitForVSync:baton];
}
Expand Down