This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[macOS] Use CVDisplayLink to drive repaint #49159
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d546a7d
[macOS] Use CVDisplayLink to drive repaint
knopp 02ca690
Nits
knopp b393e2c
extract constant out
knopp a34e734
rename main thread to platform thread
knopp 85840f4
add TODO
knopp 58931a0
header gueards
knopp 0f32c9a
Use correct timescale for host time
knopp a4910bc
nit: reorder header
knopp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
[macOS] Use CVDisplayLink to drive repaint
- Loading branch information
commit d546a7daeb32b3b818a5b6d7d53648b1d4ae25c7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
shell/platform/darwin/macos/framework/Source/FlutterDisplayLink.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #import <AppKit/AppKit.h> | ||
|
|
||
| @protocol FlutterDisplayLinkDelegate <NSObject> | ||
| - (void)onDisplayLink:(CFTimeInterval)timestamp targetTimestamp:(CFTimeInterval)targetTimestamp; | ||
| @end | ||
|
|
||
| /// Provides notifications of display refresh. | ||
| /// | ||
| /// Internally FlutterDisplayLink will use at most one CVDisplayLink per | ||
| /// screen shared for all views belonging to that screen. This is necessary | ||
| /// because each CVDisplayLink comes with its own thread. | ||
| @interface FlutterDisplayLink : NSObject | ||
|
|
||
| /// Creates new instance tied to provided NSView. FlutterDisplayLink | ||
| /// will track view display changes transparently to synchronize | ||
| /// update with display refresh. | ||
| /// This function must be called on the main thread. | ||
| + (instancetype)displayLinkWithView:(NSView*)view; | ||
|
|
||
| /// Delegate must be set on main thread. Delegate method will be called on | ||
| /// on display link thread. | ||
| @property(nonatomic, weak) id<FlutterDisplayLinkDelegate> delegate; | ||
|
|
||
| /// Pauses and resumes the display link. May be called from any thread. | ||
| @property(readwrite) BOOL paused; | ||
|
|
||
| /// Returns the nominal refresh period of the display to which the view | ||
| /// currently belongs (in seconds). If view does not belong to any display, | ||
| /// returns 0. Can be called from any thread. | ||
| @property(readonly) CFTimeInterval nominalOutputRefreshPeriod; | ||
|
|
||
| /// Invalidates the display link. Must be called on the main thread. | ||
| - (void)invalidate; | ||
|
|
||
| @end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.