This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] Fix Scene clip bounds. Trigger resize on DPR Change. #50161
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f4286eb
[web] Scene must pass a logical size as its clip bounds.
ditman cf027d4
Add DisplayDprStream class.
ditman 6124efb
Wire the DPR Stream to the Custom element dimensions provider. Remove…
ditman 4246857
Address some PR comments.
ditman f0348c9
Remove test of deleted method.
ditman fdd3d5c
Some more PR comments.
ditman 96b0ff6
Add a couple of happy case tests.
ditman 8f1a7e8
Make custom element dimensions provider broadcast null events, simila…
ditman 90c71e4
Remove TestOn annotation from test files.
ditman b061ada
Clarify Logical Pixels explanation.
ditman c4933d1
Clarify why onResize emits null events.
ditman 3f19731
Inject the dprChanged Stream from the constructor, instead of grabbin…
ditman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Inject the dprChanged Stream from the constructor, instead of grabbin…
…g a static field directly.
- Loading branch information
commit 3f19731ee4e08bc3cf8daad6ca9573382d21fa41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.