Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix Scene clip bounds. Trigger resize on DPR Change. #50161

Merged
auto-submit merged 12 commits into from
Feb 6, 2024
Merged

[web] Fix Scene clip bounds. Trigger resize on DPR Change. #50161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4286eb
[web] Scene must pass a logical size as its clip bounds.
ditman Jan 30, 2024
cf027d4
Add DisplayDprStream class.
ditman Jan 31, 2024
6124efb
Wire the DPR Stream to the Custom element dimensions provider. Remove…
ditman Jan 31, 2024
4246857
Address some PR comments.
ditman Jan 31, 2024
f0348c9
Remove test of deleted method.
ditman Jan 31, 2024
fdd3d5c
Some more PR comments.
ditman Jan 31, 2024
96b0ff6
Add a couple of happy case tests.
ditman Jan 31, 2024
8f1a7e8
Make custom element dimensions provider broadcast null events, simila…
ditman Feb 1, 2024
90c71e4
Remove TestOn annotation from test files.
ditman Feb 2, 2024
b061ada
Clarify Logical Pixels explanation.
ditman Feb 5, 2024
c4933d1
Clarify why onResize emits null events.
ditman Feb 6, 2024
3f19731
Inject the dprChanged Stream from the constructor, instead of grabbin…
ditman Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove TestOn annotation from test files.
  • Loading branch information
@ditman
ditman committed Feb 2, 2024
commit 90c71e4979912e9b1a600b0a16e7aed4092c878c
3 changes: 0 additions & 3 deletions ...est/engine/view_embedder/dimensions_provider/custom_element_dimensions_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('browser')
library;

import 'dart:async';

import 'package:test/bootstrap/browser.dart';
Expand Down
3 changes: 0 additions & 3 deletions lib/web_ui/test/engine/view_embedder/dimensions_provider/dimensions_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('browser')
library;

import 'package:test/bootstrap/browser.dart';
import 'package:test/test.dart';
import 'package:ui/src/engine.dart';
Expand Down
3 changes: 0 additions & 3 deletions ..._ui/test/engine/view_embedder/dimensions_provider/full_page_dimensions_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('browser')
library;

import 'dart:async';

import 'package:test/bootstrap/browser.dart';
Expand Down
3 changes: 0 additions & 3 deletions lib/web_ui/test/engine/view_embedder/display_dpr_stream_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('browser')
library;

import 'dart:async';

import 'package:test/bootstrap/browser.dart';
Expand Down